headers
Miquel van Smoorenburg | 24 Aug 2012 11:57

[PATCH] debian: symlink mdmon pidfile into /run/sendsigs.omit.d

Some daemons should not be killed when the system is shutting down. In 
debian this is achieved by putting a file with the pid of the daemon in 
it in /run/sendsigs.omit.d (or a symlink to its pidfile).

This patch lets mdmon automatically create a symlink in 
/run/sendsigs.omit.d to its pidfile.

See also debian bug 684708 at
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=684708  ,
where I submitted a previous version of this patch.

Comments welcome.

Thanks,

Mike.

Index: mdadm-3.2.5/mdmon.c
===================================================================
--- mdadm-3.2.5.orig/mdmon.c	2012-08-13 09:46:43.205209547 +0000
+++ mdadm-3.2.5/mdmon.c	2012-08-24 09:44:45.472421616 +0000
 <at>  <at>  -142,6 +142,9  <at>  <at> 

 static int make_pidfile(char *devname)
 {
+#ifdef SENDSIGS_OMIT_DIR
+	char sendsigs_omit_path[100];
+#endif
 	char path[100];
(Continue reading)

Permalink | Reply |
headers
Dmitrijs Ledkovs | 24 Aug 2012 13:12
Picon
Favicon
Gravatar

Re: [PATCH] debian: symlink mdmon pidfile into /run/sendsigs.omit.d

On 24 August 2012 10:57, Miquel van Smoorenburg <mikevs <at> xs4all.net> wrote:
> Some daemons should not be killed when the system is shutting down. In
> debian this is achieved by putting a file with the pid of the daemon in it
> in /run/sendsigs.omit.d (or a symlink to its pidfile).
>
> This patch lets mdmon automatically create a symlink in /run/sendsigs.omit.d
> to its pidfile.
>
> See also debian bug 684708 at
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=684708  ,
> where I submitted a previous version of this patch.
>
> Comments welcome.
>

For upstream, it might be more appropriate to have a configurable
MDMON_PIDDIR, which defaults to $MDMON_DIR. As far as I know,
sendssigs.omit.d is very specific to Debian and it's derivatives, and
it's not used in the brave new systemd world.

Regards,

Dmitrijs.
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply |
headers
Miquel van Smoorenburg | 24 Aug 2012 13:49

Re: [PATCH] debian: symlink mdmon pidfile into /run/sendsigs.omit.d

On 24-08-12 1:12 PM, Dmitrijs Ledkovs wrote:
> On 24 August 2012 10:57, Miquel van Smoorenburg <mikevs <at> xs4all.net> wrote:
>> Some daemons should not be killed when the system is shutting down. In
>> debian this is achieved by putting a file with the pid of the daemon in it
>> in /run/sendsigs.omit.d (or a symlink to its pidfile).
>>
>> This patch lets mdmon automatically create a symlink in /run/sendsigs.omit.d
>> to its pidfile.
>>
>> See also debian bug 684708 at
>> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=684708  ,
>> where I submitted a previous version of this patch.
>>
>> Comments welcome.
>>
>
> For upstream, it might be more appropriate to have a configurable
> MDMON_PIDDIR, which defaults to $MDMON_DIR. As far as I know,
> sendssigs.omit.d is very specific to Debian and it's derivatives, and
> it's not used in the brave new systemd world.

Well, I'm not sure if there's a guideline for this in debian, but the 
convention appears to be to put the pidfiles in /run or a 
package-specific subdir of /run, and then to create a symlink from the 
sendsigs.omit.d directory to the pidfile- which is exactly what this 
patch does. If you're saying that something debian-specific like this 
should not be in the upstream package, then that's fine, and the patch 
will just be carried in debian. No problem.

Note that I am not the debian mdadm maintainer, it's just that often
(Continue reading)

Permalink | Reply |
headers
NeilBrown | 24 Aug 2012 14:31
Picon
Gravatar

Re: [PATCH] debian: symlink mdmon pidfile into /run/sendsigs.omit.d

On Fri, 24 Aug 2012 13:49:52 +0200 Miquel van Smoorenburg <mikevs <at> xs4all.net>
wrote:

> On 24-08-12 1:12 PM, Dmitrijs Ledkovs wrote:
> > On 24 August 2012 10:57, Miquel van Smoorenburg <mikevs <at> xs4all.net> wrote:
> >> Some daemons should not be killed when the system is shutting down. In
> >> debian this is achieved by putting a file with the pid of the daemon in it
> >> in /run/sendsigs.omit.d (or a symlink to its pidfile).
> >>
> >> This patch lets mdmon automatically create a symlink in /run/sendsigs.omit.d
> >> to its pidfile.
> >>
> >> See also debian bug 684708 at
> >> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=684708  ,
> >> where I submitted a previous version of this patch.
> >>
> >> Comments welcome.
> >>
> >
> > For upstream, it might be more appropriate to have a configurable
> > MDMON_PIDDIR, which defaults to $MDMON_DIR. As far as I know,
> > sendssigs.omit.d is very specific to Debian and it's derivatives, and
> > it's not used in the brave new systemd world.

No, the "brave new systemd world" requires that $ARGV[0] start with ' <at> ' to
avoid being killed, and mdmon has special code to support that.
So it would not be unreasonable to add special code to support
sendsigs.omit.d.

However if we only need to protect things at shutdown I wonder it you could
(Continue reading)

Permalink | Reply |
headers
Miquel van Smoorenburg | 3 Sep 2012 16:50

Re: [PATCH] debian: symlink mdmon pidfile into /run/sendsigs.omit.d

On 24-08-12 2:31 PM, NeilBrown wrote:
> On Fri, 24 Aug 2012 13:49:52 +0200 Miquel van Smoorenburg <mikevs <at> xs4all.net>
> wrote:
>
>> On 24-08-12 1:12 PM, Dmitrijs Ledkovs wrote:
>>> On 24 August 2012 10:57, Miquel van Smoorenburg <mikevs <at> xs4all.net> wrote:
>>>> Some daemons should not be killed when the system is shutting down. In
>>>> debian this is achieved by putting a file with the pid of the daemon in it
>>>> in /run/sendsigs.omit.d (or a symlink to its pidfile).
>>>>
>>>> This patch lets mdmon automatically create a symlink in /run/sendsigs.omit.d
>>>> to its pidfile.
>
> However if we only need to protect things at shutdown I wonder it you could
> just add something like:
>
>   cd /run/mdadm/
>   for file in md*.pid
>   do ln -s /run/mdadm/$file /.../sendsigs.omit.d/mdadm-$file
>   done
>
> in some script that gets run before the 'killall' happens.

Yes that would work. Very good idea!

Forget about the patch. I'll just add something like that to the stop 
section of the mdadm-raid initscript.

Thanks!
(Continue reading)

Permalink | Reply |

Gmane