Re: [PATCH] virt-install cli options for managed storage

Cole Robinson wrote:
> Per Dan's advice, I've changed the previously proposed
> virt-install cli options for specifying libvirt managed
> storage.
>
> This patch does not change any possible semantics of
> --file or --cdrom: they remain strictly for specifying
> local media. In this way they are basically deprecated.
>
> A new cli option is added: --disk. The format is:
>
> --disk  path:///some/file/path[:device=cdrom|floppy][:permissions=ro|sh]
> --disk  vol:///poolname/volname[:device=cdrom|floppy][:permissions=ro|sh]
> --disk  pool:///poolname[:device=cdrom|floppy][:permissions=ro|sh]
>
> The changes from Dan's proposal are:
>
>  - use of path:/// instead of file:///, since this will
>    hopefully clear up any confusion users previously had
>    with specifying block devices.
>  - For vol:///, I used / as a delimiter vs. ':' between
>    the pool and vol name, to avoid any extra collisions
>    (since I assume '/' is not part of a legal pool name).
>  - Explictly list what type of extra option we are
>    appending (device, permissions). This adds clarity
>    to the command line, reduces chance of name collision,
>    and is similar to the approach used by qemu.
>
> The --disk option is quite useful even for the local case,
> since users can now add cdrom and floppy drives (and eventually

Re: [PATCH] virt-install cli options for managed storage

On Tue, Aug 12, 2008 at 05:06:38PM -0400, Cole Robinson wrote:
> Per Dan's advice, I've changed the previously proposed
> virt-install cli options for specifying libvirt managed
> storage.
> 
> This patch does not change any possible semantics of
> --file or --cdrom: they remain strictly for specifying
> local media. In this way they are basically deprecated.
> 
> A new cli option is added: --disk. The format is:
> 
> --disk  path:///some/file/path[:device=cdrom|floppy][:permissions=ro|sh]
> --disk  vol:///poolname/volname[:device=cdrom|floppy][:permissions=ro|sh]
> --disk  pool:///poolname[:device=cdrom|floppy][:permissions=ro|sh]
> 
> The changes from Dan's proposal are:
> 
>  - use of path:/// instead of file:///, since this will
>    hopefully clear up any confusion users previously had
>    with specifying block devices.
>  - For vol:///, I used / as a delimiter vs. ':' between
>    the pool and vol name, to avoid any extra collisions
>    (since I assume '/' is not part of a legal pool name).
>  - Explictly list what type of extra option we are
>    appending (device, permissions). This adds clarity
>    to the command line, reduces chance of name collision,
>    and is similar to the approach used by qemu.
> 
> The --disk option is quite useful even for the local case,
> since users can now add cdrom and floppy drives (and eventually

Re: [PATCH] virt-install cli options for managed storage

Cole Robinson wrote:
> Per Dan's advice, I've changed the previously proposed
> virt-install cli options for specifying libvirt managed
> storage.
> 
> This patch does not change any possible semantics of
> --file or --cdrom: they remain strictly for specifying
> local media. In this way they are basically deprecated.
> 

Here's the second cut. Format for the cli options is

--disk path=/some/path[,device=cdrom|floppy][,permissions=ro|sh]
--disk pool=poolname[,device=cdrom|floppy][,permissions=ro|sh]
--disk vol=poolname/volname[,device=cdrom|floppy][,permissions=ro|sh]

Hopefully this will simplify things and fix the issues encountered.

Once this is committed I'll be writing up the man pages and
creating a wiki page detailing how this can all fit together
for remote installs.

Thanks,
Cole

diff -r bd9e79483f70 virt-install
--- a/virt-install	Mon Aug 11 18:20:28 2008 -0400
+++ b/virt-install	Thu Aug 14 12:22:09 2008 -0400
@@ -44,26 +44,101 @@