headers
Richard Laager | 10 Jan 02:40
Favicon
Gravatar

[PATCH] UI String Cleanups

The README file says to post hg bundles to fedora-xen. This mailing list
(as listed on the website) seems more appropriate. If this is correct,
the README should be updated. If you'd prefer this in the tracker,
please let me know. Otherwise, here is the bundle:
http://coderich.net/virt-manager-ui-tweaks.hg

This corrects a number of small UI issues. This should partially or
fully address bugs 452411, 475682, and 475926.

If the direction of this patch is good, Dan Bass, my colleague, and I
can make another pass over the bugs we've filed/subscribed to and see
what remains.

Richard

_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@...
https://www.redhat.com/mailman/listinfo/et-mgmt-tools
Permalink | Reply |
headers
Cole Robinson | 12 Jan 21:08
Picon
Favicon

Re: [PATCH] UI String Cleanups

Richard Laager wrote:

Thanks for the contribution! And doubly thanks for all the bugs you guys
have been filing, it is greatly appreciated.

> The README file says to post hg bundles to fedora-xen. This mailing list
> (as listed on the website) seems more appropriate. If this is correct,
> the README should be updated. If you'd prefer this in the tracker,
> please let me know. Otherwise, here is the bundle:
> http://coderich.net/virt-manager-ui-tweaks.hg
>

This is the correct mailing list, but it's probably better to send
things as 'hg exports' rather than bundles. No harm now though, but I'll
update the README.

> This corrects a number of small UI issues. This should partially or
> fully address bugs 452411, 475682, and 475926.
> 
> If the direction of this patch is good, Dan Bass, my colleague, and I
> can make another pass over the bugs we've filed/subscribed to and see
> what remains.
> 

Patches look good. Had some trouble applying the first one, but I
gathered the gist of it and adapted it against the latest upstream. I
also combined all the label/wording changes into one patch for simplicity:

http://hg.et.redhat.com/cgi-bin/hg-virt.cgi/applications/virt-manager--devel/rev/94f8363b03a8
http://hg.et.redhat.com/cgi-bin/hg-virt.cgi/applications/virt-manager--devel/rev/25ad7f471b5c
(Continue reading)

Permalink | Reply |
headers
Richard Laager | 13 Jan 00:09
Favicon
Gravatar

Re: [PATCH] UI String Cleanups

On Mon, 2009-01-12 at 15:08 -0500, Cole Robinson wrote:
> This is the correct mailing list, but it's probably better to send
> things as 'hg exports' rather than bundles. No harm now though, but I'll
> update the README.

This should probably be updated as well:
http://virt-manager.et.redhat.com/scmrepo.html

> > This corrects a number of small UI issues. This should partially or
> > fully address bugs 452411, 475682, and 475926.

I took a look at those (and other bugs we filed) and prepared a few more
minor UI changes:

The attached patch should address the remainder of the issues in
#452411, so it can be closed (assuming you agree with my comment about
the pause action there).

It also addresses the wording in #475926 (and similar other cases), but
does not address the buttons. I imagine I'd have to create the dialog
myself, rather than use gtk.MessageDialog? I'm familiar with GTK+, but
not the PyGTK wrapper, so any pointers would be helpful.

The patch addresses the wording changes in #478408, but not the more
in-depth suggestions:
        Alternatively, if the first item in the list is always selected
        (making it impossible to select nothing if the list is
        non-empty), then the physical device radio button could be
        greyed out when the list is empty; this would make this error
        message entirely unnecessary.
(Continue reading)

Permalink | Reply |
headers
Cole Robinson | 14 Jan 17:05
Picon
Favicon

Re: [PATCH] UI String Cleanups

Richard Laager wrote:
> On Mon, 2009-01-12 at 15:08 -0500, Cole Robinson wrote:
>> This is the correct mailing list, but it's probably better to send
>> things as 'hg exports' rather than bundles. No harm now though, but I'll
>> update the README.
> 
> This should probably be updated as well:
> http://virt-manager.et.redhat.com/scmrepo.html
> 
>>> This corrects a number of small UI issues. This should partially or
>>> fully address bugs 452411, 475682, and 475926.
> 
> I took a look at those (and other bugs we filed) and prepared a few more
> minor UI changes:
> 
> The attached patch should address the remainder of the issues in
> #452411, so it can be closed (assuming you agree with my comment about
> the pause action there).

Excellent, thanks.

> 
> It also addresses the wording in #475926 (and similar other cases), but
> does not address the buttons. I imagine I'd have to create the dialog
> myself, rather than use gtk.MessageDialog? I'm familiar with GTK+, but
> not the PyGTK wrapper, so any pointers would be helpful.
> 

This can hold off a bit. We need a revamped delete dialog anyways to
optionally allow deleting the VM disk storage, so I'll incorporate this
(Continue reading)

Permalink | Reply |
headers
Cole Robinson | 23 Jan 22:35
Picon
Favicon

Re: [PATCH] UI String Cleanups

Cole Robinson wrote:
> Richard Laager wrote:
>> On Mon, 2009-01-12 at 15:08 -0500, Cole Robinson wrote:
>>> This is the correct mailing list, but it's probably better to send
>>> things as 'hg exports' rather than bundles. No harm now though, but I'll
>>> update the README.
>> This should probably be updated as well:
>> http://virt-manager.et.redhat.com/scmrepo.html
>>
>>>> This corrects a number of small UI issues. This should partially or
>>>> fully address bugs 452411, 475682, and 475926.
>> I took a look at those (and other bugs we filed) and prepared a few more
>> minor UI changes:
>>
>> The attached patch should address the remainder of the issues in
>> #452411, so it can be closed (assuming you agree with my comment about
>> the pause action there).
> 
> Excellent, thanks.
> 
>> It also addresses the wording in #475926 (and similar other cases), but
>> does not address the buttons. I imagine I'd have to create the dialog
>> myself, rather than use gtk.MessageDialog? I'm familiar with GTK+, but
>> not the PyGTK wrapper, so any pointers would be helpful.
>>
> 
> This can hold off a bit. We need a revamped delete dialog anyways to
> optionally allow deleting the VM disk storage, so I'll incorporate this
> change when that work is done.
>
(Continue reading)

Permalink | Reply |

Gmane