Package reviews for Fedora ()

bugzilla | 31 Jul 2012 18:55

Picon

[Bug 836821] New: Review Request: libcec - Library for HDMI-CEC device control

https://bugzilla.redhat.com/show_bug.cgi?id=836821

            Bug ID: 836821
        QA Contact: extras-qa <at> fedoraproject.org
          Severity: unspecified
           Version: rawhide
          Priority: unspecified
                CC: notting <at> redhat.com,
                    package-review <at> lists.fedoraproject.org,
                    volker27 <at> gmx.at
          Assignee: nobody <at> fedoraproject.org
           Summary: Review Request: libcec - Library for HDMI-CEC device
                    control
        Regression: ---
      Story Points: ---
    Classification: Fedora
                OS: Unspecified
          Reporter: pbrobinson <at> gmail.com
              Type: Bug
     Documentation: ---
          Hardware: Unspecified
        Mount Type: ---
            Status: NEW
         Component: Package Review
           Product: Fedora
                CC: volker27 <at> gmx.at

SPEC: http://pbrobinson.fedorapeople.org/libcec.spec
SRPM: http://pbrobinson.fedorapeople.org/libcec-1.7.1-1.fc17.src.rpm

(Continue reading)

bugzilla | 25 Aug 2012 23:09

Picon

[Bug 836821] Review Request: libcec - Library for HDMI-CEC device control

https://bugzilla.redhat.com/show_bug.cgi?id=836821

Volker Fröhlich <volker27 <at> gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(pbrobinson <at> gmail.
                   |                            |com)

--

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review <at> lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

bugzilla | 26 Sep 2012 17:16

Picon

[Bug 836821] Review Request: libcec - Library for HDMI-CEC device control

https://bugzilla.redhat.com/show_bug.cgi?id=836821

Peter Robinson <pbrobinson <at> gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(pbrobinson <at> gmail. |
                   |com)                        |

--- Comment #2 from Peter Robinson <pbrobinson <at> gmail.com> ---
Sorry about delayed response. 1.8.x had build issues, and I've been away. 1.9.0
now builds so updated.

(In reply to comment #1)
> The license is GPLv2+, but it is actually dual-licensed:

Fedora doesn't use the commercial license option so it's the only relevant
license for our use case

> The FSF address is outdated and should be replaced. Also let upstream know.

I'll fix it when it's fixed upstream (it might be already in 1.9.0) but I'll
let them know

> If this is a snapshot, the release should be different:
> http://fedoraproject.org/wiki/Packaging:NamingGuidelines#NonNumericRelease

No it's not a snapshot. It's the release using their git tag. Theit github
generated archives have issues so we generate them from the git source but it's
still a tagged release so we can still use the standard NVRs

(Continue reading)

bugzilla | 26 Sep 2012 17:17

Picon

[Bug 836821] Review Request: libcec - Library for HDMI-CEC device control

https://bugzilla.redhat.com/show_bug.cgi?id=836821

--- Comment #3 from Peter Robinson <pbrobinson <at> gmail.com> ---
Volker: are you doing a proper review on this? if so please assign as
appropriate

--

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review <at> lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

bugzilla | 26 Sep 2012 17:24

Picon

[Bug 836821] Review Request: libcec - Library for HDMI-CEC device control

https://bugzilla.redhat.com/show_bug.cgi?id=836821

--- Comment #4 from Volker Fröhlich <volker27 <at> gmx.at> ---
GPLv2+ -- not GPLv2

If I'll take the review, I'll assign myself. For now I'm commenting.

It's easier for the reviewer if you bump the release on changes and leave
changelog entries.

--

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review <at> lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

bugzilla | 8 Oct 2012 17:48

Picon

[Bug 836821] Review Request: libcec - Library for HDMI-CEC device control

https://bugzilla.redhat.com/show_bug.cgi?id=836821

Valent Turkovic <valent.turkovic <at> gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |valent.turkovic <at> gmail.com
              Flags|                            |needinfo?(nobody <at> fedoraproj
                   |                            |ect.org)

--- Comment #5 from Valent Turkovic <valent.turkovic <at> gmail.com> ---
Hi, is there any chance for libcec to be included in upcoming Fedora 18?

--

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review <at> lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

bugzilla | 8 Oct 2012 17:59

Picon

[Bug 836821] Review Request: libcec - Library for HDMI-CEC device control

https://bugzilla.redhat.com/show_bug.cgi?id=836821

--- Comment #6 from Volker Fröhlich <volker27 <at> gmx.at> ---
As soon as the review is done, it can go to F16 and up.

--

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review <at> lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

bugzilla | 8 Oct 2012 21:42

Picon

[Bug 836821] Review Request: libcec - Library for HDMI-CEC device control

https://bugzilla.redhat.com/show_bug.cgi?id=836821

Volker Fröhlich <volker27 <at> gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|nobody <at> fedoraproject.org    |volker27 <at> gmx.at
              Flags|needinfo?(nobody <at> fedoraproj |
                   |ect.org)                    |
              Flags|                            |fedora-review?

--- Comment #7 from Volker Fröhlich <volker27 <at> gmx.at> ---
Remove the trailing slash from the URL.

Is the license of ADL compatible with GPLv2?

I think you should BR libudev-devel. systemd-devel doesn't seem to be necessary
though.

The sentences in %description should have periods, as they are proper
sentences.

There's a Windoze executable that should be removed in the %prep section:
http://fedoraproject.org/wiki/Packaging:Guidelines#No_inclusion_of_pre-built_binaries_or_libraries

The files section could be more specific:

%{_libdir}/%{name}.so.* or at least libcec.so.*. Stating the exact name of the
two executables in bindir also wouldn't hurt.

(Continue reading)

bugzilla | 4 Nov 2012 18:32

Picon

[Bug 836821] Review Request: libcec - Library for HDMI-CEC device control

https://bugzilla.redhat.com/show_bug.cgi?id=836821

--- Comment #8 from Peter Robinson <pbrobinson <at> gmail.com> ---
> Is the license of ADL compatible with GPLv2?

Where's ADL?

> I think you should BR libudev-devel. systemd-devel doesn't seem to be
> necessary though.

udev is now part of systemd and the libudev-devel is provided by systemd-devel

On a F-18 system do "repoquery --whatprovides libudev-devel"

> The sentences in %description should have periods, as they are proper
> sentences.

Fixed

> There's a Windoze executable that should be removed in the %prep section:
> http://fedoraproject.org/wiki/Packaging:Guidelines#No_inclusion_of_pre-
> built_binaries_or_libraries

Fixed

> The files section could be more specific:
> 
> %{_libdir}/%{name}.so.* or at least libcec.so.*. Stating the exact name of
> the two executables in bindir also wouldn't hurt.

(Continue reading)

bugzilla | 12 Nov 2012 16:27

Picon

[Bug 836821] Review Request: libcec - Library for HDMI-CEC device control

https://bugzilla.redhat.com/show_bug.cgi?id=836821

--- Comment #9 from Peter Robinson <pbrobinson <at> gmail.com> ---
Updated to 2.0.3

SRPM: http://pbrobinson.fedorapeople.org/libcec-2.0.3-1.fc17.src.rpm

--

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review <at> lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

bugzilla | 18 Nov 2012 20:42

Picon

[Bug 836821] Review Request: libcec - Library for HDMI-CEC device control

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=836821

Volker Fröhlich <volker27 <at> gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |
              Flags|                            |fedora-review+

--- Comment #10 from Volker Fröhlich <volker27 <at> gmx.at> ---
(In reply to comment #8)
> > Is the license of ADL compatible with GPLv2?
> 
> Where's ADL?

Please forget that.

> 
> > [!]: Package contains systemd file(s) if in need.
> > Doesn't need one, I think.
> 
> What systemd files. There's none there.

That's an artifact from not knowing systemd provides libudev-devel.

> > That's not a tragedy. On the other hand, the macros don't serve a purpose
> > there.
> 
> They serve as documentation

(Continue reading)

bugzilla | 18 Nov 2012 20:50

Picon

[Bug 836821] Review Request: libcec - Library for HDMI-CEC device control

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=836821

Peter Robinson <pbrobinson <at> gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
              Flags|                            |fedora-cvs?

--- Comment #11 from Peter Robinson <pbrobinson <at> gmail.com> ---
Thanks for the review

New Package GIT Request
=======================
Package Name: libcec
Short Description: Library and utilities for HDMI-CEC device control
Owners: pbrobinson
Branches: F-17 F-18
InitialCC:

--

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review <at> lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

bugzilla | 19 Nov 2012 12:06

Picon

[Bug 836821] Review Request: libcec - Library for HDMI-CEC device control

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=836821

--- Comment #12 from Jon Ciesla <limburgher <at> gmail.com> ---
Git done (by process-git-requests).

--

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review <at> lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

bugzilla | 25 Nov 2012 16:26

Picon

[Bug 836821] Review Request: libcec - Library for HDMI-CEC device control

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=836821

Peter Robinson <pbrobinson <at> gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2012-11-25 10:26:53

--

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review <at> lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

bugzilla | 8 Jan 2013 14:34

Picon

[Bug 836821] Review Request: libcec - Library for HDMI-CEC device control

Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=836821

Mohamed El Morabity <pikachu.2014 <at> gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pikachu.2014 <at> gmail.com

--- Comment #13 from Mohamed El Morabity <pikachu.2014 <at> gmail.com> ---
libcec was only built for F18, whereas a branch was requested for F17 too. Are
there any plans to make it available for F17 too?

--

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ETsdMZANn5&a=cc_unsubscribe
_______________________________________________
package-review mailing list
package-review <at> lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

Return

Return to gmane.linux.redhat.fedora.reviews.

Advertisement

Project Web Page

Package reviews for Fedora ()

Search Archive

Language

Change language

Options

Current view: Threads only / Showing only 20 lines / Not hiding cited text.
Change to All messages, whole messages, or hide cited text.

Post a message
NNTP Newsgroup
Classic Gmane web interface
XML

XML

RSS Feed
List Information

About Gmane