1 Sep 2005 03:00
FW: [Fwd: Re: [PATCH scsi-misc 2/2] megaraid_sas: LSI Logic MegaR AID SAS RA ID D river]
Bagalkote, Sreenivas <sreenib <at> lsil.com>
2005-09-01 01:00:06 GMT
2005-09-01 01:00:06 GMT
> Looks pretty good to me. Small issues I've identified: > > - what do you need the hba_count attribute for? This should be > implementable in userspace pretty easily by iterating of all > devices of the scsi_host class that are attached to the driver > - the ->queuecommand cleanup patch I sent you a awhile ago doesn't > seem to be applied > - there's quite a lot of slightly odd formating, it would be nice > if you could run the code through scripts/Lindent. > > If you could sent out an unmangled patch (even as attachment or on > LSI's ftp side) I'd like to take another, closer look. Contd. from prev mail Patch 2 of 2 Signed-off-by: Sreenivas Bagalkote <Sreenivas.Bagalkote <at> lsil.com> ----------------------- diff -Naur scsi_misc-b/drivers/scsi/megaraid/megaraid_sas.c scsi_misc-c/drivers/scsi/megaraid/megaraid_sas.c --- scsi_misc-b/drivers/scsi/megaraid/megaraid_sas.c 1969-12-31 19:00:00.000000000 -0500 +++ scsi_misc-c/drivers/scsi/megaraid/megaraid_sas.c 2005-08-31 19:39:55.001126424 -0400 <at> <at> -0,0 +1,2800 <at> <at> +/* + * + * Linux MegaRAID driver for SAS based RAID controllers + *(Continue reading)
RSS Feed