1 Feb 2004 16:34
[PATCH] remove procfs write support from tmscsim
Christoph Hellwig <hch <at> lst.de>
2004-02-01 15:34:50 GMT
2004-02-01 15:34:50 GMT
When looking at the driver after reviewing the changes I stubled over
that code. Almost all of the funcitonality (except DUMP) should go
through the midlayer and will at least cause some confusion if it
doesn't.
Also the implementation isn't exactly nice, like kmalloced scsi commands
and the tytpical 'parsing' macros cut & pasted over all historic scsi
drivers. I think we're better of removing it completly and maybe readd
dump as a sysfs attribute if needed.
500 lines of code gone.
--- 1.25/drivers/scsi/tmscsim.c Fri Dec 19 16:53:43 2003
+++ edited/drivers/scsi/tmscsim.c Sat Jan 31 06:41:21 2004
<at> <at> -1871,25 +1871,6 <at> <at>
pDCB->CtrlR1 |= PARITY_ERR_REPO;
}
-
-/***********************************************************************
- * Function : static void dc390_updateDCBs ()
- *
- * Purpose : Set the configuration dependent DCB params for all DCBs
- ***********************************************************************/
-
-static void dc390_updateDCBs (PACB pACB)
-{
- int i;
- PDCB pDCB = pACB->pLinkDCB;
- for (i = 0; i < pACB->DCBCnt; i++)
(Continue reading)
RSS Feed