Using serial devices under linux

Timur Tabi | 10 Jan 2008 00:35

[PATCH] [SERIAL] qe-uart: add support for Freescale QUICCEngine UART

Add file ucc_uart.c, a serial device driver for the Freescale QUICCEngine.
Update the Kconfig and Makefile accordingly.

Signed-off-by: Timur Tabi <timur <at> freescale.com>
---
 drivers/serial/Kconfig    |   10 +
 drivers/serial/Makefile   |    1 +
 drivers/serial/ucc_uart.c | 1507 +++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 1518 insertions(+), 0 deletions(-)
 create mode 100644 drivers/serial/ucc_uart.c

diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
index d7e1996..d962b74 100644
--- a/drivers/serial/Kconfig
+++ b/drivers/serial/Kconfig
 <at>  <at>  -1284,4 +1284,14  <at>  <at>  config SERIAL_OF_PLATFORM
 	  Currently, only 8250 compatible ports are supported, but
 	  others can easily be added.

+config SERIAL_QE
+	tristate "Freescale QUICC Engine serial port support"
+	depends on QUICC_ENGINE
+	select SERIAL_CORE
+	select FW_LOADER
+	default n
+	help
+	  This driver supports the QE serial ports on Freescale embedded
+	  PowerPC that contain a QUICC Engine.
+
 endmenu

(Continue reading)

headers

Kumar Gala | 15 Jan 2008 15:21

Re: [PATCH] [SERIAL] qe-uart: add support for Freescale QUICCEngine UART


On Jan 9, 2008, at 5:35 PM, Timur Tabi wrote:

> Add file ucc_uart.c, a serial device driver for the Freescale  
> QUICCEngine.
> Update the Kconfig and Makefile accordingly.
>
> Signed-off-by: Timur Tabi <timur <at> freescale.com>
> ---
> drivers/serial/Kconfig    |   10 +
> drivers/serial/Makefile   |    1 +
> drivers/serial/ucc_uart.c | 1507 ++++++++++++++++++++++++++++++++++++ 
> +++++++++
> 3 files changed, 1518 insertions(+), 0 deletions(-)
> create mode 100644 drivers/serial/ucc_uart.c
>

>
> diff --git a/drivers/serial/ucc_uart.c b/drivers/serial/ucc_uart.c
> new file mode 100644
> index 0000000..6fe4cfc
> --- /dev/null
> +++ b/drivers/serial/ucc_uart.c
>  <at>  <at>  -0,0 +1,1507  <at>  <at> 
> +/*
> + * Freescale QUICC Engine UART device driver
> + *
> + * Author: Timur Tabi <timur <at> freescale.com>
> + *
> + * Copyright 2007 Freescale Semiconductor, Inc.  This file is

(Continue reading)

headers

Timur Tabi | 15 Jan 2008 16:03

Re: [PATCH] [SERIAL] qe-uart: add support for Freescale QUICCEngine UART

Kumar Gala wrote:

> what is the define for?  you commented all the others :)

I thought you said there were no more issues? 

>> +#define UCC_WAIT_CLOSING 100

This is how long to wait after receiving a close request for characters to be 
sent out before actually closing the device.  I just used the same value as the 
CPM serial driver.

>> +    u16 tx_state;       /* 0xC6, TX state */
> 
> __be16?

Oops.

>> +/*
>> + * Set the modem control lines
>> + *
>> + * We currently don't support setting modem control lines, but this 
>> function
>> + * needs to exist, otherwise the kernel will panic.
>> + */
>> +void qe_uart_set_mctrl(struct uart_port *port, unsigned int mctrl)
>> +{
>> +}
> 
> What's the issue w/support of this?  (maybe a comment related to why its

(Continue reading)

headers

Kumar Gala | 15 Jan 2008 16:13

Re: [PATCH] [SERIAL] qe-uart: add support for Freescale QUICCEngine UART


On Jan 15, 2008, at 9:03 AM, Timur Tabi wrote:

> Kumar Gala wrote:
>
>> what is the define for?  you commented all the others :)
>
> I thought you said there were no more issues? 

I lied, get use to it ;)

(I was going to apply the patch and thus scanned over it).

>
>
>>> +#define UCC_WAIT_CLOSING 100
>
> This is how long to wait after receiving a close request for  
> characters to be sent out before actually closing the device.  I  
> just used the same value as the CPM serial driver.

Yeah, I just meant a comment to this fact would be nice.

>
>
>
>>> +    u16 tx_state;       /* 0xC6, TX state */
>> __be16?
>
> Oops.

(Continue reading)