gmane.linux.serial

[PATCH RESEND] MAX3100 SPI UART driver

This patch adds support for the MAX3100 SPI UART. I am still
waiting for a minor number from device <at> lanana.org so that
may change.

Generated on  20081002  against v2.6.27-rc7

Signed-off-by: Christian Pellegrin <chripell <at> fsfe.org>
---
 drivers/serial/Kconfig         |    6 +-
 drivers/serial/Makefile        |    1 +
 drivers/serial/max3100.c       |  924 ++++++++++++++++++++++++++++++++++++++++
 include/linux/serial_core.h    |    3 +
 include/linux/serial_max3100.h |   53 +++
 5 files changed, 986 insertions(+), 1 deletions(-)

diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
index 77cb342..de3193d 100644
--- a/drivers/serial/Kconfig
+++ b/drivers/serial/Kconfig
@@ -509,7 +509,11 @@ config SERIAL_S3C2440
 	help
 	  Serial port support for the Samsung S3C2440 and S3C2442 SoC

-
+config SERIAL_MAX3100
+        tristate "MAX3100 support"
+        depends on SPI
+        help
+          MAX3100 chip support

(Continue reading)

headers

Andrew Morton | 8 Oct 23:26

Re: [PATCH RESEND] MAX3100 SPI UART driver

On Thu,  2 Oct 2008 10:39:13 +0200
Christian Pellegrin <chripell@...> wrote:

> This patch adds support for the MAX3100 SPI UART. I am still
> waiting for a minor number from device@... so that
> may change.
> 

Both Alan and I had numerous review comments on the previous version of
this patch.

You have not sent us a point-by-point response to those review comments
which forces us to a) go back and see what all the comments were then
b) check the patch to see if/how each point was addressed.  Needless to
say, that's not a ton of fun for us.

Can you please reply to our earlier emails and let us know what changes
were made against each review comment?

Thanks.

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/

headers

chri | 9 Oct 07:44

Re: [PATCH RESEND] MAX3100 SPI UART driver

On Wed, Oct 8, 2008 at 11:26 PM, Andrew Morton
<akpm <at> linux-foundation.org> wrote:

> Can you please reply to our earlier emails and let us know what changes
> were made against each review comment?
>

OK, sorry, I just did what you said to do.  I' going to reply immediately.

> Thanks.
>

Sorry again for the misunderstanding.

Bye,

--

-- 
Christian Pellegrin, see http://www.evolware.org/chri/
"Real Programmers don't play tennis, or any other sport which requires
you to change clothes. Mountain climbing is OK, and Real Programmers
wear their climbing boots to work in case a mountain should suddenly
spring up in the middle of the computer room."
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html