Shawn Guo | 7 May 02:53 2012

[PATCH RESEND 0/5] Adopt pinctrl support for a few outstanding imx drivers

With patch 5b3aa5f (pinctrl: add pinctrl_provide_dummies interface for
platforms to use) applied on pinctrl tree, and patch "ARM: imx: enable
pinctrl dummy states" [1] being there, we are ready to adopt pinctrl
API for imx drivers.  So let's start from a few outstanding ones.

I would expect to ask Arnd and Olof to pull pinctrl tree into arm-soc
as a dependency and then have series [1] and this patch set go through
arm-soc tree to ease the merge process.

Resend to have subsystem lists Cc-ed.

Regards,
Shawn

[1] http://thread.gmane.org/gmane.linux.kernel.mmc/14180

Shawn Guo (5):
  tty: serial: imx: adopt pinctrl support
  net: fec: adopt pinctrl support
  can: flexcan: adopt pinctrl support
  i2c: imx: adopt pinctrl support
  spi/imx: adopt pinctrl support

 drivers/i2c/busses/i2c-imx.c         |    8 ++++++++
 drivers/net/can/flexcan.c            |    6 ++++++
 drivers/net/ethernet/freescale/fec.c |    9 +++++++++
 drivers/spi/spi-imx.c                |    8 ++++++++
 drivers/tty/serial/imx.c             |    8 ++++++++
 5 files changed, 39 insertions(+), 0 deletions(-)

(Continue reading)

Shawn Guo | 7 May 02:54 2012

[PATCH RESEND 5/5] spi/imx: adopt pinctrl support

Cc: spi-devel-general@...
Cc: Grant Likely <grant.likely@...>
Signed-off-by: Shawn Guo <shawn.guo@...>
---
 drivers/spi/spi-imx.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
index 570f220..69c9a66 100644
--- a/drivers/spi/spi-imx.c
+++ b/drivers/spi/spi-imx.c
 <at>  <at>  -37,6 +37,7  <at>  <at> 
 #include <linux/of.h>
 #include <linux/of_device.h>
 #include <linux/of_gpio.h>
+#include <linux/pinctrl/consumer.h>

 #include <mach/spi.h>

 <at>  <at>  -758,6 +759,7  <at>  <at>  static int __devinit spi_imx_probe(struct platform_device *pdev)
 	struct spi_master *master;
 	struct spi_imx_data *spi_imx;
 	struct resource *res;
+	struct pinctrl *pinctrl;
 	int i, ret, num_cs;

 	if (!np && !mxc_platform_info) {
 <at>  <at>  -845,6 +847,12  <at>  <at>  static int __devinit spi_imx_probe(struct platform_device *pdev)
 		goto out_iounmap;
 	}
(Continue reading)

Dong Aisheng | 8 May 05:45 2012

Re: [PATCH RESEND 5/5] spi/imx: adopt pinctrl support

On Mon, May 07, 2012 at 08:54:00AM +0800, Shawn Guo wrote:
> Cc: spi-devel-general <at> lists.sourceforge.net
> Cc: Grant Likely <grant.likely <at> secretlab.ca>
> Signed-off-by: Shawn Guo <shawn.guo <at> linaro.org>
> ---
>  drivers/spi/spi-imx.c |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
Acked-by: Dong Aisheng <dong.aisheng <at> linaro.org>

Regards
Dong Aisheng
Grant Likely | 20 May 06:40 2012
Picon

Re: [PATCH RESEND 5/5] spi/imx: adopt pinctrl support

On Tue, 8 May 2012 11:45:46 +0800, Dong Aisheng
<aisheng.dong@...> wrote:
> On Mon, May 07, 2012 at 08:54:00AM +0800, Shawn Guo wrote:
> > Cc: spi-devel-general@...
> > Cc: Grant Likely <grant.likely@...>
> > Signed-off-by: Shawn Guo <shawn.guo@...>
> > ---
> >  drivers/spi/spi-imx.c |    8 ++++++++
> >  1 files changed, 8 insertions(+), 0 deletions(-)
> Acked-by: Dong Aisheng <dong.aisheng@...>
Acked-by: Grant Likely <grant.likely@...>

Can I assume all the patches in this series will be merged via the
same branch?

g.

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
Shawn Guo | 20 May 07:19 2012

Re: [PATCH RESEND 5/5] spi/imx: adopt pinctrl support

On Sat, May 19, 2012 at 10:40:30PM -0600, Grant Likely wrote:
> Can I assume all the patches in this series will be merged via the
> same branch?
> 
Yes, we will have them all go via arm-soc.

--

-- 
Regards,
Shawn

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
Dong Aisheng | 7 May 08:50 2012

Re: [PATCH RESEND 0/5] Adopt pinctrl support for a few outstanding imx drivers

On Mon, May 07, 2012 at 08:53:55AM +0800, Shawn Guo wrote:
> With patch 5b3aa5f (pinctrl: add pinctrl_provide_dummies interface for
> platforms to use) applied on pinctrl tree, and patch "ARM: imx: enable
> pinctrl dummy states" [1] being there, we are ready to adopt pinctrl
> API for imx drivers.  So let's start from a few outstanding ones.
> 
> I would expect to ask Arnd and Olof to pull pinctrl tree into arm-soc
> as a dependency and then have series [1] and this patch set go through
> arm-soc tree to ease the merge process.
> 
Shouldn't we add the pinctrl states in dts file at the same time
with this patch series or using another separate patch to add them
before this series to avoid breaking the exist mx6q platforms?

> Resend to have subsystem lists Cc-ed.
> 
> Regards,
> Shawn
> 
> [1] http://thread.gmane.org/gmane.linux.kernel.mmc/14180
> 
> Shawn Guo (5):
>   tty: serial: imx: adopt pinctrl support
...

>   net: fec: adopt pinctrl support
>   can: flexcan: adopt pinctrl support
This two also depends on another patch you sent.
[PATCH RESEND 1/9] ARM: mxs: enable pinctrl dummy states
http://www.spinics.net/lists/arm-kernel/msg173341.html
(Continue reading)

Shawn Guo | 7 May 09:34 2012

Re: [PATCH RESEND 0/5] Adopt pinctrl support for a few outstanding imx drivers

On Mon, May 07, 2012 at 02:50:02PM +0800, Dong Aisheng wrote:
> Shouldn't we add the pinctrl states in dts file at the same time
> with this patch series or using another separate patch to add them
> before this series to avoid breaking the exist mx6q platforms?
> 
Ah, I just noticed that your patch "ARM: imx: enable pinctrl dummy
states" did not cover imx6q.  I think we should do the same for imx6q,
so that we can separate dts update from the driver change.  When all
imx6q boards' dts files get updated to have pins defined for the
devices, we can then remove dummy state for imx6q.  Doing so will ease
the pinctrl migration for those imx6q boards.

Will update your patch on my branch to have dummy state enabled for
imx6q.

> >   net: fec: adopt pinctrl support
> >   can: flexcan: adopt pinctrl support
> This two also depends on another patch you sent.
> [PATCH RESEND 1/9] ARM: mxs: enable pinctrl dummy states
> http://www.spinics.net/lists/arm-kernel/msg173341.html
> 
> Maybe you can put this two in the mxs convert series to avoid breaking
> mxs platforms.
> [PATCH 0/9] Enable pinctrl support for mach-mxs
> http://www.spinics.net/lists/arm-kernel/msg173312.html
> 
Right.  I'm going to merge these two series into one since there are
device drives shared between imx and mxs.

--

-- 
(Continue reading)

Dong Aisheng | 7 May 09:53 2012

Re: [PATCH RESEND 0/5] Adopt pinctrl support for a few outstanding imx drivers

On Mon, May 07, 2012 at 03:34:06PM +0800, Shawn Guo wrote:
> On Mon, May 07, 2012 at 02:50:02PM +0800, Dong Aisheng wrote:
> > Shouldn't we add the pinctrl states in dts file at the same time
> > with this patch series or using another separate patch to add them
> > before this series to avoid breaking the exist mx6q platforms?
> > 
> Ah, I just noticed that your patch "ARM: imx: enable pinctrl dummy
> states" did not cover imx6q.  I think we should do the same for imx6q,
Yes, doing that was to force people to add pinctrl states in dts file
rather than using dummy state since mx6 supports pinctrl driver.

> so that we can separate dts update from the driver change.  When all
> imx6q boards' dts files get updated to have pins defined for the
> devices, we can then remove dummy state for imx6q.  Doing so will ease
> the pinctrl migration for those imx6q boards.
> 
Well, considering we have several mx6 boards, i think i can also be fine
with this way to ease the mx6q pinctrl migration.

> Will update your patch on my branch to have dummy state enabled for
> imx6q.
> 
Then go ahead.

Regards
Dong Aisheng

--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo <at> vger.kernel.org
(Continue reading)

Shawn Guo | 7 May 02:53 2012

[PATCH RESEND 2/5] net: fec: adopt pinctrl support

Cc: netdev <at> vger.kernel.org
Cc: David S. Miller <davem <at> davemloft.net>
Signed-off-by: Shawn Guo <shawn.guo <at> linaro.org>
---
 drivers/net/ethernet/freescale/fec.c |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/drivers/net/ethernet/freescale/fec.c b/drivers/net/ethernet/freescale/fec.c
index a12b3f5..500c106 100644
--- a/drivers/net/ethernet/freescale/fec.c
+++ b/drivers/net/ethernet/freescale/fec.c
 <at>  <at>  -48,6 +48,7  <at>  <at> 
 #include <linux/of_device.h>
 #include <linux/of_gpio.h>
 #include <linux/of_net.h>
+#include <linux/pinctrl/consumer.h>

 #include <asm/cacheflush.h>

 <at>  <at>  -1542,6 +1543,7  <at>  <at>  fec_probe(struct platform_device *pdev)
 	struct resource *r;
 	const struct of_device_id *of_id;
 	static int dev_id;
+	struct pinctrl *pinctrl;

 	of_id = of_match_device(fec_dt_ids, &pdev->dev);
 	if (of_id)
 <at>  <at>  -1609,6 +1611,12  <at>  <at>  fec_probe(struct platform_device *pdev)
 		}
 	}
(Continue reading)

Dong Aisheng | 8 May 05:44 2012

Re: [PATCH RESEND 2/5] net: fec: adopt pinctrl support

On Mon, May 07, 2012 at 08:53:57AM +0800, Shawn Guo wrote:
> Cc: netdev <at> vger.kernel.org
> Cc: David S. Miller <davem <at> davemloft.net>
> Signed-off-by: Shawn Guo <shawn.guo <at> linaro.org>

Acked-by: Dong Aisheng <dong.aisheng <at> linaro.org>

Regards
Dong Aisheng

David Miller | 12 May 00:31 2012
Picon

Re: [PATCH RESEND 2/5] net: fec: adopt pinctrl support

From: Shawn Guo <shawn.guo <at> linaro.org>
Date: Mon,  7 May 2012 08:53:57 +0800

> Cc: netdev <at> vger.kernel.org
> Cc: David S. Miller <davem <at> davemloft.net>
> Signed-off-by: Shawn Guo <shawn.guo <at> linaro.org>

Acked-by: David S. Miller <davem <at> davemloft.net>
Shawn Guo | 7 May 02:53 2012

[PATCH RESEND 1/5] tty: serial: imx: adopt pinctrl support

Cc: linux-serial <at> vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh <at> linuxfoundation.org>
Signed-off-by: Shawn Guo <shawn.guo <at> linaro.org>
---
 drivers/tty/serial/imx.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
index e7fecee..ec20673 100644
--- a/drivers/tty/serial/imx.c
+++ b/drivers/tty/serial/imx.c
 <at>  <at>  -47,6 +47,7  <at>  <at> 
 #include <linux/slab.h>
 #include <linux/of.h>
 #include <linux/of_device.h>
+#include <linux/pinctrl/consumer.h>

 #include <asm/io.h>
 #include <asm/irq.h>
 <at>  <at>  -1464,6 +1465,7  <at>  <at>  static int serial_imx_probe(struct platform_device *pdev)
 	void __iomem *base;
 	int ret = 0;
 	struct resource *res;
+	struct pinctrl *pinctrl;

 	sport = kzalloc(sizeof(*sport), GFP_KERNEL);
 	if (!sport)
 <at>  <at>  -1503,6 +1505,12  <at>  <at>  static int serial_imx_probe(struct platform_device *pdev)
 	sport->timer.function = imx_timeout;
 	sport->timer.data     = (unsigned long)sport;
(Continue reading)

Dong Aisheng | 8 May 05:43 2012

Re: [PATCH RESEND 1/5] tty: serial: imx: adopt pinctrl support

On Mon, May 07, 2012 at 08:53:56AM +0800, Shawn Guo wrote:
> Cc: linux-serial <at> vger.kernel.org
> Cc: Greg Kroah-Hartman <gregkh <at> linuxfoundation.org>
> Signed-off-by: Shawn Guo <shawn.guo <at> linaro.org>
> ---
>  drivers/tty/serial/imx.c |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
> 
Acked-by: Dong Aisheng <dong.aisheng <at> linaro.org>

Regards
Dong Aisheng

--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Shawn Guo | 7 May 02:53 2012

[PATCH RESEND 3/5] can: flexcan: adopt pinctrl support

Cc: linux-can <at> vger.kernel.org
Cc: Marc Kleine-Budde <mkl <at> pengutronix.de>
Signed-off-by: Shawn Guo <shawn.guo <at> linaro.org>
---
 drivers/net/can/flexcan.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
index 1efb083..38c0690 100644
--- a/drivers/net/can/flexcan.c
+++ b/drivers/net/can/flexcan.c
 <at>  <at>  -35,6 +35,7  <at>  <at> 
 #include <linux/module.h>
 #include <linux/of.h>
 #include <linux/platform_device.h>
+#include <linux/pinctrl/consumer.h>

 #define DRV_NAME			"flexcan"

 <at>  <at>  -927,11 +928,16  <at>  <at>  static int __devinit flexcan_probe(struct platform_device *pdev)
 	struct flexcan_priv *priv;
 	struct resource *mem;
 	struct clk *clk = NULL;
+	struct pinctrl *pinctrl;
 	void __iomem *base;
 	resource_size_t mem_size;
 	int err, irq;
 	u32 clock_freq = 0;

+	pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
(Continue reading)

Marc Kleine-Budde | 7 May 10:06 2012
Picon

Re: [PATCH RESEND 3/5] can: flexcan: adopt pinctrl support

Hello,

On 05/07/2012 02:53 AM, Shawn Guo wrote:
> Cc: linux-can <at> vger.kernel.org
> Cc: Marc Kleine-Budde <mkl <at> pengutronix.de>
> Signed-off-by: Shawn Guo <shawn.guo <at> linaro.org>
> ---

It doesn't compile yet against net-next/master, which is based on v3.4-rc4:

/home/frogger/pengutronix/socketcan/linux/drivers/net/can/flexcan.c: In
function 'flexcan_probe':
/home/frogger/pengutronix/socketcan/linux/drivers/net/can/flexcan.c:937:
error: implicit declaration of function 'devm_pinctrl_get_select_default'
/home/frogger/pengutronix/socketcan/linux/drivers/net/can/flexcan.c:937:
warning: assignment makes pointer from integer without a cast

Which tree does this series depend on? If this should go over the
linux-can tree, I have to ask David first to merge this.

regards,
Marc

--

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

(Continue reading)

Shawn Guo | 7 May 10:17 2012

Re: [PATCH RESEND 3/5] can: flexcan: adopt pinctrl support

On 7 May 2012 16:06, Marc Kleine-Budde <mkl <at> pengutronix.de> wrote:
> It doesn't compile yet against net-next/master, which is based on v3.4-rc4:
>
> /home/frogger/pengutronix/socketcan/linux/drivers/net/can/flexcan.c: In
> function 'flexcan_probe':
> /home/frogger/pengutronix/socketcan/linux/drivers/net/can/flexcan.c:937:
> error: implicit declaration of function 'devm_pinctrl_get_select_default'
> /home/frogger/pengutronix/socketcan/linux/drivers/net/can/flexcan.c:937:
> warning: assignment makes pointer from integer without a cast
>
> Which tree does this series depend on? If this should go over the
> linux-can tree, I have to ask David first to merge this.
>
Thanks for the response, Marc.  The patch depends on pinctrl tree and
a couple of other patches that will go through arm-soc tree, so I
would like to ask for your ack to have the patch go over arm-soc tree.

Regards,
Shawn
--
To unsubscribe from this list: send the line "unsubscribe linux-can" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Marc Kleine-Budde | 7 May 10:29 2012
Picon

Re: [PATCH RESEND 3/5] can: flexcan: adopt pinctrl support

On 05/07/2012 10:17 AM, Shawn Guo wrote:
> On 7 May 2012 16:06, Marc Kleine-Budde <mkl <at> pengutronix.de> wrote:
>> It doesn't compile yet against net-next/master, which is based on v3.4-rc4:
>>
>> /home/frogger/pengutronix/socketcan/linux/drivers/net/can/flexcan.c: In
>> function 'flexcan_probe':
>> /home/frogger/pengutronix/socketcan/linux/drivers/net/can/flexcan.c:937:
>> error: implicit declaration of function 'devm_pinctrl_get_select_default'
>> /home/frogger/pengutronix/socketcan/linux/drivers/net/can/flexcan.c:937:
>> warning: assignment makes pointer from integer without a cast
>>
>> Which tree does this series depend on? If this should go over the
>> linux-can tree, I have to ask David first to merge this.
>>
> Thanks for the response, Marc.  The patch depends on pinctrl tree and
> a couple of other patches that will go through arm-soc tree, so I
> would like to ask for your ack to have the patch go over arm-soc tree.

Fine with me. David, is this okay? Shawn, better wait for David's okay.

Acked-by: Marc Kleine-Budde <mkl <at> pengutronix.de>

regards, Marc

--

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

(Continue reading)

Shawn Guo | 7 May 02:53 2012

[PATCH RESEND 4/5] i2c: imx: adopt pinctrl support

Cc: linux-i2c@...
Cc: Wolfram Sang <w.sang@...>
Signed-off-by: Shawn Guo <shawn.guo@...>
---
 drivers/i2c/busses/i2c-imx.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
index dfb84b7..56bce9a 100644
--- a/drivers/i2c/busses/i2c-imx.c
+++ b/drivers/i2c/busses/i2c-imx.c
 <at>  <at>  -51,6 +51,7  <at>  <at> 
 #include <linux/of.h>
 #include <linux/of_device.h>
 #include <linux/of_i2c.h>
+#include <linux/pinctrl/consumer.h>

 #include <mach/irqs.h>
 #include <mach/hardware.h>
 <at>  <at>  -470,6 +471,7  <at>  <at>  static int __init i2c_imx_probe(struct platform_device *pdev)
 	struct imx_i2c_struct *i2c_imx;
 	struct resource *res;
 	struct imxi2c_platform_data *pdata = pdev->dev.platform_data;
+	struct pinctrl *pinctrl;
 	void __iomem *base;
 	resource_size_t res_size;
 	int irq, bitrate;
 <at>  <at>  -520,6 +522,12  <at>  <at>  static int __init i2c_imx_probe(struct platform_device *pdev)
 	i2c_imx->base			= base;
 	i2c_imx->res			= res;
(Continue reading)

Dong Aisheng | 8 May 05:45 2012

Re: [PATCH RESEND 4/5] i2c: imx: adopt pinctrl support

On Mon, May 07, 2012 at 08:53:59AM +0800, Shawn Guo wrote:
> Cc: linux-i2c@...
> Cc: Wolfram Sang <w.sang@...>
> Signed-off-by: Shawn Guo <shawn.guo@...>
> ---
>  drivers/i2c/busses/i2c-imx.c |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
Acked-by: Dong Aisheng <dong.aisheng@...>

Regards
Dong Aisheng


Gmane