John Williams | 6 Feb 05:22 2012
Picon

nx-libs breaks with libpng 1.5.x

Archlinux just upgraded libpng 1.4.x to 1.5.8, and it appears to have
broken nx-libs. With libpng 1.4.8, I was able to build nx-libs 3.5.0.9
and successfully run it with x2goserver, but with libpng 1.5.8, when I
try to build nx-libs it gets to compiling Pgn.cpp and fails with
errors:

g++ -c -O3 -fno-rtti -fno-exceptions -I../nx-X11/exports/include
-Wno-deprecated -fPIC -DIN_ADDR_T=in_addr_t -DVERSION=\"3.5.0\"
-DPACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\" -DPACKAGE_VERSION=\"\"
-DPACKAGE_STRING=\"\" -DPACKAGE_BUGREPORT=\"\" -Wall -Wpointer-arith
Pgn.cpp

Pgn.cpp: In function ‘int DecompressPng16(unsigned char*, int,
unsigned int, unsigned int, unsigned char*, int)’:
Pgn.cpp:417:15: error: invalid use of incomplete type ‘png_info {aka
struct png_info_def}’
/usr/include/png.h:720:16: error: forward declaration of ‘png_info
{aka struct png_info_def}’

Pgn.cpp: In function ‘int DecompressPng24(unsigned char*, int,
unsigned int, unsigned int, unsigned char*, int)’:
Pgn.cpp:568:15: error: invalid use of incomplete type ‘png_info {aka
struct png_info_def}’
/usr/include/png.h:720:16: error: forward declaration of ‘png_info
{aka struct png_info_def}’

Pgn.cpp: In function ‘int DecompressPng32(unsigned char*, int,
unsigned int, unsigned int, unsigned char*, int)’:
Pgn.cpp:712:15: error: invalid use of incomplete type ‘png_info {aka
struct png_info_def}’
(Continue reading)

Mike Gabriel | 6 Feb 10:51 2012
Picon

Re: nx-libs breaks with libpng 1.5.x

Hi John,

On Mo 06 Feb 2012 05:22:01 CET John Williams wrote:

> Archlinux just upgraded libpng 1.4.x to 1.5.8, and it appears to have
> broken nx-libs. With libpng 1.4.8, I was able to build nx-libs 3.5.0.9
> and successfully run it with x2goserver, but with libpng 1.5.8, when I
> try to build nx-libs it gets to compiling Pgn.cpp and fails with
> errors:
>
> g++ -c -O3 -fno-rtti -fno-exceptions -I../nx-X11/exports/include
> -Wno-deprecated -fPIC -DIN_ADDR_T=in_addr_t -DVERSION=\"3.5.0\"
> -DPACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\" -DPACKAGE_VERSION=\"\"
> -DPACKAGE_STRING=\"\" -DPACKAGE_BUGREPORT=\"\" -Wall -Wpointer-arith
> Pgn.cpp
>
> Pgn.cpp: In function 'int DecompressPng16(unsigned char*, int,
> unsigned int, unsigned int, unsigned char*, int)':
> Pgn.cpp:417:15: error: invalid use of incomplete type 'png_info {aka
> struct png_info_def}'
> /usr/include/png.h:720:16: error: forward declaration of 'png_info
> {aka struct png_info_def}'
>
> Pgn.cpp: In function 'int DecompressPng24(unsigned char*, int,
> unsigned int, unsigned int, unsigned char*, int)':
> Pgn.cpp:568:15: error: invalid use of incomplete type 'png_info {aka
> struct png_info_def}'
> /usr/include/png.h:720:16: error: forward declaration of 'png_info
> {aka struct png_info_def}'
>
(Continue reading)

Oliver Burger | 6 Feb 11:33 2012

Re: nx-libs breaks with libpng 1.5.x

Am 06.02.2012 10:51, schrieb Mike Gabriel:
> Reinhard Tartler has made us aware of this in the Debian packaging
> context already. To address this, we first need a working concept for
> patching this. Then we will ship that patch with NX (redistributed) and
> also report to original upstream (NoMachine).
>
> Any ideas how to address this? I have not had the time for this, yet.

We do have a patch for it in Mageia (actually the patch is taken from 
openbsd) and others like fedora use a similar patch. You can have a look 
here:
http://svnweb.mageia.org/packages/cauldron/nx/current/SOURCES/nxcomp-3.5.0-2-png-1.5.patch?view=markup

http://pkgs.fedoraproject.org/gitweb/?p=nx.git;a=blob;f=nx-3.5.0-libpng15.patch;h=c8f2a95592d5330c9ba9726ec318879591b7274f;hb=8278f5e08f15c6d9c96a45e934207c5aeb97ce81

Cheers,

Oliver
Mike Gabriel | 6 Feb 12:14 2012
Picon

SOLVED -- Re: nx-libs breaks with libpng 1.5.x

Hi all,

On Mo 06 Feb 2012 11:33:08 CET Oliver Burger wrote:

> http://pkgs.fedoraproject.org/gitweb/?p=nx.git;a=blob;f=nx-3.5.0-libpng15.patch;h=c8f2a95592d5330c9ba9726ec318879591b7274f;hb=8278f5e08f15c6d9c96a45e934207c5aeb97ce81

Brilliant, the patch will be in NX (redist) 3.5.0.10:
http://code.x2go.org/gitweb?p=nx-libs.git;a=commitdiff;h=e326dd760e115dcb48f6823462a737039453a63c

Mike

--

-- 

DAS-NETZWERKTEAM
mike gabriel, dorfstr. 27, 24245 barmissen
fon: +49 (4302) 281418, fax: +49 (4302) 281419

GnuPG Key ID 0xB588399B
mail: mike.gabriel <at> das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb
_______________________________________________
X2Go-Dev mailing list
X2Go-Dev <at> lists.berlios.de
https://lists.berlios.de/mailman/listinfo/x2go-dev

Gmane