headers
richard -rw- weinberger | 6 May 2011 09:52
Picon

Re: [PATCH] for ARCH=um, optionaly give a path for the vde installation.

On Thu, May 5, 2011 at 9:34 AM,  <paul.chavent <at> fnac.net> wrote:
> Hi.
>
> I use uml with vde. The kernel links against libvdeplug.a and automatically find it. But i would like to
manually give its path.
>
> So i made a patch for being able to give the VDE_PREFIX when we call make.
>
> I wonder if this patch could be included in the mainstream kernel, or if there is a better way of doing it.
>
> Could you give me your opinion please ?

Please post your patch.
Otherwise nobody can review it.

--

-- 
Thanks,
//richard

------------------------------------------------------------------------------
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network 
management toolset available today.  Delivers lowest initial 
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd
Permalink | Reply |
headers
Paul Chavent | 6 May 2011 20:10

Re: [PATCH] for ARCH=um, optionaly give a path for the vde installation.

On 05/06/2011 09:52 AM, richard -rw- weinberger wrote:
>
> On Thu, May 5, 2011 at 9:34 AM,<paul.chavent <at> fnac.net>  wrote:
>> Hi.
>>
>> I use uml with vde. The kernel links against libvdeplug.a and automatically find it. But i would like to
manually give its path.
>>
>> So i made a patch for being able to give the VDE_PREFIX when we call make.
>>
>> I wonder if this patch could be included in the mainstream kernel, or if there is a better way of doing it.
>>
>> Could you give me your opinion please ?
>
> Please post your patch.
> Otherwise nobody can review it.
>
Damned

thank you for reminding me :)

diff -Nur linux-2.6.26.5.orig/arch/um/drivers/Makefile linux-2.6.26.5.mod/arch/um/drivers/Makefile
--- linux-2.6.26.5.orig/arch/um/drivers/Makefile	2008-08-02 00:58:24.000000000 +0200
+++ linux-2.6.26.5.mod/arch/um/drivers/Makefile	2008-08-06 14:09:04.000000000 +0200
 <at>  <at>  -19,7 +19,12  <at>  <at> 

 LDFLAGS_pcap.o := -r $(shell $(CC) $(KBUILD_CFLAGS) -print-file-name=libpcap.a)

-LDFLAGS_vde.o := -r $(shell $(CC) $(CFLAGS) -print-file-name=libvdeplug.a)
(Continue reading)

Permalink | Reply |
headers
richard -rw- weinberger | 9 May 2011 00:08
Picon

Re: [PATCH] for ARCH=um, optionaly give a path for the vde installation.

Hi,

On Fri, May 6, 2011 at 8:10 PM, Paul Chavent <paul.chavent <at> fnac.net> wrote:
> On 05/06/2011 09:52 AM, richard -rw- weinberger wrote:
>>
>> On Thu, May 5, 2011 at 9:34 AM,<paul.chavent <at> fnac.net>  wrote:
>>>
>>> Hi.
>>>
>>> I use uml with vde. The kernel links against libvdeplug.a and
>>> automatically find it. But i would like to manually give its path.
>>>
>>> So i made a patch for being able to give the VDE_PREFIX when we call
>>> make.
>>>
>>> I wonder if this patch could be included in the mainstream kernel, or if
>>> there is a better way of doing it.
>>>
>>> Could you give me your opinion please ?
>>
>> Please post your patch.
>> Otherwise nobody can review it.
>>
> Damned
>
> thank you for reminding me :)
>

Please submit patches not as attachment.
See:
(Continue reading)

Permalink | Reply |
headers
Geert Uytterhoeven | 9 May 2011 09:20

Re: [PATCH] for ARCH=um, optionaly give a path for the vde installation.

On Mon, May 9, 2011 at 00:08, richard -rw- weinberger
<richard.weinberger <at> gmail.com> wrote:
> Anyway, your patch makes use of "CFLAGS_vde_user.o",
> where is this variable used?

This syntax is used to specify additional compile options for vde_user.o.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert <at> linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

------------------------------------------------------------------------------
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network 
management toolset available today.  Delivers lowest initial 
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
Permalink | Reply |
headers
richard -rw- weinberger | 9 May 2011 09:39
Picon

Re: [PATCH] for ARCH=um, optionaly give a path for the vde installation.

On Mon, May 9, 2011 at 9:20 AM, Geert Uytterhoeven <geert <at> linux-m68k.org> wrote:
> On Mon, May 9, 2011 at 00:08, richard -rw- weinberger
> <richard.weinberger <at> gmail.com> wrote:
>> Anyway, your patch makes use of "CFLAGS_vde_user.o",
>> where is this variable used?
>
> This syntax is used to specify additional compile options for vde_user.o.
>

*headdesk*, thanks for pointing this out!

--

-- 
Thanks,
//richard

------------------------------------------------------------------------------
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network 
management toolset available today.  Delivers lowest initial 
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd
Permalink | Reply |

Gmane