Linux USB development and users ()

Keshava Munegowda | 21 Jun 2012 15:42

[PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

This commit 354ab8567ae3107a8cbe7228c3181990ba598aac titled
"Fix OMAP EHCI suspend/resume failure (i693)" is causing
the usb hub and device detection fails in beagle XM
causeing NFS not functional. This affects the core retention too.
The same commit logic needs to be revisted adhering to hwmod and
device tree framework.
for now, this commit id 354ab8567ae3107a8cbe7228c3181990ba598aac
titled "Fix OMAP EHCI suspend/resume failure (i693)" reverted.

This patch is validated on BeagleXM with NFS support over
usb ethernet and USB mass storage and other device detection.

Signed-off-by: Keshava Munegowda <keshava_mgowda@...>
---
 drivers/usb/host/ehci-omap.c |  164 +-----------------------------------------
 1 file changed, 1 insertion(+), 163 deletions(-)

diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c
index 17cfb8a..272e661 100644
--- a/drivers/usb/host/ehci-omap.c
+++ b/drivers/usb/host/ehci-omap.c
 <at>  <at>  -56,15 +56,6  <at>  <at> 
 #define	EHCI_INSNREG05_ULPI_EXTREGADD_SHIFT		8
 #define	EHCI_INSNREG05_ULPI_WRDATA_SHIFT		0

-/* Errata i693 */
-static struct clk	*utmi_p1_fck;
-static struct clk	*utmi_p2_fck;
-static struct clk	*xclk60mhsp1_ck;
-static struct clk	*xclk60mhsp2_ck;

(Continue reading)

headers

Munegowda, Keshava | 21 Jun 2012 15:43

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

On Thu, Jun 21, 2012 at 7:12 PM, Keshava Munegowda
<keshava_mgowda@...> wrote:
> This commit 354ab8567ae3107a8cbe7228c3181990ba598aac titled
> "Fix OMAP EHCI suspend/resume failure (i693)" is causing
> the usb hub and device detection fails in beagle XM
> causeing NFS not functional. This affects the core retention too.
> The same commit logic needs to be revisted adhering to hwmod and
> device tree framework.
> for now, this commit id 354ab8567ae3107a8cbe7228c3181990ba598aac
> titled "Fix OMAP EHCI suspend/resume failure (i693)" reverted.
>
> This patch is validated on BeagleXM with NFS support over
> usb ethernet and USB mass storage and other device detection.
>
> Signed-off-by: Keshava Munegowda <keshava_mgowda@...>
> ---
>  drivers/usb/host/ehci-omap.c |  164 +-----------------------------------------
>  1 file changed, 1 insertion(+), 163 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c
> index 17cfb8a..272e661 100644
> --- a/drivers/usb/host/ehci-omap.c
> +++ b/drivers/usb/host/ehci-omap.c
>  <at>  <at>  -56,15 +56,6  <at>  <at> 
>  #define        EHCI_INSNREG05_ULPI_EXTREGADD_SHIFT             8
>  #define        EHCI_INSNREG05_ULPI_WRDATA_SHIFT                0
>
> -/* Errata i693 */
> -static struct clk      *utmi_p1_fck;
> -static struct clk      *utmi_p2_fck;

(Continue reading)

headers

Kevin Hilman | 21 Jun 2012 21:02

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

"Munegowda, Keshava" <keshava_mgowda <at> ti.com> writes:

> On Thu, Jun 21, 2012 at 7:12 PM, Keshava Munegowda
> <keshava_mgowda <at> ti.com> wrote:
>> This commit 354ab8567ae3107a8cbe7228c3181990ba598aac titled
>> "Fix OMAP EHCI suspend/resume failure (i693)" is causing
>> the usb hub and device detection fails in beagle XM
>> causeing NFS not functional. This affects the core retention too.
>> The same commit logic needs to be revisted adhering to hwmod and
>> device tree framework.
>> for now, this commit id 354ab8567ae3107a8cbe7228c3181990ba598aac
>> titled "Fix OMAP EHCI suspend/resume failure (i693)" reverted.
>>
>> This patch is validated on BeagleXM with NFS support over
>> usb ethernet and USB mass storage and other device detection.
>>
>> Signed-off-by: Keshava Munegowda <keshava_mgowda <at> ti.com>

[...]

>
> hi kevin
>
> here is pm count log on beagle XM with the above patch:

What are you meaning to show by this log?    

This dump shows that neither PER or CORE are hitting retention in idle.
Which sounds to me like you have not enabled UART runtime suspend:

(Continue reading)

headers

Munegowda, Keshava | 22 Jun 2012 09:30

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

On Fri, Jun 22, 2012 at 12:32 AM, Kevin Hilman <khilman@...> wrote:
> "Munegowda, Keshava" <keshava_mgowda@...> writes:
>
>> On Thu, Jun 21, 2012 at 7:12 PM, Keshava Munegowda
>> <keshava_mgowda@...> wrote:
>>> This commit 354ab8567ae3107a8cbe7228c3181990ba598aac titled
>>> "Fix OMAP EHCI suspend/resume failure (i693)" is causing
>>> the usb hub and device detection fails in beagle XM
>>> causeing NFS not functional. This affects the core retention too.
>>> The same commit logic needs to be revisted adhering to hwmod and
>>> device tree framework.
>>> for now, this commit id 354ab8567ae3107a8cbe7228c3181990ba598aac
>>> titled "Fix OMAP EHCI suspend/resume failure (i693)" reverted.
>>>
>>> This patch is validated on BeagleXM with NFS support over
>>> usb ethernet and USB mass storage and other device detection.
>>>
>>> Signed-off-by: Keshava Munegowda <keshava_mgowda@...>
>
> [...]
>
>>
>> hi kevin
>>
>> here is pm count log on beagle XM with the above patch:
>
> What are you meaning to show by this log?
>
> This dump shows that neither PER or CORE are hitting retention in idle.
> Which sounds to me like you have not enabled UART runtime suspend:

(Continue reading)

headers

Felipe Balbi | 22 Jun 2012 12:30

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

Hi,

On Fri, Jun 22, 2012 at 01:00:39PM +0530, Munegowda, Keshava wrote:
> On Fri, Jun 22, 2012 at 12:32 AM, Kevin Hilman <khilman@...> wrote:
> > "Munegowda, Keshava" <keshava_mgowda@...> writes:
> >
> >> On Thu, Jun 21, 2012 at 7:12 PM, Keshava Munegowda
> >> <keshava_mgowda@...> wrote:
> >>> This commit 354ab8567ae3107a8cbe7228c3181990ba598aac titled
> >>> "Fix OMAP EHCI suspend/resume failure (i693)" is causing
> >>> the usb hub and device detection fails in beagle XM
> >>> causeing NFS not functional. This affects the core retention too.
> >>> The same commit logic needs to be revisted adhering to hwmod and
> >>> device tree framework.
> >>> for now, this commit id 354ab8567ae3107a8cbe7228c3181990ba598aac
> >>> titled "Fix OMAP EHCI suspend/resume failure (i693)" reverted.
> >>>
> >>> This patch is validated on BeagleXM with NFS support over
> >>> usb ethernet and USB mass storage and other device detection.
> >>>
> >>> Signed-off-by: Keshava Munegowda <keshava_mgowda@...>
> >
> > [...]
> >
> >>
> >> hi kevin
> >>
> >> here is pm count log on beagle XM with the above patch:
> >
> > What are you meaning to show by this log?

(Continue reading)

headers

Kevin Hilman | 22 Jun 2012 16:14

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

Felipe Balbi <balbi@...> writes:

> Hi,
>
> On Fri, Jun 22, 2012 at 01:00:39PM +0530, Munegowda, Keshava wrote:
>> On Fri, Jun 22, 2012 at 12:32 AM, Kevin Hilman <khilman@...> wrote:
>> > "Munegowda, Keshava" <keshava_mgowda@...> writes:
>> >
>> >> On Thu, Jun 21, 2012 at 7:12 PM, Keshava Munegowda
>> >> <keshava_mgowda@...> wrote:
>> >>> This commit 354ab8567ae3107a8cbe7228c3181990ba598aac titled
>> >>> "Fix OMAP EHCI suspend/resume failure (i693)" is causing
>> >>> the usb hub and device detection fails in beagle XM
>> >>> causeing NFS not functional. This affects the core retention too.
>> >>> The same commit logic needs to be revisted adhering to hwmod and
>> >>> device tree framework.
>> >>> for now, this commit id 354ab8567ae3107a8cbe7228c3181990ba598aac
>> >>> titled "Fix OMAP EHCI suspend/resume failure (i693)" reverted.
>> >>>
>> >>> This patch is validated on BeagleXM with NFS support over
>> >>> usb ethernet and USB mass storage and other device detection.
>> >>>
>> >>> Signed-off-by: Keshava Munegowda <keshava_mgowda@...>
>> >
>> > [...]
>> >
>> >>
>> >> hi kevin
>> >>
>> >> here is pm count log on beagle XM with the above patch:

(Continue reading)

headers

Russ Dill | 22 Jun 2012 17:03

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

On Fri, Jun 22, 2012 at 7:14 AM, Kevin Hilman <khilman <at> ti.com> wrote:
> Felipe Balbi <balbi <at> ti.com> writes:
>
>> Hi,
>>
>> On Fri, Jun 22, 2012 at 01:00:39PM +0530, Munegowda, Keshava wrote:
>>> On Fri, Jun 22, 2012 at 12:32 AM, Kevin Hilman <khilman <at> ti.com> wrote:
>>> > "Munegowda, Keshava" <keshava_mgowda <at> ti.com> writes:
>>> >
>>> >> On Thu, Jun 21, 2012 at 7:12 PM, Keshava Munegowda
>>> >> <keshava_mgowda <at> ti.com> wrote:
>>> >>> This commit 354ab8567ae3107a8cbe7228c3181990ba598aac titled
>>> >>> "Fix OMAP EHCI suspend/resume failure (i693)" is causing
>>> >>> the usb hub and device detection fails in beagle XM
>>> >>> causeing NFS not functional. This affects the core retention too.
>>> >>> The same commit logic needs to be revisted adhering to hwmod and
>>> >>> device tree framework.
>>> >>> for now, this commit id 354ab8567ae3107a8cbe7228c3181990ba598aac
>>> >>> titled "Fix OMAP EHCI suspend/resume failure (i693)" reverted.
>>> >>>
>>> >>> This patch is validated on BeagleXM with NFS support over
>>> >>> usb ethernet and USB mass storage and other device detection.
>>> >>>
>>> >>> Signed-off-by: Keshava Munegowda <keshava_mgowda <at> ti.com>
>>> >
>>> > [...]
>>> >
>>> >>
>>> >> hi kevin
>>> >>

(Continue reading)

headers

Munegowda, Keshava | 22 Jun 2012 17:11

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

On Fri, Jun 22, 2012 at 8:33 PM, Russ Dill <russ.dill@...> wrote:
> On Fri, Jun 22, 2012 at 7:14 AM, Kevin Hilman <khilman@...> wrote:
>> Felipe Balbi <balbi@...> writes:
>>
>>> Hi,
>>>
>>> On Fri, Jun 22, 2012 at 01:00:39PM +0530, Munegowda, Keshava wrote:
>>>> On Fri, Jun 22, 2012 at 12:32 AM, Kevin Hilman <khilman@...> wrote:
>>>> > "Munegowda, Keshava" <keshava_mgowda@...> writes:
>>>> >
>>>> >> On Thu, Jun 21, 2012 at 7:12 PM, Keshava Munegowda
>>>> >> <keshava_mgowda@...> wrote:
>>>> >>> This commit 354ab8567ae3107a8cbe7228c3181990ba598aac titled
>>>> >>> "Fix OMAP EHCI suspend/resume failure (i693)" is causing
>>>> >>> the usb hub and device detection fails in beagle XM
>>>> >>> causeing NFS not functional. This affects the core retention too.
>>>> >>> The same commit logic needs to be revisted adhering to hwmod and
>>>> >>> device tree framework.
>>>> >>> for now, this commit id 354ab8567ae3107a8cbe7228c3181990ba598aac
>>>> >>> titled "Fix OMAP EHCI suspend/resume failure (i693)" reverted.
>>>> >>>
>>>> >>> This patch is validated on BeagleXM with NFS support over
>>>> >>> usb ethernet and USB mass storage and other device detection.
>>>> >>>
>>>> >>> Signed-off-by: Keshava Munegowda <keshava_mgowda@...>
>>>> >
>>>> > [...]
>>>> >
>>>> >>
>>>> >> hi kevin

(Continue reading)

headers

Felipe Balbi | 22 Jun 2012 22:36

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

Hi,

On Fri, Jun 22, 2012 at 07:14:32AM -0700, Kevin Hilman wrote:
> Felipe Balbi <balbi@...> writes:
> 
> > Hi,
> >
> > On Fri, Jun 22, 2012 at 01:00:39PM +0530, Munegowda, Keshava wrote:
> >> On Fri, Jun 22, 2012 at 12:32 AM, Kevin Hilman <khilman@...> wrote:
> >> > "Munegowda, Keshava" <keshava_mgowda@...> writes:
> >> >
> >> >> On Thu, Jun 21, 2012 at 7:12 PM, Keshava Munegowda
> >> >> <keshava_mgowda@...> wrote:
> >> >>> This commit 354ab8567ae3107a8cbe7228c3181990ba598aac titled
> >> >>> "Fix OMAP EHCI suspend/resume failure (i693)" is causing
> >> >>> the usb hub and device detection fails in beagle XM
> >> >>> causeing NFS not functional. This affects the core retention too.
> >> >>> The same commit logic needs to be revisted adhering to hwmod and
> >> >>> device tree framework.
> >> >>> for now, this commit id 354ab8567ae3107a8cbe7228c3181990ba598aac
> >> >>> titled "Fix OMAP EHCI suspend/resume failure (i693)" reverted.
> >> >>>
> >> >>> This patch is validated on BeagleXM with NFS support over
> >> >>> usb ethernet and USB mass storage and other device detection.
> >> >>>
> >> >>> Signed-off-by: Keshava Munegowda <keshava_mgowda@...>
> >> >
> >> > [...]
> >> >
> >> >>

(Continue reading)

headers

Kevin Hilman | 25 Jun 2012 20:35

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

Felipe Balbi <balbi <at> ti.com> writes:

[...]

> Keshava is reverting a fix for a HW errata. I can't accept it as it will
> cause regressions. Granted, regression by regression, there's no change,
> but I simply can't knowingly cause a regression to the driver just to
> have PM working. We need a real fix for this issue.

Sure, as long as there is a fix in this -rc cycle.

This driver intoduced changes in v3.5 that break PM for the whole SoC
(by preventing CORE retention.)  These changes were clearly not tested
with PM.

If you cannot fix this during the -rc cycle, then you need to revert the
driver PM changes that broke PM for the *whole* SoC.

Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

headers

Kevin Hilman | 2 Jul 2012 18:54

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

Felipe, Keshava,

Kevin Hilman <khilman@...> writes:

> Felipe Balbi <balbi@...> writes:
>
> [...]
>
>> Keshava is reverting a fix for a HW errata. I can't accept it as it will
>> cause regressions. Granted, regression by regression, there's no change,
>> but I simply can't knowingly cause a regression to the driver just to
>> have PM working. We need a real fix for this issue.
>
> Sure, as long as there is a fix in this -rc cycle.
>
> This driver intoduced changes in v3.5 that break PM for the whole SoC
> (by preventing CORE retention.)  These changes were clearly not tested
> with PM.
>
> If you cannot fix this during the -rc cycle, then you need to revert the
> driver PM changes that broke PM for the *whole* SoC.

What's the status of this regression?

This is still broken in v3.5-rc and is preventing CORE retention for the
*whole* SoC.

Please fix this, either with a proper fix, or a revert for 3.5-rc.

Kevin

(Continue reading)

headers

Russ Dill | 2 Jul 2012 19:05

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

On Mon, Jul 2, 2012 at 9:54 AM, Kevin Hilman <khilman@...> wrote:
> Felipe, Keshava,
>
> Kevin Hilman <khilman@...> writes:
>
>> Felipe Balbi <balbi@...> writes:
>>
>> [...]
>>
>>> Keshava is reverting a fix for a HW errata. I can't accept it as it will
>>> cause regressions. Granted, regression by regression, there's no change,
>>> but I simply can't knowingly cause a regression to the driver just to
>>> have PM working. We need a real fix for this issue.
>>
>> Sure, as long as there is a fix in this -rc cycle.
>>
>> This driver intoduced changes in v3.5 that break PM for the whole SoC
>> (by preventing CORE retention.)  These changes were clearly not tested
>> with PM.
>>
>> If you cannot fix this during the -rc cycle, then you need to revert the
>> driver PM changes that broke PM for the *whole* SoC.
>
> What's the status of this regression?
>
> This is still broken in v3.5-rc and is preventing CORE retention for the
> *whole* SoC.
>
> Please fix this, either with a proper fix, or a revert for 3.5-rc.

(Continue reading)

headers

Kevin Hilman | 2 Jul 2012 19:55

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

Russ Dill <russ.dill@...> writes:

> On Mon, Jul 2, 2012 at 9:54 AM, Kevin Hilman <khilman@...> wrote:
>> Felipe, Keshava,
>>
>> Kevin Hilman <khilman@...> writes:
>>
>>> Felipe Balbi <balbi@...> writes:
>>>
>>> [...]
>>>
>>>> Keshava is reverting a fix for a HW errata. I can't accept it as it will
>>>> cause regressions. Granted, regression by regression, there's no change,
>>>> but I simply can't knowingly cause a regression to the driver just to
>>>> have PM working. We need a real fix for this issue.
>>>
>>> Sure, as long as there is a fix in this -rc cycle.
>>>
>>> This driver intoduced changes in v3.5 that break PM for the whole SoC
>>> (by preventing CORE retention.)  These changes were clearly not tested
>>> with PM.
>>>
>>> If you cannot fix this during the -rc cycle, then you need to revert the
>>> driver PM changes that broke PM for the *whole* SoC.
>>
>> What's the status of this regression?
>>
>> This is still broken in v3.5-rc and is preventing CORE retention for the
>> *whole* SoC.
>>

(Continue reading)

headers

Samuel Ortiz | 2 Jul 2012 20:15

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

Hi Kevin,

On Mon, Jul 02, 2012 at 10:55:39AM -0700, Kevin Hilman wrote:
> I'm also worried that the owners of this code are running out of time to
> fix these several serious regresions for v3.5.
FYI, I only have one omap-usb fix queued for 3.5 in my for-linus branch, see
http://git.kernel.org/?p=linux/kernel/git/sameo/mfd-2.6.git;a=shortlog;h=refs/heads/for-linus

Cheers,
Samuel.

--

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

headers

Kevin Hilman | 3 Jul 2012 02:14

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

Kevin Hilman <khilman@...> writes:

> Felipe, Keshava,
>
> Kevin Hilman <khilman@...> writes:
>
>> Felipe Balbi <balbi@...> writes:
>>
>> [...]
>>
>>> Keshava is reverting a fix for a HW errata. I can't accept it as it will
>>> cause regressions. Granted, regression by regression, there's no change,
>>> but I simply can't knowingly cause a regression to the driver just to
>>> have PM working. We need a real fix for this issue.
>>
>> Sure, as long as there is a fix in this -rc cycle.
>>
>> This driver intoduced changes in v3.5 that break PM for the whole SoC
>> (by preventing CORE retention.)  These changes were clearly not tested
>> with PM.
>>
>> If you cannot fix this during the -rc cycle, then you need to revert the
>> driver PM changes that broke PM for the *whole* SoC.
>
> What's the status of this regression?
>
> This is still broken in v3.5-rc and is preventing CORE retention for the
> *whole* SoC.
>
> Please fix this, either with a proper fix, or a revert for 3.5-rc.

(Continue reading)

headers

Munegowda, Keshava | 3 Jul 2012 08:45

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

On Tue, Jul 3, 2012 at 5:44 AM, Kevin Hilman <khilman <at> ti.com> wrote:
> Kevin Hilman <khilman <at> ti.com> writes:
>
>> Felipe, Keshava,
>>
>> Kevin Hilman <khilman <at> ti.com> writes:
>>
>>> Felipe Balbi <balbi <at> ti.com> writes:
>>>
>>> [...]
>>>
>>>> Keshava is reverting a fix for a HW errata. I can't accept it as it will
>>>> cause regressions. Granted, regression by regression, there's no change,
>>>> but I simply can't knowingly cause a regression to the driver just to
>>>> have PM working. We need a real fix for this issue.
>>>
>>> Sure, as long as there is a fix in this -rc cycle.
>>>
>>> This driver intoduced changes in v3.5 that break PM for the whole SoC
>>> (by preventing CORE retention.)  These changes were clearly not tested
>>> with PM.
>>>
>>> If you cannot fix this during the -rc cycle, then you need to revert the
>>> driver PM changes that broke PM for the *whole* SoC.
>>
>> What's the status of this regression?
>>
>> This is still broken in v3.5-rc and is preventing CORE retention for the
>> *whole* SoC.
>>

(Continue reading)

headers

Munegowda, Keshava | 3 Jul 2012 08:47

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

On Mon, Jul 2, 2012 at 10:24 PM, Kevin Hilman <khilman@...> wrote:
> Felipe, Keshava,
>
> Kevin Hilman <khilman@...> writes:
>
>> Felipe Balbi <balbi@...> writes:
>>
>> [...]
>>
>>> Keshava is reverting a fix for a HW errata. I can't accept it as it will
>>> cause regressions. Granted, regression by regression, there's no change,
>>> but I simply can't knowingly cause a regression to the driver just to
>>> have PM working. We need a real fix for this issue.
>>
>> Sure, as long as there is a fix in this -rc cycle.
>>
>> This driver intoduced changes in v3.5 that break PM for the whole SoC
>> (by preventing CORE retention.)  These changes were clearly not tested
>> with PM.
>>
>> If you cannot fix this during the -rc cycle, then you need to revert the
>> driver PM changes that broke PM for the *whole* SoC.
>
> What's the status of this regression?
>
> This is still broken in v3.5-rc and is preventing CORE retention for the
> *whole* SoC.
>
> Please fix this, either with a proper fix, or a revert for 3.5-rc.

(Continue reading)

headers

Munegowda, Keshava | 3 Jul 2012 09:22

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

On Tue, Jul 3, 2012 at 12:17 PM, Munegowda, Keshava
<keshava_mgowda@...> wrote:
> On Mon, Jul 2, 2012 at 10:24 PM, Kevin Hilman <khilman@...> wrote:
>> Felipe, Keshava,
>>
>> Kevin Hilman <khilman@...> writes:
>>
>>> Felipe Balbi <balbi@...> writes:
>>>
>>> [...]
>>>
>>>> Keshava is reverting a fix for a HW errata. I can't accept it as it will
>>>> cause regressions. Granted, regression by regression, there's no change,
>>>> but I simply can't knowingly cause a regression to the driver just to
>>>> have PM working. We need a real fix for this issue.
>>>
>>> Sure, as long as there is a fix in this -rc cycle.
>>>
>>> This driver intoduced changes in v3.5 that break PM for the whole SoC
>>> (by preventing CORE retention.)  These changes were clearly not tested
>>> with PM.
>>>
>>> If you cannot fix this during the -rc cycle, then you need to revert the
>>> driver PM changes that broke PM for the *whole* SoC.
>>
>> What's the status of this regression?
>>
>> This is still broken in v3.5-rc and is preventing CORE retention for the
>> *whole* SoC.
>>

(Continue reading)

headers

Kevin Hilman | 4 Jul 2012 15:33

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

"Munegowda, Keshava" <keshava_mgowda <at> ti.com> writes:

> On Tue, Jul 3, 2012 at 12:17 PM, Munegowda, Keshava
> <keshava_mgowda <at> ti.com> wrote:
>> On Mon, Jul 2, 2012 at 10:24 PM, Kevin Hilman <khilman <at> ti.com> wrote:
>>> Felipe, Keshava,
>>>
>>> Kevin Hilman <khilman <at> ti.com> writes:
>>>
>>>> Felipe Balbi <balbi <at> ti.com> writes:
>>>>
>>>> [...]
>>>>
>>>>> Keshava is reverting a fix for a HW errata. I can't accept it as it will
>>>>> cause regressions. Granted, regression by regression, there's no change,
>>>>> but I simply can't knowingly cause a regression to the driver just to
>>>>> have PM working. We need a real fix for this issue.
>>>>
>>>> Sure, as long as there is a fix in this -rc cycle.
>>>>
>>>> This driver intoduced changes in v3.5 that break PM for the whole SoC
>>>> (by preventing CORE retention.)  These changes were clearly not tested
>>>> with PM.
>>>>
>>>> If you cannot fix this during the -rc cycle, then you need to revert the
>>>> driver PM changes that broke PM for the *whole* SoC.
>>>
>>> What's the status of this regression?
>>>
>>> This is still broken in v3.5-rc and is preventing CORE retention for the

(Continue reading)

headers

Samuel Ortiz | 5 Jul 2012 13:19

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

Hi Kevin, Keshava,

On Wed, Jul 04, 2012 at 06:33:35AM -0700, Kevin Hilman wrote:
> "Munegowda, Keshava" <keshava_mgowda <at> ti.com> writes:
> 
> > On Tue, Jul 3, 2012 at 12:17 PM, Munegowda, Keshava
> > <keshava_mgowda <at> ti.com> wrote:
> >> On Mon, Jul 2, 2012 at 10:24 PM, Kevin Hilman <khilman <at> ti.com> wrote:
> >>> Felipe, Keshava,
> >>>
> >>> Kevin Hilman <khilman <at> ti.com> writes:
> >>>
> >>>> Felipe Balbi <balbi <at> ti.com> writes:
> >>>>
> >>>> [...]
> >>>>
> >>>>> Keshava is reverting a fix for a HW errata. I can't accept it as it will
> >>>>> cause regressions. Granted, regression by regression, there's no change,
> >>>>> but I simply can't knowingly cause a regression to the driver just to
> >>>>> have PM working. We need a real fix for this issue.
> >>>>
> >>>> Sure, as long as there is a fix in this -rc cycle.
> >>>>
> >>>> This driver intoduced changes in v3.5 that break PM for the whole SoC
> >>>> (by preventing CORE retention.)  These changes were clearly not tested
> >>>> with PM.
> >>>>
> >>>> If you cannot fix this during the -rc cycle, then you need to revert the
> >>>> driver PM changes that broke PM for the *whole* SoC.
> >>>

(Continue reading)

headers

Munegowda, Keshava | 6 Jul 2012 12:00

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

On Thu, Jul 5, 2012 at 4:49 PM, Samuel Ortiz <sameo <at> linux.intel.com> wrote:
> Hi Kevin, Keshava,
>
> On Wed, Jul 04, 2012 at 06:33:35AM -0700, Kevin Hilman wrote:
>> "Munegowda, Keshava" <keshava_mgowda <at> ti.com> writes:
>>
>> > On Tue, Jul 3, 2012 at 12:17 PM, Munegowda, Keshava
>> > <keshava_mgowda <at> ti.com> wrote:
>> >> On Mon, Jul 2, 2012 at 10:24 PM, Kevin Hilman <khilman <at> ti.com> wrote:
>> >>> Felipe, Keshava,
>> >>>
>> >>> Kevin Hilman <khilman <at> ti.com> writes:
>> >>>
>> >>>> Felipe Balbi <balbi <at> ti.com> writes:
>> >>>>
>> >>>> [...]
>> >>>>
>> >>>>> Keshava is reverting a fix for a HW errata. I can't accept it as it will
>> >>>>> cause regressions. Granted, regression by regression, there's no change,
>> >>>>> but I simply can't knowingly cause a regression to the driver just to
>> >>>>> have PM working. We need a real fix for this issue.
>> >>>>
>> >>>> Sure, as long as there is a fix in this -rc cycle.
>> >>>>
>> >>>> This driver intoduced changes in v3.5 that break PM for the whole SoC
>> >>>> (by preventing CORE retention.)  These changes were clearly not tested
>> >>>> with PM.
>> >>>>
>> >>>> If you cannot fix this during the -rc cycle, then you need to revert the
>> >>>> driver PM changes that broke PM for the *whole* SoC.

(Continue reading)

headers

Munegowda, Keshava | 6 Jul 2012 13:59

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

On Fri, Jul 6, 2012 at 3:30 PM, Munegowda, Keshava
<keshava_mgowda@...> wrote:
> On Thu, Jul 5, 2012 at 4:49 PM, Samuel Ortiz <sameo@...> wrote:
>> Hi Kevin, Keshava,
>>
>> On Wed, Jul 04, 2012 at 06:33:35AM -0700, Kevin Hilman wrote:
>>> "Munegowda, Keshava" <keshava_mgowda@...> writes:
>>>
>>> > On Tue, Jul 3, 2012 at 12:17 PM, Munegowda, Keshava
>>> > <keshava_mgowda@...> wrote:
>>> >> On Mon, Jul 2, 2012 at 10:24 PM, Kevin Hilman <khilman@...> wrote:
>>> >>> Felipe, Keshava,
>>> >>>
>>> >>> Kevin Hilman <khilman@...> writes:
>>> >>>
>>> >>>> Felipe Balbi <balbi@...> writes:
>>> >>>>
>>> >>>> [...]
>>> >>>>
>>> >>>>> Keshava is reverting a fix for a HW errata. I can't accept it as it will
>>> >>>>> cause regressions. Granted, regression by regression, there's no change,
>>> >>>>> but I simply can't knowingly cause a regression to the driver just to
>>> >>>>> have PM working. We need a real fix for this issue.
>>> >>>>
>>> >>>> Sure, as long as there is a fix in this -rc cycle.
>>> >>>>
>>> >>>> This driver intoduced changes in v3.5 that break PM for the whole SoC
>>> >>>> (by preventing CORE retention.)  These changes were clearly not tested
>>> >>>> with PM.
>>> >>>>

(Continue reading)

headers

Samuel Ortiz | 11 Jul 2012 12:29

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

Hi Keshava, Kevin,

On Fri, Jul 06, 2012 at 05:29:00PM +0530, Munegowda, Keshava wrote:
> Samuel
>           I have sent that patch to disable the ehci in
> omap2plus_defconfig; after merging that
> please merge this patch too. This will fix the crashes in during boot
> with NFS in beagleXM
I'm going to apply and push this patch for 3.5, and the defconfig patch can be
pushed through Tony's tree.
Kevin, could you please ACK it ?

Cheers,
Samuel.

--

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

headers

Munegowda, Keshava | 11 Jul 2012 14:53

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

On Wed, Jul 11, 2012 at 3:59 PM, Samuel Ortiz <sameo@...> wrote:
> Hi Keshava, Kevin,
>
> On Fri, Jul 06, 2012 at 05:29:00PM +0530, Munegowda, Keshava wrote:
>> Samuel
>>           I have sent that patch to disable the ehci in
>> omap2plus_defconfig; after merging that
>> please merge this patch too. This will fix the crashes in during boot
>> with NFS in beagleXM
> I'm going to apply and push this patch for 3.5, and the defconfig patch can be
> pushed through Tony's tree.
> Kevin, could you please ACK it ?
>
> Cheers,
> Samuel.
>

Thanks Samuel

Kevin,
    need your ack for this.
The commit id 354ab8567ae3107a8cbe7228c3181990ba598aac titled
"Fix OMAP EHCI suspend/resume failure (i693)",
is handling the clocks in ehci driver which is not correct,
it will be through the usb host driver ( /mfd/omap-usb_host.c )  exporting
APIs to ehci driver to handler the port clocks.

for now, this patch is necessary to remove the
 commit id 354ab8567ae3107a8cbe7228c3181990ba598aac titled
"Fix OMAP EHCI suspend/resume failure (i693)",

(Continue reading)

headers

Kevin Hilman | 11 Jul 2012 16:23

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

"Munegowda, Keshava" <keshava_mgowda <at> ti.com> writes:

> On Wed, Jul 11, 2012 at 3:59 PM, Samuel Ortiz <sameo <at> linux.intel.com> wrote:
>> Hi Keshava, Kevin,
>>
>> On Fri, Jul 06, 2012 at 05:29:00PM +0530, Munegowda, Keshava wrote:
>>> Samuel
>>>           I have sent that patch to disable the ehci in
>>> omap2plus_defconfig; after merging that
>>> please merge this patch too. This will fix the crashes in during boot
>>> with NFS in beagleXM
>> I'm going to apply and push this patch for 3.5, and the defconfig patch can be
>> pushed through Tony's tree.
>> Kevin, could you please ACK it ?
>>
>> Cheers,
>> Samuel.
>>
>
> Thanks Samuel
>
> Kevin,
>     need your ack for this.

You never answered earlier questions from myself or Russ Dill about the
more targetted patches from Russ:

   ARM: OMAP: USB: Fixup ehci_hcd_omap_probe error path
   Fix OMAP EHCI suspend/resume failure (i693) '354ab856' causes

(Continue reading)

headers

Munegowda, Keshava | 12 Jul 2012 08:41

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

On Wed, Jul 11, 2012 at 7:53 PM, Kevin Hilman <khilman@...> wrote:
> "Munegowda, Keshava" <keshava_mgowda@...> writes:
>
>> On Wed, Jul 11, 2012 at 3:59 PM, Samuel Ortiz <sameo@...> wrote:
>>> Hi Keshava, Kevin,
>>>
>>> On Fri, Jul 06, 2012 at 05:29:00PM +0530, Munegowda, Keshava wrote:
>>>> Samuel
>>>>           I have sent that patch to disable the ehci in
>>>> omap2plus_defconfig; after merging that
>>>> please merge this patch too. This will fix the crashes in during boot
>>>> with NFS in beagleXM
>>> I'm going to apply and push this patch for 3.5, and the defconfig patch can be
>>> pushed through Tony's tree.
>>> Kevin, could you please ACK it ?
>>>
>>> Cheers,
>>> Samuel.
>>>
>>
>> Thanks Samuel
>>
>> Kevin,
>>     need your ack for this.
>
> You never answered earlier questions from myself or Russ Dill about the
> more targetted patches from Russ:
>
>    ARM: OMAP: USB: Fixup ehci_hcd_omap_probe error path
>    Fix OMAP EHCI suspend/resume failure (i693) '354ab856' causes

(Continue reading)

headers

Munegowda, Keshava | 19 Jul 2012 12:17

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

On Thu, Jul 12, 2012 at 12:11 PM, Munegowda, Keshava
<keshava_mgowda@...> wrote:
> On Wed, Jul 11, 2012 at 7:53 PM, Kevin Hilman <khilman@...> wrote:
>> "Munegowda, Keshava" <keshava_mgowda@...> writes:
>>
>>> On Wed, Jul 11, 2012 at 3:59 PM, Samuel Ortiz <sameo@...> wrote:
>>>> Hi Keshava, Kevin,
>>>>
>>>> On Fri, Jul 06, 2012 at 05:29:00PM +0530, Munegowda, Keshava wrote:
>>>>> Samuel
>>>>>           I have sent that patch to disable the ehci in
>>>>> omap2plus_defconfig; after merging that
>>>>> please merge this patch too. This will fix the crashes in during boot
>>>>> with NFS in beagleXM
>>>> I'm going to apply and push this patch for 3.5, and the defconfig patch can be
>>>> pushed through Tony's tree.
>>>> Kevin, could you please ACK it ?
>>>>
>>>> Cheers,
>>>> Samuel.
>>>>
>>>
>>> Thanks Samuel
>>>
>>> Kevin,
>>>     need your ack for this.
>>
>> You never answered earlier questions from myself or Russ Dill about the
>> more targetted patches from Russ:
>>

(Continue reading)

headers

Kevin Hilman | 22 Jun 2012 16:11

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

"Munegowda, Keshava" <keshava_mgowda@...> writes:

[...]

>>>
>>> hi kevin
>>>
>>> here is pm count log on beagle XM with the above patch:
>>
>> What are you meaning to show by this log?
>>
>> This dump shows that neither PER or CORE are hitting retention in idle.
>> Which sounds to me like you have not enabled UART runtime suspend:
>>
>> echo 3000 > /sys/devices/platform/omap_uart.0/power/autosuspend_delay_ms
>> echo 3000 > /sys/devices/platform/omap_uart.1/power/autosuspend_delay_ms
>> echo 3000 > /sys/devices/platform/omap_uart.2/power/autosuspend_delay_ms
>> echo 3000 > /sys/devices/platform/omap_uart.3/power/autosuspend_delay_ms
>>
>> My test with your patch shows that it fixes the oops during boot, and
>> doesn't hang during suspend, but that USB host is still preventing CORE
>> retention during idle (after UART runtime suspend is enabled.)
>>
>> This happens on 3530/Overo, 3630/Beagle-xM and 3730/Overo
>>
>> Setting CONFIG_MFD_OMAP_USB_HOST=n allows CORE to hit retention again.
>>
>> Kevin
>
>

(Continue reading)

headers

Alan Stern | 22 Jun 2012 16:35

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

On Fri, 22 Jun 2012, Kevin Hilman wrote:

> As I said way back in the beginning this thread.  The runtime PM of this
> driver is leaving the device enabled.
> 
> To test idle retention, ensure the UART auto-suspend is enable for all
> UARTS:
> 
> echo 3000 > /sys/devices/platform/omap_uart.0/power/autosuspend_delay_ms
> echo 3000 > /sys/devices/platform/omap_uart.1/power/autosuspend_delay_ms
> echo 3000 > /sys/devices/platform/omap_uart.2/power/autosuspend_delay_ms
> echo 3000 > /sys/devices/platform/omap_uart.3/power/autosuspend_delay_ms
> 
> Then wait > 3 seconds and 'cat /debug/pm_debug/count'.  

This is probably a foolish question, but have you checked that the 
power/control attribute is set to "auto"?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

headers

Munegowda, Keshava | 22 Jun 2012 16:43

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

On Fri, Jun 22, 2012 at 7:41 PM, Kevin Hilman <khilman@...> wrote:
> "Munegowda, Keshava" <keshava_mgowda@...> writes:
>
> [...]
>
>>>>
>>>> hi kevin
>>>>
>>>> here is pm count log on beagle XM with the above patch:
>>>
>>> What are you meaning to show by this log?
>>>
>>> This dump shows that neither PER or CORE are hitting retention in idle.
>>> Which sounds to me like you have not enabled UART runtime suspend:
>>>
>>> echo 3000 > /sys/devices/platform/omap_uart.0/power/autosuspend_delay_ms
>>> echo 3000 > /sys/devices/platform/omap_uart.1/power/autosuspend_delay_ms
>>> echo 3000 > /sys/devices/platform/omap_uart.2/power/autosuspend_delay_ms
>>> echo 3000 > /sys/devices/platform/omap_uart.3/power/autosuspend_delay_ms
>>>
>>> My test with your patch shows that it fixes the oops during boot, and
>>> doesn't hang during suspend, but that USB host is still preventing CORE
>>> retention during idle (after UART runtime suspend is enabled.)
>>>
>>> This happens on 3530/Overo, 3630/Beagle-xM and 3730/Overo
>>>
>>> Setting CONFIG_MFD_OMAP_USB_HOST=n allows CORE to hit retention again.
>>>
>>> Kevin
>>

(Continue reading)

headers

Kevin Hilman | 22 Jun 2012 20:49

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

"Munegowda, Keshava" <keshava_mgowda <at> ti.com> writes:

> On Fri, Jun 22, 2012 at 7:41 PM, Kevin Hilman <khilman <at> ti.com> wrote:
>> "Munegowda, Keshava" <keshava_mgowda <at> ti.com> writes:
>>
>> [...]
>>
>>>>>
>>>>> hi kevin
>>>>>
>>>>> here is pm count log on beagle XM with the above patch:
>>>>
>>>> What are you meaning to show by this log?
>>>>
>>>> This dump shows that neither PER or CORE are hitting retention in idle.
>>>> Which sounds to me like you have not enabled UART runtime suspend:
>>>>
>>>> echo 3000 > /sys/devices/platform/omap_uart.0/power/autosuspend_delay_ms
>>>> echo 3000 > /sys/devices/platform/omap_uart.1/power/autosuspend_delay_ms
>>>> echo 3000 > /sys/devices/platform/omap_uart.2/power/autosuspend_delay_ms
>>>> echo 3000 > /sys/devices/platform/omap_uart.3/power/autosuspend_delay_ms
>>>>
>>>> My test with your patch shows that it fixes the oops during boot, and
>>>> doesn't hang during suspend, but that USB host is still preventing CORE
>>>> retention during idle (after UART runtime suspend is enabled.)
>>>>
>>>> This happens on 3530/Overo, 3630/Beagle-xM and 3730/Overo
>>>>
>>>> Setting CONFIG_MFD_OMAP_USB_HOST=n allows CORE to hit retention again.
>>>>

(Continue reading)

headers

Roger Quadros | 23 Jul 2012 10:33

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

Hi,

On 06/22/2012 05:43 PM, Munegowda, Keshava wrote:
> On Fri, Jun 22, 2012 at 7:41 PM, Kevin Hilman <khilman <at> ti.com> wrote:
>> "Munegowda, Keshava" <keshava_mgowda <at> ti.com> writes:
>>
>> [...]
>>

>>
>> You are not reading what I write.
>>
>> To repeat: your patch fixes the oops during boot, and the suspend hang
>> and now I see CORE hit retention in *suspend*.
> 
> thanks !
> 
>>
>> However,  CORE does still not hit retention during *idle*.
> 
> here is the problem.
> 
> usb host retention in idle is not supported till now.
> in current code, usb host cuts clock only in driver suspend not in bus
> suspend ( auto suspend).
> usb host driver need to use the  io daisy chain framework through io wakeup.
> I will post the patches once ehci remote wakeup features stabilized in
> omap3, omap4 and omap5 too.
>

(Continue reading)

headers

Munegowda, Keshava | 23 Jul 2012 13:27

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

On Mon, Jul 23, 2012 at 2:03 PM, Roger Quadros <rogerq@...> wrote:
> Hi,
>
> On 06/22/2012 05:43 PM, Munegowda, Keshava wrote:
>> On Fri, Jun 22, 2012 at 7:41 PM, Kevin Hilman <khilman@...> wrote:
>>> "Munegowda, Keshava" <keshava_mgowda@...> writes:
>>>
>>> [...]
>>>
>
>>>
>>> You are not reading what I write.
>>>
>>> To repeat: your patch fixes the oops during boot, and the suspend hang
>>> and now I see CORE hit retention in *suspend*.
>>
>> thanks !
>>
>>>
>>> However,  CORE does still not hit retention during *idle*.
>>
>> here is the problem.
>>
>> usb host retention in idle is not supported till now.
>> in current code, usb host cuts clock only in driver suspend not in bus
>> suspend ( auto suspend).
>> usb host driver need to use the  io daisy chain framework through io wakeup.
>> I will post the patches once ehci remote wakeup features stabilized in
>> omap3, omap4 and omap5 too.
>>

(Continue reading)

headers

wrona | 30 Aug 2012 16:49

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

Munegowda, Keshava <keshava_mgowda <at> ...> writes:

> >> usb host retention in idle is not supported till now.
> 
> when we see the usb bus suspend, then we disable the clocks of usb host to
> enable to enable the retention in cpu idle; since we have disabled the clock of
> usb host , we will not see the device connection at the controller
> level, instead
> the irq chain handler can detect it and corresponding irq can set the clocks.
> this  same use case holds good for device OFF too.
> 

Hi,

May I ask - when 'usb host retention in idle' will be supported
for omap3/4?

Regards,
Wrona 

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html

headers

Munegowda, Keshava | 10 Sep 2012 12:48

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

On Thu, Aug 30, 2012 at 8:19 PM, wrona <wrona.vy@...> wrote:
> Munegowda, Keshava <keshava_mgowda <at> ...> writes:
>
>> >> usb host retention in idle is not supported till now.
>>
>> when we see the usb bus suspend, then we disable the clocks of usb host to
>> enable to enable the retention in cpu idle; since we have disabled the clock of
>> usb host , we will not see the device connection at the controller
>> level, instead
>> the irq chain handler can detect it and corresponding irq can set the clocks.
>> this  same use case holds good for device OFF too.
>>
>
> Hi,
>
> May I ask - when 'usb host retention in idle' will be supported
> for omap3/4?

I am working on it; at least 3 months from now.

regards
keshava
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html

headers

Felipe Balbi | 19 Jul 2012 12:20

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

Hi,

On Thu, Jun 21, 2012 at 07:12:12PM +0530, Keshava Munegowda wrote:
> This commit 354ab8567ae3107a8cbe7228c3181990ba598aac titled
> "Fix OMAP EHCI suspend/resume failure (i693)" is causing
> the usb hub and device detection fails in beagle XM
> causeing NFS not functional. This affects the core retention too.
> The same commit logic needs to be revisted adhering to hwmod and
> device tree framework.
> for now, this commit id 354ab8567ae3107a8cbe7228c3181990ba598aac
> titled "Fix OMAP EHCI suspend/resume failure (i693)" reverted.
> 
> This patch is validated on BeagleXM with NFS support over
> usb ethernet and USB mass storage and other device detection.
> 
> Signed-off-by: Keshava Munegowda <keshava_mgowda <at> ti.com>

Acked-by: Felipe Balbi <balbi <at> ti.com>

turns out this is causing other issues and another version of the patch
will be provided.

Greg, Alan, this is basically a git revert of the commit id listed
above.

--

-- 
balbi

headers

Munegowda, Keshava | 19 Jul 2012 14:02

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

On Thu, Jul 19, 2012 at 3:50 PM, Felipe Balbi <balbi@...> wrote:
> Hi,
>
> On Thu, Jun 21, 2012 at 07:12:12PM +0530, Keshava Munegowda wrote:
>> This commit 354ab8567ae3107a8cbe7228c3181990ba598aac titled
>> "Fix OMAP EHCI suspend/resume failure (i693)" is causing
>> the usb hub and device detection fails in beagle XM
>> causeing NFS not functional. This affects the core retention too.
>> The same commit logic needs to be revisted adhering to hwmod and
>> device tree framework.
>> for now, this commit id 354ab8567ae3107a8cbe7228c3181990ba598aac
>> titled "Fix OMAP EHCI suspend/resume failure (i693)" reverted.
>>
>> This patch is validated on BeagleXM with NFS support over
>> usb ethernet and USB mass storage and other device detection.
>>
>> Signed-off-by: Keshava Munegowda <keshava_mgowda@...>
>
> Acked-by: Felipe Balbi <balbi@...>
>
> turns out this is causing other issues and another version of the patch
> will be provided.
>
> Greg, Alan, this is basically a git revert of the commit id listed
> above.
>
> --
> balbi

Thanks Felipe

(Continue reading)

headers

Alan Stern | 19 Jul 2012 17:15

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

On Thu, 19 Jul 2012, Felipe Balbi wrote:

> Hi,
> 
> On Thu, Jun 21, 2012 at 07:12:12PM +0530, Keshava Munegowda wrote:
> > This commit 354ab8567ae3107a8cbe7228c3181990ba598aac titled
> > "Fix OMAP EHCI suspend/resume failure (i693)" is causing
> > the usb hub and device detection fails in beagle XM
> > causeing NFS not functional. This affects the core retention too.
> > The same commit logic needs to be revisted adhering to hwmod and
> > device tree framework.
> > for now, this commit id 354ab8567ae3107a8cbe7228c3181990ba598aac
> > titled "Fix OMAP EHCI suspend/resume failure (i693)" reverted.
> > 
> > This patch is validated on BeagleXM with NFS support over
> > usb ethernet and USB mass storage and other device detection.
> > 
> > Signed-off-by: Keshava Munegowda <keshava_mgowda <at> ti.com>
> 
> Acked-by: Felipe Balbi <balbi <at> ti.com>
> 
> turns out this is causing other issues and another version of the patch
> will be provided.
> 
> Greg, Alan, this is basically a git revert of the commit id listed
> above.

I have no objection to reverting the patch.  But on a related note,
have you had a chance to read my comment:

(Continue reading)

headers

Greg KH | 20 Jul 2012 00:54

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

On Thu, Jul 19, 2012 at 01:20:14PM +0300, Felipe Balbi wrote:
> Hi,
> 
> On Thu, Jun 21, 2012 at 07:12:12PM +0530, Keshava Munegowda wrote:
> > This commit 354ab8567ae3107a8cbe7228c3181990ba598aac titled
> > "Fix OMAP EHCI suspend/resume failure (i693)" is causing
> > the usb hub and device detection fails in beagle XM
> > causeing NFS not functional. This affects the core retention too.
> > The same commit logic needs to be revisted adhering to hwmod and
> > device tree framework.
> > for now, this commit id 354ab8567ae3107a8cbe7228c3181990ba598aac
> > titled "Fix OMAP EHCI suspend/resume failure (i693)" reverted.
> > 
> > This patch is validated on BeagleXM with NFS support over
> > usb ethernet and USB mass storage and other device detection.
> > 
> > Signed-off-by: Keshava Munegowda <keshava_mgowda@...>
> 
> Acked-by: Felipe Balbi <balbi@...>
> 
> turns out this is causing other issues and another version of the patch
> will be provided.
> 
> Greg, Alan, this is basically a git revert of the commit id listed
> above.

Ok, I'll queue it up for 3.6-rc1 and add a -stable mark to it to get
into 3.5.1, ok?

thanks,

(Continue reading)

headers

Greg KH | 20 Jul 2012 00:55

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

On Thu, Jul 19, 2012 at 03:54:05PM -0700, Greg KH wrote:
> On Thu, Jul 19, 2012 at 01:20:14PM +0300, Felipe Balbi wrote:
> > Hi,
> > 
> > On Thu, Jun 21, 2012 at 07:12:12PM +0530, Keshava Munegowda wrote:
> > > This commit 354ab8567ae3107a8cbe7228c3181990ba598aac titled
> > > "Fix OMAP EHCI suspend/resume failure (i693)" is causing
> > > the usb hub and device detection fails in beagle XM
> > > causeing NFS not functional. This affects the core retention too.
> > > The same commit logic needs to be revisted adhering to hwmod and
> > > device tree framework.
> > > for now, this commit id 354ab8567ae3107a8cbe7228c3181990ba598aac
> > > titled "Fix OMAP EHCI suspend/resume failure (i693)" reverted.
> > > 
> > > This patch is validated on BeagleXM with NFS support over
> > > usb ethernet and USB mass storage and other device detection.
> > > 
> > > Signed-off-by: Keshava Munegowda <keshava_mgowda@...>
> > 
> > Acked-by: Felipe Balbi <balbi@...>
> > 
> > turns out this is causing other issues and another version of the patch
> > will be provided.
> > 
> > Greg, Alan, this is basically a git revert of the commit id listed
> > above.
> 
> Ok, I'll queue it up for 3.6-rc1 and add a -stable mark to it to get
> into 3.5.1, ok?

(Continue reading)

headers

Munegowda, Keshava | 20 Jul 2012 10:06

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

On Fri, Jul 20, 2012 at 4:25 AM, Greg KH <gregkh@...> wrote:
> On Thu, Jul 19, 2012 at 03:54:05PM -0700, Greg KH wrote:
>> On Thu, Jul 19, 2012 at 01:20:14PM +0300, Felipe Balbi wrote:
>> > Hi,
>> >
>> > On Thu, Jun 21, 2012 at 07:12:12PM +0530, Keshava Munegowda wrote:
>> > > This commit 354ab8567ae3107a8cbe7228c3181990ba598aac titled
>> > > "Fix OMAP EHCI suspend/resume failure (i693)" is causing
>> > > the usb hub and device detection fails in beagle XM
>> > > causeing NFS not functional. This affects the core retention too.
>> > > The same commit logic needs to be revisted adhering to hwmod and
>> > > device tree framework.
>> > > for now, this commit id 354ab8567ae3107a8cbe7228c3181990ba598aac
>> > > titled "Fix OMAP EHCI suspend/resume failure (i693)" reverted.
>> > >
>> > > This patch is validated on BeagleXM with NFS support over
>> > > usb ethernet and USB mass storage and other device detection.
>> > >
>> > > Signed-off-by: Keshava Munegowda <keshava_mgowda@...>
>> >
>> > Acked-by: Felipe Balbi <balbi@...>
>> >
>> > turns out this is causing other issues and another version of the patch
>> > will be provided.
>> >
>> > Greg, Alan, this is basically a git revert of the commit id listed
>> > above.
>>
>> Ok, I'll queue it up for 3.6-rc1 and add a -stable mark to it to get
>> into 3.5.1, ok?

(Continue reading)