headers
Alan Stern | 21 Jun 2012 19:25
Picon
Favicon

Intel Moorestown EHCI and the HOSTPCx registers

Alek and Jacob added support for the Intel Moorestown EHCI controller,
with its special HOSTPCx registers, way back in 2009 (commit
331ac6b288d9f3689514ced1878041fb0df7e13c).  That support included a new
flag, ehci->has_hostpc, which gets tested in lots of places.

But it never gets set anywhere!  All that material is dead code.

Was it ever tested?  Should it be removed?  Or should something be
added?

What's the story here?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply |
headers
Pan, Jacob jun | 21 Jun 2012 23:21
Picon
Favicon

RE: Intel Moorestown EHCI and the HOSTPCx registers


> -----Original Message-----
> From: Alan Stern [mailto:stern@...]
> Sent: Thursday, June 21, 2012 10:25 AM
> To: Du, Alek; Pan, Jacob jun; Brown, Len
> Cc: USB list
> Subject: Intel Moorestown EHCI and the HOSTPCx registers
> 
> Alek and Jacob added support for the Intel Moorestown EHCI controller, with
> its special HOSTPCx registers, way back in 2009 (commit
> 331ac6b288d9f3689514ced1878041fb0df7e13c).  That support included a new
> flag, ehci->has_hostpc, which gets tested in lots of places.
> 
> But it never gets set anywhere!  All that material is dead code.
> 
> Was it ever tested?  Should it be removed?  Or should something be added?
> 
> What's the story here?
> 
CC Hao, I am no longer working on this. The registers are valid.
> Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply |
headers
Greg KH | 22 Jun 2012 00:50
Favicon
Gravatar

Re: Intel Moorestown EHCI and the HOSTPCx registers

On Thu, Jun 21, 2012 at 09:21:44PM +0000, Pan, Jacob jun wrote:
> 
> 
> > -----Original Message-----
> > From: Alan Stern [mailto:stern@...]
> > Sent: Thursday, June 21, 2012 10:25 AM
> > To: Du, Alek; Pan, Jacob jun; Brown, Len
> > Cc: USB list
> > Subject: Intel Moorestown EHCI and the HOSTPCx registers
> > 
> > Alek and Jacob added support for the Intel Moorestown EHCI controller, with
> > its special HOSTPCx registers, way back in 2009 (commit
> > 331ac6b288d9f3689514ced1878041fb0df7e13c).  That support included a new
> > flag, ehci->has_hostpc, which gets tested in lots of places.
> > 
> > But it never gets set anywhere!  All that material is dead code.
> > 
> > Was it ever tested?  Should it be removed?  Or should something be added?
> > 
> > What's the story here?
> > 
> CC Hao, I am no longer working on this. The registers are valid.

Really?  I thought Moorestown support was removed from the kernel a
while ago, shouldn't this also be cleaned up and removed?

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@...
(Continue reading)

Permalink | Reply |
headers
Pan, Jacob jun | 22 Jun 2012 04:39
Picon
Favicon

RE: Intel Moorestown EHCI and the HOSTPCx registers


> -----Original Message-----
> From: Greg KH [mailto:gregkh@...]
> Sent: Thursday, June 21, 2012 3:51 PM
> To: Pan, Jacob jun
> Cc: Alan Stern; Du, Alek; Brown, Len; USB list; Wu, Hao
> Subject: Re: Intel Moorestown EHCI and the HOSTPCx registers
> 
> On Thu, Jun 21, 2012 at 09:21:44PM +0000, Pan, Jacob jun wrote:
> >
> >
> > > -----Original Message-----
> > > From: Alan Stern [mailto:stern@...]
> > > Sent: Thursday, June 21, 2012 10:25 AM
> > > To: Du, Alek; Pan, Jacob jun; Brown, Len
> > > Cc: USB list
> > > Subject: Intel Moorestown EHCI and the HOSTPCx registers
> > >
> > > Alek and Jacob added support for the Intel Moorestown EHCI
> > > controller, with its special HOSTPCx registers, way back in 2009
> > > (commit 331ac6b288d9f3689514ced1878041fb0df7e13c).  That support
> > > included a new flag, ehci->has_hostpc, which gets tested in lots of places.
> > >
> > > But it never gets set anywhere!  All that material is dead code.
> > >
> > > Was it ever tested?  Should it be removed?  Or should something be
> added?
> > >
> > > What's the story here?
> > >
(Continue reading)

Permalink | Reply |
headers
Greg KH | 22 Jun 2012 15:13
Favicon
Gravatar

Re: Intel Moorestown EHCI and the HOSTPCx registers

On Fri, Jun 22, 2012 at 02:39:19AM +0000, Pan, Jacob jun wrote:
> 
> 
> > -----Original Message-----
> > From: Greg KH [mailto:gregkh@...]
> > Sent: Thursday, June 21, 2012 3:51 PM
> > To: Pan, Jacob jun
> > Cc: Alan Stern; Du, Alek; Brown, Len; USB list; Wu, Hao
> > Subject: Re: Intel Moorestown EHCI and the HOSTPCx registers
> > 
> > On Thu, Jun 21, 2012 at 09:21:44PM +0000, Pan, Jacob jun wrote:
> > >
> > >
> > > > -----Original Message-----
> > > > From: Alan Stern [mailto:stern@...]
> > > > Sent: Thursday, June 21, 2012 10:25 AM
> > > > To: Du, Alek; Pan, Jacob jun; Brown, Len
> > > > Cc: USB list
> > > > Subject: Intel Moorestown EHCI and the HOSTPCx registers
> > > >
> > > > Alek and Jacob added support for the Intel Moorestown EHCI
> > > > controller, with its special HOSTPCx registers, way back in 2009
> > > > (commit 331ac6b288d9f3689514ced1878041fb0df7e13c).  That support
> > > > included a new flag, ehci->has_hostpc, which gets tested in lots of places.
> > > >
> > > > But it never gets set anywhere!  All that material is dead code.
> > > >
> > > > Was it ever tested?  Should it be removed?  Or should something be
> > added?
> > > >
(Continue reading)

Permalink | Reply |
headers
Matthieu CASTET | 22 Jun 2012 18:06
Favicon

Re: Intel Moorestown EHCI and the HOSTPCx registers

Greg KH a écrit :
> On Fri, Jun 22, 2012 at 02:39:19AM +0000, Pan, Jacob jun wrote:
>>
>>> -----Original Message-----
>>> From: Greg KH [mailto:gregkh@...]
>>> Sent: Thursday, June 21, 2012 3:51 PM
>>> To: Pan, Jacob jun
>>> Cc: Alan Stern; Du, Alek; Brown, Len; USB list; Wu, Hao
>>> Subject: Re: Intel Moorestown EHCI and the HOSTPCx registers
>>>
>>> On Thu, Jun 21, 2012 at 09:21:44PM +0000, Pan, Jacob jun wrote:
>>>>
>>>>> -----Original Message-----
>>>>> From: Alan Stern [mailto:stern@...]
>>>>> Sent: Thursday, June 21, 2012 10:25 AM
>>>>> To: Du, Alek; Pan, Jacob jun; Brown, Len
>>>>> Cc: USB list
>>>>> Subject: Intel Moorestown EHCI and the HOSTPCx registers
>>>>>
>>>>> Alek and Jacob added support for the Intel Moorestown EHCI
>>>>> controller, with its special HOSTPCx registers, way back in 2009
>>>>> (commit 331ac6b288d9f3689514ced1878041fb0df7e13c).  That support
>>>>> included a new flag, ehci->has_hostpc, which gets tested in lots of places.
>>>>>
>>>>> But it never gets set anywhere!  All that material is dead code.
>>>>>
>>>>> Was it ever tested?  Should it be removed?  Or should something be
>>> added?
>>>>> What's the story here?
>>>>>
(Continue reading)

Permalink | Reply |
headers
Alexander Shishkin | 25 Jun 2012 13:25
Picon

Re: Intel Moorestown EHCI and the HOSTPCx registers

Matthieu CASTET <matthieu.castet@...> writes:

> Greg KH a écrit :
>> On Fri, Jun 22, 2012 at 02:39:19AM +0000, Pan, Jacob jun wrote:
>>>
>>>> -----Original Message-----
>>>> From: Greg KH [mailto:gregkh@...]
>>>> Sent: Thursday, June 21, 2012 3:51 PM
>>>> To: Pan, Jacob jun
>>>> Cc: Alan Stern; Du, Alek; Brown, Len; USB list; Wu, Hao
>>>> Subject: Re: Intel Moorestown EHCI and the HOSTPCx registers
>>>>
>>>> On Thu, Jun 21, 2012 at 09:21:44PM +0000, Pan, Jacob jun wrote:
>>>>>
>>>>>> -----Original Message-----
>>>>>> From: Alan Stern [mailto:stern@...]
>>>>>> Sent: Thursday, June 21, 2012 10:25 AM
>>>>>> To: Du, Alek; Pan, Jacob jun; Brown, Len
>>>>>> Cc: USB list
>>>>>> Subject: Intel Moorestown EHCI and the HOSTPCx registers
>>>>>>
>>>>>> Alek and Jacob added support for the Intel Moorestown EHCI
>>>>>> controller, with its special HOSTPCx registers, way back in 2009
>>>>>> (commit 331ac6b288d9f3689514ced1878041fb0df7e13c).  That support
>>>>>> included a new flag, ehci->has_hostpc, which gets tested in lots of places.
>>>>>>
>>>>>> But it never gets set anywhere!  All that material is dead code.
>>>>>>
>>>>>> Was it ever tested?  Should it be removed?  Or should something be
>>>> added?
(Continue reading)

Permalink | Reply |
headers
Alan Stern | 25 Jun 2012 16:47
Picon
Favicon

Re: Intel Moorestown EHCI and the HOSTPCx registers

On Mon, 25 Jun 2012, Alexander Shishkin wrote:

> Well, chipidea is setting has_hostpc and will break if it gets
> removed. Also, host support in medfield depends on this (medfield usb
> controller is driven by chipidea driver). It is true that before the
> chipidea driver update in v3.5-rc1 nothing was actually setting hostpc,
> but it's not the case any more.

Argh!!!  I just saw this for the first time in 
drivers/usb/chipidea:host.c:

	#define CHIPIDEA_EHCI
	#include "../host/ehci-hcd.c"

Here I've been thinking all along that the various EHCI platform 
drivers were all located in drivers/usb/host and all had names 
beginning with "ehci".

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Permalink | Reply |

Gmane