Linux USB development and users ()

Pratyush Anand | 22 Jun 2012 13:34

[PATCH] USB: DWC3: Remove WARN_ON from dwc_stop_active_transfer

Now we are sure that, if res_trans_idx is zero, then endpoint has been
stopped.So, Its safe to just return, if endpoint is already stopped. No
need to generate warning now.

Signed-off-by: Pratyush Anand <pratyush.anand@...>
---
 drivers/usb/dwc3/gadget.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 3f555f0..1b29b6a 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
 <at>  <at>  -1905,7 +1905,6  <at>  <at>  static void dwc3_stop_active_transfer(struct dwc3 *dwc, u32 epnum)

 	dep = dwc->eps[epnum];

-	WARN_ON(!dep->res_trans_idx);
 	if (dep->res_trans_idx) {
 		cmd = DWC3_DEPCMD_ENDTRANSFER;
 		cmd |= DWC3_DEPCMD_HIPRI_FORCERM | DWC3_DEPCMD_CMDIOC;
--

-- 
1.7.5.4

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@...
More majordomo info at  http://vger.kernel.org/majordomo-info.html

(Continue reading)

headers

Felipe Balbi | 22 Jun 2012 22:34

Re: [PATCH] USB: DWC3: Remove WARN_ON from dwc_stop_active_transfer

Hi,

On Fri, Jun 22, 2012 at 05:04:24PM +0530, Pratyush Anand wrote:
> Now we are sure that, if res_trans_idx is zero, then endpoint has been
> stopped.So, Its safe to just return, if endpoint is already stopped. No
> need to generate warning now.
> 
> Signed-off-by: Pratyush Anand <pratyush.anand@...>
> ---
>  drivers/usb/dwc3/gadget.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
> index 3f555f0..1b29b6a 100644
> --- a/drivers/usb/dwc3/gadget.c
> +++ b/drivers/usb/dwc3/gadget.c
>  <at>  <at>  -1905,7 +1905,6  <at>  <at>  static void dwc3_stop_active_transfer(struct dwc3 *dwc, u32 epnum)
>  
>  	dep = dwc->eps[epnum];
>  
> -	WARN_ON(!dep->res_trans_idx);
>  	if (dep->res_trans_idx) {

just one small comment:

while doing that, can you decrease the indentation too by returning
early if res_trans_idx is zero. What is to add:

if (!dep->res_trans_idx)
	return;

(Continue reading)