Re: disk APM

This passes basic testing for me, does what I'd expect it to do.

On Wed, Feb 8, 2012 at 4:05 PM, Marcus Sorensen <shadowsor <at> gmail.com> wrote:
> cool, will do
>
> On Wed, Feb 8, 2012 at 2:25 PM, Christian Franke
> <Christian.Franke <at> t-online.de> wrote:
>> Christian Franke wrote:
>>>
>>> Marcus Sorensen wrote:
>>>>
>>>> Ok, here's my patch. It applies against the stable 5.42 from
>>>> sourceforge (as that's what we want to roll out).
>>>
>>>
>>> Thanks
>>>
>>>
>>>> One thing I noticed while changing it over to -l was that scterc is
>>>> using it's own function 'ataGetSetSCTErrorRecoveryControltime' to set
>>>> SCT values, whereas I just added the necessary commands to allow me to
>>>> use the existing 'smartcommandhandler'. I'm not sure if one method is
>>>> necessarily preferred over the other, but I imagine someone will want
>>>> to be consistent, and I'm not really excited to change what I've
>>>> already got.
>>>
>>>
>>> smartcommandhandler() is actually legacy code from the old interface which
>>> only supports ATA commands from smart_command_set. The enum is still used by
>>> the os_*.cpp parts which are not migrated to new interface. New code should