Magnus Holmgren | 4 Dec 2006 19:16
Picon
Picon
Picon
Favicon

Re: $recipients not available in local_scan()

On Monday 04 December 2006 13:13, Philip Hazel wrote:
> On Sun, 3 Dec 2006, Magnus Holmgren wrote:
> > Why isn't enable_dollar_recipients set to TRUE during local_scan()?
>
> Because nobody ever asked, I guess. :-)

What about the LOCAL_SCAN_ABI_VERSION* defines, then?

As I wrote on Debian's bugtracker, I think I can say this: 
LOCAL_SCAN_ABI_VERSION_MINOR should have been incremented some time ago, but 
since nothing actually has depended on it, incrementing it now should work.

-- 
Magnus Holmgren        holmgren <at> lysator.liu.se
                       (No Cc of list mail needed, thanks)

  "Exim is better at being younger, whereas sendmail is better for 
   Scrabble (50 point bonus for clearing your rack)" -- Dave Evans
--

-- 
Philip Hazel | 5 Dec 2006 10:23
Picon
Picon

Re: $recipients not available in local_scan()

On Mon, 4 Dec 2006, Magnus Holmgren wrote:

> What about the LOCAL_SCAN_ABI_VERSION* defines, then?

The comment in the code where that is defined says:

  /* Some people (Marc Merlin et al) are maintaining a patch that allows
  for dynamic local_scan() libraries. This code is not yet in Exim
  proper, but it helps the maintainers if we keep their ABI version
  numbers here....

Note: *their* ABI version numbers. I presume if they wanted them
changed, they would ask.

-- 
Philip Hazel            University of Cambridge Computing Service
Get the Exim 4 book:    http://www.uit.co.uk/exim-book

--

-- 
Magnus Holmgren | 5 Dec 2006 20:33
Picon
Picon
Picon
Favicon

Re: $recipients not available in local_scan()

On Tuesday 05 December 2006 10:23, Philip Hazel wrote:
> On Mon, 4 Dec 2006, Magnus Holmgren wrote:
> > What about the LOCAL_SCAN_ABI_VERSION* defines, then?
>
> The comment in the code where that is defined says:
>
>   /* Some people (Marc Merlin et al) are maintaining a patch that allows
>   for dynamic local_scan() libraries. This code is not yet in Exim
>   proper, but it helps the maintainers if we keep their ABI version
>   numbers here....
>
> Note: *their* ABI version numbers. I presume if they wanted them
> changed, they would ask.

Yes... Marc admitted that he could have kept a closer eye on this. Anyway, as 
the Debian maintainer of SA-Exim, I hereby ask you to bump up the minor 
version (I can do it myself too).

Isn't it time to accept the patch into mainstream Exim? Without making it the 
default, of course. And without removing the long comment from local_scan.c 
about how to write a local_scan() function.

--

-- 
Magnus Holmgren        holmgren <at> lysator.liu.se
                       (No Cc of list mail needed, thanks)

  "Exim is better at being younger, whereas sendmail is better for 
   Scrabble (50 point bonus for clearing your rack)" -- Dave Evans
(Continue reading)

Philip Hazel | 6 Dec 2006 10:18
Picon
Picon

Re: $recipients not available in local_scan()

On Tue, 5 Dec 2006, Magnus Holmgren wrote:

> Yes... Marc admitted that he could have kept a closer eye on this. Anyway, as 
> the Debian maintainer of SA-Exim, I hereby ask you to bump up the minor 
> version (I can do it myself too).

Go ahead and do it yourself quickly, then it will be in 4.64. Remember 
to update Changelog.

> Isn't it time to accept the patch into mainstream Exim? Without making it the 
> default, of course. And without removing the long comment from local_scan.c 
> about how to write a local_scan() function.

I don't think anyone has actually asked for that before, or sent me the 
patch, but I may be mis-remembering.

-- 
Philip Hazel            University of Cambridge Computing Service
Get the Exim 4 book:    http://www.uit.co.uk/exim-book

--

-- 
Magnus Holmgren | 6 Dec 2006 11:27
Picon
Picon
Picon
Favicon

Re: $recipients not available in local_scan()

On Wednesday 06 December 2006 10:18, Philip Hazel wrote:
> On Tue, 5 Dec 2006, Magnus Holmgren wrote:
> > Yes... Marc admitted that he could have kept a closer eye on this.
> > Anyway, as the Debian maintainer of SA-Exim, I hereby ask you to bump up
> > the minor version (I can do it myself too).
>
> Go ahead and do it yourself quickly, then it will be in 4.64. Remember
> to update Changelog.

Done.

> > Isn't it time to accept the patch into mainstream Exim? Without making it
> > the default, of course. And without removing the long comment from
> > local_scan.c about how to write a local_scan() function.
>
> I don't think anyone has actually asked for that before, or sent me the
> patch, but I may be mis-remembering.

It's been in the wishlist for quite some time. Doesn't that imply that a 
request for it to be included some time has been made? The patch itself is at

http://marc.merlins.org/linux/exim/files/sa-exim-current/localscan_dlopen_exim_4.20_or_better.patch 
and the patch used by Debian is identical except that it doesn't add -ldl to 
LFLAGS.

--

-- 
Magnus Holmgren        holmgren <at> lysator.liu.se
                       (No Cc of list mail needed, thanks)

  "Exim is better at being younger, whereas sendmail is better for 
(Continue reading)

Philip Hazel | 6 Dec 2006 12:27
Picon
Picon

Re: $recipients not available in local_scan()

On Wed, 6 Dec 2006, Magnus Holmgren wrote:

> It's been in the wishlist for quite some time. Doesn't that imply that a 
> request for it to be included some time has been made? 

Oh, sorry, my mistake. Yes, of course you are right. I haven't looked at 
the wish list for some time because other things have kept cropping up. 
(And I've been doing a lot of work on PCRE.) Once 4.64 is released it is
my intention to learn how to use Bugzilla properly and to take a look at
the wish list. But don't hold your breath as to what I may get around to
implementing.

-- 
Philip Hazel            University of Cambridge Computing Service
Get the Exim 4 book:    http://www.uit.co.uk/exim-book

--

-- 

Gmane