Majordomo developer discussion

Luis Michelena | 6 Nov 2002 21:12

Reg. Exp in address matching


Reading in Majordomo help (on the list's owner doc) found that using regexp 
was posible for some matchings, but when I tried to put a rule to let 
everybody in a domain post to a list, it didn't work, then i found reading 
the majordomo.pl file, on line 188 (in the definition of addr_match) the line 
that follows:
return($a1[0] eq $a2[0]);

so it doesn't let use regexp in address matching, I was thinking that colud 
be better to use:
return($a1[0] =~ /^$a2[0]$/);

Have made some test, and it seems to work fine, but I would like to know if 
there is some problem in changing this (like security fouls or mal function 
in some rare cases)
These test were made in majordomo-1.94.5.
Thank you for reading this lines, and please forgive my lousy english but is 
not my mother tongue.
greetings,
          Luis Michelena
          Postmaster
          Facultad de Medicina
          Universidad de la Republica
          Uruguay

headers

Joe R. Jah | 6 Nov 2002 22:10

Re: Reg. Exp in address matching

On Wed, 6 Nov 2002, Luis Michelena wrote:

> Date: Wed, 6 Nov 2002 17:12:49 -0300
> From: Luis Michelena <uylug <at> fmed.edu.uy>
> To: majordomo-workers <at> greatcircle.com
> Subject: Reg. Exp in address matching
>
>
> Reading in Majordomo help (on the list's owner doc) found that using regexp
> was posible for some matchings, but when I tried to put a rule to let
> everybody in a domain post to a list, it didn't work, then i found reading
> the majordomo.pl file, on line 188 (in the definition of addr_match) the line
> that follows:
> return($a1[0] eq $a2[0]);
>
> so it doesn't let use regexp in address matching, I was thinking that colud
> be better to use:
> return($a1[0] =~ /^$a2[0]$/);
>
> Have made some test, and it seems to work fine, but I would like to know if
> there is some problem in changing this (like security fouls or mal function
> in some rare cases)
> These test were made in majordomo-1.94.5.
> Thank you for reading this lines, and please forgive my lousy english but is
> not my mother tongue.

You may want to use this patch:

 ftp://ftp.ccsf.org/majordomo-patches/1.94.5/restrict2domain.0

(Continue reading)

headers

Luis Michelena | 8 Nov 2002 01:08

Re: Reg. Exp in address matching


Thanks, it seems what i need right now, but would like to now if the change I 
proposed would had worked also, because it seems a pretty minimalist change 
(that it seems to be covered by the help already, at least on the 
list-owner-info file, am I wrong?, it doesn't says it explicitly, but let the 
user understand it (I mean, it made me understand that)), and would help to 
get other things done, like letting people with the 'michel' text on the user 
side of the address (that would be my relatives ;) ).
    The patch you propossed works well with the munge domain option?
Regards,
        Luis Michelena

El Mié 06 Nov 2002 18:10, Joe R. Jah escribió:
> On Wed, 6 Nov 2002, Luis Michelena wrote:
> > Date: Wed, 6 Nov 2002 17:12:49 -0300
> > From: Luis Michelena <uylug <at> fmed.edu.uy>
> > To: majordomo-workers <at> greatcircle.com
> > Subject: Reg. Exp in address matching
> >
> >
> > Reading in Majordomo help (on the list's owner doc) found that using
> > regexp was posible for some matchings, but when I tried to put a rule to
> > let everybody in a domain post to a list, it didn't work, then i found
> > reading the majordomo.pl file, on line 188 (in the definition of
> > addr_match) the line that follows:
> > return($a1[0] eq $a2[0]);
> >
> > so it doesn't let use regexp in address matching, I was thinking that
> > colud be better to use:
> > return($a1[0] =~ /^$a2[0]$/);

(Continue reading)