P Kapat | 17 Aug 00:21

trash folder in 1.5.18

Hi,

I recently compiled the 1.5.18 version on a RedHat EL5 machine with
the sidebar patch from here:
http://www.lunar-linux.org/index.php?option=com_content&task=view&id=44

I used the following to configure:
./configure --prefix=$HOME/usr/local --enable-pop --enable-imap
--enable-smtp --enable-locales-fix --enable-nfs-fix --with-ssl
--with-sasl --enable-hcache

But I am not able to use the trash folder option:
set trash="......"
I get the following error: "trash: unknown variable"

The trash folder patch from
http://cedricduval.free.fr/mutt/patches/#trash  is only upto the mutt
version 1.5.5.1; there are no patches after that. I am guessing that
it has been included in the original code. I have used the trash
folder option in 1.5.17 (the binary version included with Ubuntu
Hardy). Any help?

--

-- 
Regards
PK
--------------------------------------
http://counter.li.org #402424

Kyle Wheeler | 17 Aug 19:23

Re: trash folder in 1.5.18


On Saturday, August 16 at 06:25 PM, quoth P Kapat:
> The trash folder patch from 
> http://cedricduval.free.fr/mutt/patches/#trash  is only upto the 
> mutt version 1.5.5.1; there are no patches after that. I am guessing 
> that it has been included in the original code.

It has not been.

> I have used the trash folder option in 1.5.17 (the binary version 
> included with Ubuntu Hardy). Any help?

That old patch will *probably* work. You can at least try it.

~Kyle
--

-- 
Make no little plans. They have no magic to stir men's blood.
                                                      -- Daniel Burnham
P Kapat | 19 Aug 00:33

Re: trash folder in 1.5.18

Hi,

On 8/17/08, Kyle Wheeler <kyle-mutt <at> memoryhole.net> wrote:
>
> On Saturday, August 16 at 06:25 PM, quoth P Kapat:
>> The trash folder patch from
>> http://cedricduval.free.fr/mutt/patches/#trash  is only upto the
>> mutt version 1.5.5.1; there are no patches after that. I am guessing
>> that it has been included in the original code.
>
> It has not been.

OK.

>> I have used the trash folder option in 1.5.17 (the binary version
>> included with Ubuntu Hardy). Any help?
>
> That old patch will *probably* work. You can at least try it.

I tried to patch the already patched (with sidebar) code with the trash.folder patch. It was not entirely
clean (output given below). Nevertheless the configure and make process didn't give any error and I am
able to use the "set trash=" option now! Is it okay to live with these errors? BTW, I tried to apply this patch
before applying the sidebar patch and the errors were similar.

Thanks again.

PATCH OUTPUT:

$ patch -p1 < patch-1.5.5.1.cd.trash_folder.3.4
patching file commands.c
(Continue reading)

Kyle Wheeler | 19 Aug 00:59

Re: trash folder in 1.5.18


On Monday, August 18 at 06:33 PM, quoth P Kapat:
> I tried to patch the already patched (with sidebar) code with the 
> trash.folder patch. It was not entirely clean (output given below).

Uy. Unfortunately, those FAILED lines probably mean that you need to 
reconcile the patch with those files by hand in order to make it work 
*correctly*.

> Nevertheless the configure and make process didn't give any error 
> and I am able to use the "set trash=" option now! Is it okay to live 
> with these errors? BTW, I tried to apply this patch before applying 
> the sidebar patch and the errors were similar.

If it works for you, cool; unfortunately, I suspect that even though 
it compiled without errors, it doesn't actually do all the right 
things. Having code that compiles without errors is akin to saying 
that your essay has no spelling errors: it's important, but it doesn't 
guarantee that whats in there makes any sense.

If you're not much of a C programmer, you can try applying the two 
patches in reverse order (i.e. apply the trash patch first, and the 
sidebar patch second), or you can try asking the author of the trash 
patch to fix it for you.

~Kyle
--

-- 
The purpose of computing is insight, not numbers.
                                                  -- Richard W. Hamming
(Continue reading)

P Kapat | 19 Aug 06:29

Re: trash folder in 1.5.18

Hi,

On 8/18/08, Kyle Wheeler <kyle-mutt <at> memoryhole.net> wrote:
>
> Uy. Unfortunately, those FAILED lines probably mean that you need to
> reconcile the patch with those files by hand in order to make it work
> *correctly*.

Ah, that is the tricky part. Though I can read the syntax of the
source code and the patch, but not knowing the utility of the
statements, it will be impossible to patch them correctly.

> If you're not much of a C programmer, you can try applying the two
> patches in reverse order (i.e. apply the trash patch first, and the
> sidebar patch second), or you can try asking the author of the trash
> patch to fix it for you.

I'll try to contact the author and see. Thanks the nonetheless!

--

-- 
Regards
PK
--------------------------------------
http://counter.li.org  #402424

David Champion | 19 Aug 07:13
Favicon

Re: trash folder in 1.5.18

> >> http://cedricduval.free.fr/mutt/patches/#trash  is only upto the
> >> mutt version 1.5.5.1; there are no patches after that. I am guessing
> >> that it has been included in the original code.
> >
> > It has not been.

Cedric hasn't updated it AFAIK, but a google
on "cedric duval trash patch" turns up
http://scie.nti.st/2007/6/21/mutt-trash-folder-patch-for-1-5-16 . Maybe
that version will apply more cleanly to 1.5.18.

--

-- 
 -D.    dgc <at> uchicago.edu    NSIT    University of Chicago

Christian Brabandt | 19 Aug 09:05

Re: trash folder in 1.5.18

Hi David!

On Tue, 19 Aug 2008, David Champion wrote:

> > >> http://cedricduval.free.fr/mutt/patches/#trash  is only upto the
> > >> mutt version 1.5.5.1; there are no patches after that. I am guessing
> > >> that it has been included in the original code.
> > >
> > > It has not been.
> 
> Cedric hasn't updated it AFAIK, but a google
> on "cedric duval trash patch" turns up
> http://scie.nti.st/2007/6/21/mutt-trash-folder-patch-for-1-5-16 . Maybe
> that version will apply more cleanly to 1.5.18.

You could also get the source code from Debian, which includes the 
trash-folder patch. They have a version for 1.5.18

regards,
Christian
--

-- 
When the Universe was not so out of whack as it is today, and all the
stars were lined up in their proper places, you could easily count them
from left to right, or top to bottom, and the larger and bluer ones were
set apart, and the smaller yellowing types pushed off to the corners as
bodies of a lower grade ...
		-- Stanislaw Lem, "Cyberiad"


Gmane