Re: DC++ incompatibility
Robin Hill <robin <at> robinhill.me.uk>
2004-11-07 19:12:17 GMT
On Sun Nov 07, 2004 at 07:15:47PM +0100, Tommy Thorsen wrote:
> Robin Hill wrote:
>
> >That's right, yes. When you want to download from someone then they'll
> >connect to you. Your client _should_ then be in download mode (as it
> >knows it's wanting to download from this user) and the remote client is
> >either in upload mode (in which case the download starts) or also in
> >download mode (in which case the priority is looked at and you either
> >switch to upload or the remote switches to upload).
> >
> >So, it may be that the problem is with the code whereby Valknut decides
> >which mode to start in so it's starting in upload mode rather than
> >download mode.
> >
> I see that the CDownloadManager::CheckWaitTransfer() function returns
> edUPLOAD in this case, whereas it returns edDOWNLOAD when I try (and
> succeed) to download from other dclib-using people.
>
> If I understand this function correctly, it checks whether there is a
> waiting transfer. If it can't find a pending download from this user, it
> concludes that this must be a request from the other client to download
> something from me, therefore my transfer-direction should be edUPLOAD.
>
> Now, there should really be a transfer waiting, since I am trying to
> download from this person, but for some reason the nick and hubname used
> in the checks does not match any of the nicks and hubnames in the list
> of waiting transfers.
>
<-- snip -->
(Continue reading)
>>Question 2: This is really my most important question; Why do we not try >>to change SrcDirection in line 22? >> >> >> >Because it doesn't make sense here. Both parties are trying to upload a >file. but the other party has priority in this case, so they should >switch direction or retry (if they're not wanting to download). > > I'm reaching this code when I try to download files from certain DC++ users. I haven't explicitly tried to upload anything. Are files (like filelists) automatically and secretly uploaded to the other party when I try to download from them? If the other party has priority, shouldn't we yield and switch direction? Or do I misunderstand the nature of this priority? >>Question 4: What does SrcDirection and DstDirection do anyway? It looks >>to me like they need do be different, right? One side of the >>communication should upload while the other downloads, is that it? >> >> >> >Yes, usually they'll be different. If everyone was active then theere >wouldn't be a problem as you'd always be uploading to incoming >connections and downloading from outgoing connections. With passive >users you just don't know whether someone connecting to you is
RSS Feed