Woogie | 12 Dec 02:03
Picon
Picon
Favicon

Questions about submitting a patch

Hi everyone

This is my first time submitting a patch for OSS, so bear with me while 
I ask a few questions (couldn't find anything on the site).

First Question: Is Valknut still being actively maintained? I've seen 
some activity here on the mailing list via the archives, and it looks 
like that UTF8 issue got resolved in CVS, but just checking :)

Second Question: How should I note my code changes? Looking at code in 
the Linux kernel, people there will say who submitted the change, their 
e-mail, when they made the change and what the change does in comments. 
Should I go just as far?

Third Question:  I noted the generic C++ documentation (the stuff in the 
/** */ style comments) was missing in most cases in the source. The 
changes I've made have this documentation for the methods, should I keep 
this documentation when I submit a patch?

Fourth Question: i18n. I'm not really familiar with this. I noticed 
there's a lot of language translations for Valknut. My total changes to 
the UI involve a whopping three words, without much of a grammatical 
construct at all. I can go to online dictionaries and grab "close 
enough" translations. Should I grab translations and update the 
translation files?

Fifth Question:  How should I make and submit my patches? I haven't 
worked that in depth with CVS or patch/diff before. Could somebody 
spoon-feed me a way to generate appropriate patch files for the changes 
I've made to the Valknut module? Also, when I've genereated these 
(Continue reading)

Vesa-Matti Sarenius | 23 Dec 06:39
Picon
Picon

Valknut cvs does not work on fc3

Hi!

Just installed FC3 and compiled the new Valknut. Everything went fine. And
valknut even worked. Then I installed the updates to FC3 and valknut does
not work. Just gives this error:

CXml::xml_UTF8Toisolat1 error 5
CXml::xml_UTF8Toisolat1 error 1

million times over and when it starts, no text can be seen.

So, what's up?

These are the qt-versions

qt-3.3.3-8
qt-config-3.3.3-8
qt-devel-3.3.3-8

And I did compile again after installing the fc3 updates...

--

-- 
Vesa-Matti Sarenius, M.Sc.       * Don't let the might,      *
mailto:sarenius.at.paju.oulu.fi   * the Christian right,      *
Finland, Europe.                   * fuck it all up for you    *
*   *   *   *   *  R. Waters, 2004  * and the rest of the world *
Mathias Küster | 24 Dec 14:51
Picon

Re: Valknut cvs does not work on fc3

Hello,

this bug is fixed in the new version.

Best Regards,

Mathias

Vesa-Matti Sarenius wrote:
> Hi!
> 
> Just installed FC3 and compiled the new Valknut. Everything went fine. And
> valknut even worked. Then I installed the updates to FC3 and valknut does
> not work. Just gives this error:
> 
> CXml::xml_UTF8Toisolat1 error 5
> CXml::xml_UTF8Toisolat1 error 1
> 
> million times over and when it starts, no text can be seen.
> 
> So, what's up?
> 
> These are the qt-versions
> 
> qt-3.3.3-8
> qt-config-3.3.3-8
> qt-devel-3.3.3-8
> 
> And I did compile again after installing the fc3 updates...
> 
(Continue reading)


Gmane