From the commit log: * add . to include path so ares_build.h is picked up * make ar configurable to ease cross-compiling On a side note, can you guys start using GH pull requests? It's kind of annoying to have to subscribe to yet another mailing list, especially when it's a trivial patch like this.
On Wed, 25 Apr 2012, Ben Noordhuis wrote: Thanks for the patch, applied and pushed now! > On a side note, can you guys start using GH pull requests? It's kind of > annoying to have to subscribe to yet another mailing list, especially when > it's a trivial patch like this. I strongly dislike github pull requests unless the patch has been properly reviewed and discussed on the list first (which then pretty much takes away the need to send a pull request). A few reasons: * We want patches to be reviewed, tested and commented by anyone who's interested and volunteering: that is anyone on the mailing list can speak up. Pull requests on github assume there's a limited core group that does such things. * I don't want annoying merge commits and github pull requests can't even be forced to avoid them. * Merging patches off the list allows us to tweak the commit messages before the commits are pushed which makes them better. * Having the discussions and reviews done on the mailing list gives us a much better record and unified place where they happen instead of spread out in on github. -- -- / daniel.haxx.se(Continue reading)
On Wed, Apr 25, 2012 at 05:44, Daniel Stenberg <daniel@...> wrote: > On Wed, 25 Apr 2012, Ben Noordhuis wrote: > > Thanks for the patch, applied and pushed now! > > >> On a side note, can you guys start using GH pull requests? It's kind of >> annoying to have to subscribe to yet another mailing list, especially when >> it's a trivial patch like this. > > > I strongly dislike github pull requests unless the patch has been properly > reviewed and discussed on the list first (which then pretty much takes away > the need to send a pull request). A few reasons: > > * We want patches to be reviewed, tested and commented by anyone who's > interested and volunteering: that is anyone on the mailing list can speak > up. Pull requests on github assume there's a limited core group that does > such things. > > * I don't want annoying merge commits and github pull requests can't even be > forced to avoid them. > > * Merging patches off the list allows us to tweak the commit messages before > the commits are pushed which makes them better. > > * Having the discussions and reviews done on the mailing list gives us a > much > better record and unified place where they happen instead of spread out in > on github.(Continue reading)
RSS Feed