Re: [PATCH] Extension mechanisms for DNS
Daniel Stenberg <daniel@...
2012-06-30 21:52:07 GMT
On Fri, 29 Jun 2012, Ghennadi Procopciuc wrote:
> We observed that actual implementation of c-ares doesn't provides a support
> for extension mechanisms for DNS (EDNS), so we wrote it.
> Is there interest in this patch ?
Thanks a lot, it looks like functionality we certainly could add. I do have an
objection to how you've made the change though that I cannot accept.
ares_mkquery() is a function in the c-ares API/ABI that may not be modified.
If you can't add your functionality without extending the prototype, then we
need to add a replacement function for ares_mkquery() instead (like for
example ares_create_query()) and deprecate the existing one in the
Oh, and please also try making all source code be less than 80 columns wide.