Re: Bugfix 0.8.5rc1: Admin Structure Not Found [PATCH]

On Tue, 2010-06-01 at 20:18 -0300, Martin Parodi wrote:
> No problem, Tomorrow I will send screenshots, do you need anything
> else to debug the problem?

I'm not sure yet.  I'm hoping I can reproduce the problem on my side
which will make it a bit easier to hunt down.  If it is related to the
other bugfix we should be able to pin it down.

> 
> 2010/6/1 Eric Wheeler <jffnms@...>
>         On Tue, 2010-06-01 at 17:51 -0300, Martin Parodi wrote:
>         > Hello, yes, its working now, but im still have the problem
>         whith
>         > zones, when i try to select zone this is empty, same problem
>         with
>         > "AutoDiscovery Policy" "AD Default Customer", apparently
>         this is
>         > another problem different of Admin Structure Not Found
>         
>         
>         Interesting.  Can you create an exact step-by-step to reliably
>         reproduce
>         the problem?
>         
>         
>         
>         >
>         > Sorry for may English and thanks in advance.
>         >
>         >
>         >
>         > 2010/6/1 Eric Wheeler <jffnms@...>
>         >         On Tue, 2010-06-01 at 08:59 -0300, Martin Parodi
>         wrote:
>         >         > Hello all, can anyone explain how to exactly solve
>         this
>         >         problem?
>         >         > I dont know which file I have to edit.
>         >         > Im running jffnms 0.8.4 on Ubuntu 10.4 server and
>         im getting
>         >         this
>         >         > error.
>         >         > So, could you explain which file i have to edit
>         and how?
>         >
>         >
>         >         You will need to modify
>         jffnms/htdocs/admin/adm/structures.php
>         >         at about
>         >         line 737 and add
>         >
>         >               if (!$_GET['admin_structure'])
>         >                       $_GET['admin_structure'] =
>         >         $_POST['admin_structure'];
>         >
>         >
>         >         Just above the line
>         >           if ($admin_structure=="list_all") {
>         >
>         >
>         >         If it works please let us know.  Craig, was this
>         applied to
>         >         0.8.5's bugfix release?
>         >
>         >         -Eric
>         >
>         >
>         >         >
>         >         > Thanks.
>         >         >
>         >         >
>         >         > 2010/4/10 Eric Wheeler <jffnms@...>
>         >         >         More on this bug starting on this thread:
>         >         >
>         >
>         http://www.mail-archive.com/jffnms-users-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f <at> public.gmane.org/msg03379.html
>         >         >
>         >         >         Javier's response
>         >         >
>         >
>         http://www.mail-archive.com/jffnms-users-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f <at> public.gmane.org/msg04252.html
>         >         >
>         >         >         To reproduce the bug, edit a host, save
>         the host,
>         >         and try to
>         >         >         edit a host
>         >         >         again. It will respond with "Admin
>         Structure Not
>         >         Found".
>         >         >         (Reproducible
>         >         >         with Zones also, perhaps others areas
>         too.)
>         >         >
>         >         >         Interestingly, this appears to be working
>         in the
>         >         Debian
>         >         >         jffnms-0.8.3dfsg.1-7.1 package, but fails
>         in the
>         >         0.8.5rc1
>         >         >         tarball.
>         >         >         Perhaps a regression?
>         >         >
>         >         >         It seems that when a POST is performed
>         that the
>         >         >         admin_structure gets
>         >         >         lost and is expected in $_GET later.  So,
>         if $_GET
>         >         is missing
>         >         >         the entry,
>         >         >         I assume it is in $_POST and update
>         $_GET.  See the
>         >         2-liner
>         >         >         below.
>         >         >
>         >         >         Test this patch well---it works for me.
>         >         >
>         >         >         Now, back to the RFC3877 plugin.
>         >         >
>         >         >         -Eric
>         >         >
>         >         >
>         >         >
>         >         >         --- htdocs/admin/adm/structures.php
>         2009-01-15
>         >         >         20:47:19.000000000 -0800
>         >         >
>         +++ /opt/jffnms/htdocs/admin/adm/structures.php
>         >         2010-04-10
>         >         >         18:21:22.000000000 -0700
>         >         >          <at>  <at>  -737,7 +737,8  <at>  <at> 
>         >         >                     NULL)
>         >         >             );
>         >         >
>         >         >         -
>         >         >         +       if (!$_GET['admin_structure'])
>         >         >         +               $_GET['admin_structure'] =
>         >         >         $_POST['admin_structure'];
>         >         >
>         >         >             if ($admin_structure=="list_all") {
>         >         >                foreach (array_keys($structures) as
>         $aux)
>         >         >
>         >         >
>         >         >
>         >         >
>         >         >
>         >         >
>         >         >
>         >         >
>         >
>         ------------------------------------------------------------------------------
>         >         >         Download Intel&#174; Parallel Studio Eval
>         >         >         Try the new software tools for yourself.
>         Speed
>         >         compiling, find
>         >         >         bugs
>         >         >         proactively, and fine-tune applications
>         for parallel
>         >         >         performance.
>         >         >         See why Intel Parallel Studio got high
>         marks during
>         >         beta.
>         >         >         http://p.sf.net/sfu/intel-sw-dev
>         >         >
>         _______________________________________________
>         >         >         jffnms-users mailing list
>         >         >         jffnms-users@...
>         >         >
>         >
>         https://lists.sourceforge.net/lists/listinfo/jffnms-users
>         >         >
>         >         >
>         >         >
>         >         > --
>         >         > Martin Parodi
>         >
>         >
>         >
>         >
>         >
>         > --
>         > Martin Parodi
>         
>         
> 
> 
> 
> -- 
> Martin Parodi

------------------------------------------------------------------------------