Jeroen Roovers | 9 Aug 2012 12:48
Picon
Favicon

[PATCH] Fix building against GNU libc 2.16 (gets undefined)

Martin Jansa reported[1] a bug compiling lftp against GNU libc 2.16. The
code assumes gets is defined when in 2.16 it is not. The attached
patch adds the necessary check.

     jer

[1] https://bugs.gentoo.org/show_bug.cgi?id=425026
--- a/lib/stdio.in.h
+++ b/lib/stdio.in.h
 <at>  <at>  -702,10 +702,12  <at>  <at> 
 /* It is very rare that the developer ever has full control of stdin,
    so any use of gets warrants an unconditional warning; besides, C11
    removed it.  */
+#ifdef gets
 #undef gets
 #if HAVE_RAW_DECL_GETS
 _GL_WARN_ON_USE (gets, "gets is a security hole - use fgets instead");
 #endif
+#endif

 
 #if  <at> GNULIB_OBSTACK_PRINTF <at>  ||  <at> GNULIB_OBSTACK_PRINTF_POSIX <at> 
_______________________________________________
lftp mailing list
lftp <at> uniyar.ac.ru
http://univ.uniyar.ac.ru/mailman/listinfo/lftp
(Continue reading)

Alexander V. Lukyanov | 10 Aug 2012 06:28
Picon
Gravatar

Re: [PATCH] Fix building against GNU libc 2.16 (gets undefined)

On Thu, Aug 09, 2012 at 12:48:40PM +0200, Jeroen Roovers wrote:
> Martin Jansa reported[1] a bug compiling lftp against GNU libc 2.16. The
> code assumes gets is defined when in 2.16 it is not. The attached
> patch adds the necessary check.

Thank you! But the patch should go to gnulib people... I'll forward
your patch to bug-gnulib <at> gnu.org

--

-- 
   Alexander.
_______________________________________________
lftp mailing list
lftp <at> uniyar.ac.ru
http://univ.uniyar.ac.ru/mailman/listinfo/lftp


Gmane