headers
Sekar Vembu | 20 Mar 2006 13:48
Favicon

[Fwd: bug 1110812 - 4Gigbug.patch does not work in Windows]

Hi,
Subsequent to my original email, I think we have fixed the large file 
problem in Windows too. We have made minor modifications to three files. 
We have tested this and it seems to work for us. I am attaching the 
three files with this email.
1. buf.c
2. librsync.h
3.PcBuild\librsync-config.h

The following are the cvs-diff for those three files. Hope some expert 
will review this and check this in to the librsync CVS. If there is a 
problem with these changes please let me know.

cvs diff buf.c
Index: buf.c
===================================================================
RCS file: /cvsroot/librsync/librsync/buf.c,v
retrieving revision 1.22
diff -r1.22 buf.c
209c209,215
<     if (fseek(f, pos, SEEK_SET)) {
---
 >    
 >
 >     #if WIN32
 >         if (_fseeki64(f, (__int64)pos, SEEK_SET) < 0 ) {
 >     #else
 >         if (fseek(f, pos, SEEK_SET)) {
 >     #endif
(Continue reading)

Permalink | Reply |
headers
Donovan Baarda | 20 Mar 2006 14:43
Picon
Picon
Gravatar

Re: [Fwd: bug 1110812 - 4Gigbug.patch does not work in Windows]

On Mon, 2006-03-20 at 18:18 +0530, Sekar Vembu wrote:
> Hi,
> Subsequent to my original email, I think we have fixed the large file 
> problem in Windows too. We have made minor modifications to three files. 
> We have tested this and it seems to work for us. I am attaching the 
> three files with this email.
> 1. buf.c
> 2. librsync.h
> 3.PcBuild\librsync-config.h
> 
> The following are the cvs-diff for those three files. Hope some expert 
> will review this and check this in to the librsync CVS. If there is a 
> problem with these changes please let me know.

Please submit patches at the SF patch tracker...

Also, looking at this, I have a feeling this is compiler dependant,
rather than just WIN32 dependent. I suspect this stuff should be handled
by configure, rather than peppering the code with more #if WIN32 stuff.
Note that PCBuild/librsync-config.h should be auto-generated by running
configure with a MSC system.

In any case, thanks for this... if no one else gets around to it before
me, I'll look into it and see what the best approach for this is...

--

-- 
Donovan Baarda <abo <at> minkirri.apana.org.au>
http://minkirri.apana.org.au/~abo/

-------------------------------------------------------
(Continue reading)

Permalink | Reply |
headers
Sekar Vembu | 20 Mar 2006 14:48
Favicon

Re: [Fwd: bug 1110812 - 4Gigbug.patch does not work in Windows]

Sorry about not using the SF patch tracker. We will learn the right way 
to send patches in the future. Hopefully these fixes are useful and you 
can incorporate it with the right approach in the librsync source code.

Thanks
Sekar

Donovan Baarda wrote:

>On Mon, 2006-03-20 at 18:18 +0530, Sekar Vembu wrote:
>  
>
>>Hi,
>>Subsequent to my original email, I think we have fixed the large file 
>>problem in Windows too. We have made minor modifications to three files. 
>>We have tested this and it seems to work for us. I am attaching the 
>>three files with this email.
>>1. buf.c
>>2. librsync.h
>>3.PcBuild\librsync-config.h
>>
>>The following are the cvs-diff for those three files. Hope some expert 
>>will review this and check this in to the librsync CVS. If there is a 
>>problem with these changes please let me know.
>>    
>>
>
>Please submit patches at the SF patch tracker...
>
>Also, looking at this, I have a feeling this is compiler dependant,
(Continue reading)

Permalink | Reply |
headers
Ben Escoto | 1 May 2006 01:55

Re: [Fwd: bug 1110812 - 4Gigbug.patch does not work in Windows]

>>>>> Sekar Vembu <sekar <at> vembu.com>
>>>>> wrote the following on Mon, 20 Mar 2006 19:18:17 +0530
> Sorry about not using the SF patch tracker. We will learn the right way 
> to send patches in the future. Hopefully these fixes are useful and you 
> can incorporate it with the right approach in the librsync source code.

Yes, I for one am ecstatic that someone seems to have finally tracked
down the 4Gb+ bug.  People post about this from time to time on the
rdiff-backup list and it's not clear if it's librsync or not, and the
probably only occurs sometimes.

So, if you fixed it, great work!  :-)

--

-- 
Ben Escoto
Permalink | Reply |
headers
Donovan Baarda | 20 Mar 2006 14:59
Picon
Picon
Gravatar

Re: [Fwd: bug 1110812 - 4Gigbug.patch does not work in Windows]

On Mon, 2006-03-20 at 19:18 +0530, Sekar Vembu wrote:
> Sorry about not using the SF patch tracker. We will learn the right way 
> to send patches in the future. Hopefully these fixes are useful and you 
> can incorporate it with the right approach in the librsync source code.

Thanks... also, it is worth subscribing to the librsync-dev list on
SF... it means I don't have to keep approving your non-subscriber posts.

These fixes are definitely useful and will go in... the only thing yet
to be determined is how and when :-)

> Thanks
> Sekar
> 
> Donovan Baarda wrote:
> 
> >On Mon, 2006-03-20 at 18:18 +0530, Sekar Vembu wrote:
> >  
> >
> >>Hi,
> >>Subsequent to my original email, I think we have fixed the large file 
> >>problem in Windows too. We have made minor modifications to three files. 
> >>We have tested this and it seems to work for us. I am attaching the 
> >>three files with this email.
> >>1. buf.c
> >>2. librsync.h
> >>3.PcBuild\librsync-config.h
> >>
> >>The following are the cvs-diff for those three files. Hope some expert 
> >>will review this and check this in to the librsync CVS. If there is a
(Continue reading)

Permalink | Reply |

Gmane