Discussion of Netatalk development and bugs

Riccardo Magliocchetti | 21 May 2012 20:05

[PATCH] Fix resource leak in iniparser

Hello,

if dictionary_new fails we are fclose()ing the wrong variable which is 
undefined so not a reccomended thing to do :)

Spotted by cppcheck, diffed against master.

thanks,
riccardo

Attachment (iniparser-close-correct-FILE.diff): text/x-diff, 382 bytes

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

_______________________________________________
Netatalk-devel mailing list
Netatalk-devel <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/netatalk-devel

headers

Frank Lahm | 22 May 2012 13:14

Re: [PATCH] Fix resource leak in iniparser

2012/5/21 Riccardo Magliocchetti <riccardo.magliocchetti <at> gmail.com>:
> Hello,
>
> if dictionary_new fails we are fclose()ing the wrong variable which is
> undefined so not a reccomended thing to do :)
>
> Spotted by cppcheck, diffed against master.

Committed to branch 2-2. Thanks!
-f

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

headers

Frank Lahm | 22 May 2012 13:21

Re: [PATCH] Fix resource leak in iniparser

2012/5/22 Frank Lahm <franklahm <at> googlemail.com>:
> 2012/5/21 Riccardo Magliocchetti <riccardo.magliocchetti <at> gmail.com>:
>> Hello,
>>
>> if dictionary_new fails we are fclose()ing the wrong variable which is
>> undefined so not a reccomended thing to do :)
>>
>> Spotted by cppcheck, diffed against master.
>
> Committed to branch 2-2. Thanks!

develop, not 2-2.
-f

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/