OpenChange Technical Mailing-list

Matthieu Patou | 19 Mar 2012 06:57

[openchange]Using talloced profile + various patch

Hello list,

While trying to figure out why openchangesim require so much memory I 
found that I had long lasting ldb objects and cli_credential.

But making profile to be talloced we can use profile as a talloc context 
for ldb requests and for cli_credential thus allowing desallocation of 
memory once the profile is not needed anymore.

I have also I patch to free the session in duplicate profile and another 
to have correctly initialized structures so that valgrind doesn't complain.

Any comments ?

Matthieu

Attachment (0001-Free-the-session-in-duplicateprofile.patch): text/x-patch, 868 bytes

Attachment (0002-Cleanly-initialize-structures-for-mapi_response.patch): text/x-patch, 1922 bytes

Attachment (0003-Move-to-talloced-profile-so-that-we-can-free-ressour.patch): text/x-patch, 9 KiB

Attachment (0004-Use-the-profile-as-a-talloc-context-for-credentials-.patch): text/x-patch, 931 bytes

_______________________________________________
devel mailing list
devel <at> lists.openchange.org
http://mailman.openchange.org/listinfo/devel

headers

Julien Kerihuel | 19 Mar 2012 15:04

Re: [openchange]Using talloced profile + various patch

Hi Mathieu,

Looks like a worthwhile change to me.

We may just have to warn (within Doxygen documentation) developers
writing clients that they will now be expected to talloc their profile
struct.

Milan, Shaheed, would this change cause any troubles to your development
cycles?

While 1.1 will introduce some backward compatibility issues both for
libmapi and openchange server, I'd like to make sure developers using
openchange components can deal with it.

Julien.

On Sun, 2012-03-18 at 22:57 -0700, Matthieu Patou wrote:
> Hello list,
> 
> While trying to figure out why openchangesim require so much memory I 
> found that I had long lasting ldb objects and cli_credential.
> 
> But making profile to be talloced we can use profile as a talloc context 
> for ldb requests and for cli_credential thus allowing desallocation of 
> memory once the profile is not needed anymore.
> 
> I have also I patch to free the session in duplicate profile and another 
> to have correctly initialized structures so that valgrind doesn't complain.
>

(Continue reading)

headers

Milan Crha | 19 Mar 2012 16:39

Re: [openchange]Using talloced profile + various patch

On Mon, 2012-03-19 at 15:04 +0100, Julien Kerihuel wrote:
> Milan, Shaheed, would this change cause any troubles to your
> development cycles?

Hi,
I do not expect any trouble on evolution-mapi side, I grepped its
sources and I do not see any usage of 'struct mapi_profile' there.
Bye,
Milan

headers

Shaheed Haque | 19 Mar 2012 21:10

Re: [openchange]Using talloced profile + various patch

I also make no use of struct mapi_profile.

On 19 March 2012 15:39, Milan Crha <mcrha <at> redhat.com> wrote:
> On Mon, 2012-03-19 at 15:04 +0100, Julien Kerihuel wrote:
>> Milan, Shaheed, would this change cause any troubles to your
>> development cycles?
>
> Hi,
> I do not expect any trouble on evolution-mapi side, I grepped its
> sources and I do not see any usage of 'struct mapi_profile' there.
> Bye,
> Milan
>
> _______________________________________________
> devel mailing list
> devel <at> lists.openchange.org
> http://mailman.openchange.org/listinfo/devel