Simo Sorce | 1 Feb 2009 19:08
Picon
Favicon

[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha6-317-g1dc745e

The branch, master has been updated
       via  1dc745ec895181af84998c1451ebffc7d3ba2081 (commit)
       via  10c907bcdb5856feb15bd6b096254ea5d112a8c9 (commit)
      from  c14b7e648bcfc4865da4b290e46977fff81d4500 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master

- Log -----------------------------------------------------------------
commit 1dc745ec895181af84998c1451ebffc7d3ba2081
Author: Simo Sorce <idra <at> samba.org>
Date:   Sun Feb 1 13:06:38 2009 -0500

    Make schannel not depend on samdb anymore.

commit 10c907bcdb5856feb15bd6b096254ea5d112a8c9
Author: Simo Sorce <idra <at> samba.org>
Date:   Sun Feb 1 13:06:13 2009 -0500

    Fix headers, only ldb.h is required

-----------------------------------------------------------------------

Summary of changes:
 lib/util/util_ldb.c                  |    2 -
 source4/auth/gensec/config.mk        |    2 +-
 source4/auth/gensec/schannel_state.c |   65 +++++++++++++++++++++++++++++++---
 3 files changed, 61 insertions(+), 8 deletions(-)

Changeset truncated at 500 lines:

(Continue reading)

Andrew Bartlett | 2 Feb 2009 01:06
Picon
Favicon

Make schannel not depend on samdb anymore. (was Re: [SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha6-317-g1dc745e)

On Sun, 2009-02-01 at 12:08 -0600, Simo Sorce wrote:
> The branch, master has been updated
>        via  1dc745ec895181af84998c1451ebffc7d3ba2081 (commit)
>        via  10c907bcdb5856feb15bd6b096254ea5d112a8c9 (commit)
>       from  c14b7e648bcfc4865da4b290e46977fff81d4500 (commit)
> 
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> 
> 
> - Log -----------------------------------------------------------------
> commit 1dc745ec895181af84998c1451ebffc7d3ba2081
> Author: Simo Sorce <idra <at> samba.org>
> Date:   Sun Feb 1 13:06:38 2009 -0500
> 
>     Make schannel not depend on samdb anymore.

I'm confused, why do we have to duplicate these functions?

> diff --git a/source4/auth/gensec/schannel_state.c b/source4/auth/gensec/schannel_state.c
> index d86b1f2..ca8537c 100644
> --- a/source4/auth/gensec/schannel_state.c
> +++ b/source4/auth/gensec/schannel_state.c
>  <at>  <at>  -20,10 +20,8  <at>  <at> 
>  */
>  
>  #include "includes.h"
> -#include "lib/events/events.h"
>  #include "lib/ldb/include/ldb.h"
> -#include "lib/ldb/include/ldb_errors.h"
> -#include "dsdb/samdb/samdb.h"
(Continue reading)

simo | 2 Feb 2009 04:54
Picon
Favicon

Re: Make schannel not depend on samdb anymore. (was Re: [SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha6-317-g1dc745e)

On Mon, 2009-02-02 at 11:06 +1100, Andrew Bartlett wrote:
> On Sun, 2009-02-01 at 12:08 -0600, Simo Sorce wrote:
> > The branch, master has been updated
> >        via  1dc745ec895181af84998c1451ebffc7d3ba2081 (commit)
> >        via  10c907bcdb5856feb15bd6b096254ea5d112a8c9 (commit)
> >       from  c14b7e648bcfc4865da4b290e46977fff81d4500 (commit)
> > 
> > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> > 
> > 
> > - Log -----------------------------------------------------------------
> > commit 1dc745ec895181af84998c1451ebffc7d3ba2081
> > Author: Simo Sorce <idra <at> samba.org>
> > Date:   Sun Feb 1 13:06:38 2009 -0500
> > 
> >     Make schannel not depend on samdb anymore.
> 
> I'm confused, why do we have to duplicate these functions?

They are not really duplicated, they were just wrapper functions that
were unnecessarily dragging in a whole subsystem for nothing.

I am trying to clean up deps to avoid the jungle of dependencies we have
now. The goal is to be able to give openchange just the "client"
libraries they need without having to drag in the whole samba4 "server"
code.

Simo.

--

-- 
(Continue reading)

Andrew Bartlett | 2 Feb 2009 04:59
Picon
Favicon

Re: Make schannel not depend on samdb anymore. (was Re: [SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha6-317-g1dc745e)

On Mon, 2009-02-02 at 03:54 +0000, simo wrote:
> On Mon, 2009-02-02 at 11:06 +1100, Andrew Bartlett wrote:
> > On Sun, 2009-02-01 at 12:08 -0600, Simo Sorce wrote:
> > > The branch, master has been updated
> > >        via  1dc745ec895181af84998c1451ebffc7d3ba2081 (commit)
> > >        via  10c907bcdb5856feb15bd6b096254ea5d112a8c9 (commit)
> > >       from  c14b7e648bcfc4865da4b290e46977fff81d4500 (commit)
> > > 
> > > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> > > 
> > > 
> > > - Log -----------------------------------------------------------------
> > > commit 1dc745ec895181af84998c1451ebffc7d3ba2081
> > > Author: Simo Sorce <idra <at> samba.org>
> > > Date:   Sun Feb 1 13:06:38 2009 -0500
> > > 
> > >     Make schannel not depend on samdb anymore.
> > 
> > I'm confused, why do we have to duplicate these functions?
> 
> They are not really duplicated, they were just wrapper functions that
> were unnecessarily dragging in a whole subsystem for nothing.
> 
> I am trying to clean up deps to avoid the jungle of dependencies we have
> now. The goal is to be able to give openchange just the "client"
> libraries they need without having to drag in the whole samba4 "server"
> code.

Sure.  I just expected you would find/create another lib to shuffle them
along to, that's all.
(Continue reading)

simo | 2 Feb 2009 05:08
Picon
Favicon

Re: Make schannel not depend on samdb anymore. (was Re: [SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha6-317-g1dc745e)

On Mon, 2009-02-02 at 14:59 +1100, Andrew Bartlett wrote:
> On Mon, 2009-02-02 at 03:54 +0000, simo wrote:
> > On Mon, 2009-02-02 at 11:06 +1100, Andrew Bartlett wrote:
> > > On Sun, 2009-02-01 at 12:08 -0600, Simo Sorce wrote:
> > > > The branch, master has been updated
> > > >        via  1dc745ec895181af84998c1451ebffc7d3ba2081 (commit)
> > > >        via  10c907bcdb5856feb15bd6b096254ea5d112a8c9 (commit)
> > > >       from  c14b7e648bcfc4865da4b290e46977fff81d4500 (commit)
> > > > 
> > > > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> > > > 
> > > > 
> > > > - Log -----------------------------------------------------------------
> > > > commit 1dc745ec895181af84998c1451ebffc7d3ba2081
> > > > Author: Simo Sorce <idra <at> samba.org>
> > > > Date:   Sun Feb 1 13:06:38 2009 -0500
> > > > 
> > > >     Make schannel not depend on samdb anymore.
> > > 
> > > I'm confused, why do we have to duplicate these functions?
> > 
> > They are not really duplicated, they were just wrapper functions that
> > were unnecessarily dragging in a whole subsystem for nothing.
> > 
> > I am trying to clean up deps to avoid the jungle of dependencies we have
> > now. The goal is to be able to give openchange just the "client"
> > libraries they need without having to drag in the whole samba4 "server"
> > code.
> 
> Sure.  I just expected you would find/create another lib to shuffle them
(Continue reading)


Gmane