Discussions on Samba internals

Lukasz Zalewski | 25 Jun 2012 19:55

[PATCHES] Make add_remove_group_members a private helper function and partial fixes for Bug #8891

Hi Jelmer, list

First patch makes the add_remove_group_members a private helper function 
and adds separate calls to add and remove members.

Second and third patch provide a partial fix for Bug #8891.
The reason why i said partial, is that the bug contains a mix of 
problems and feature requests, and only the following have been addressed:

* addmembers/removemembers will throw an exception for any of the users 
for which a DN cannot be found.

* adding a group member that already exists or removing member that does 
not exist will not be silently ignored - instead a ldb exception
Attribute member already exists for target GUID ... (when adding), or
Attribute member already deleted for target GUID ... (when removing)
will be produced

* trying to list members of nonexistent group will produce an exception

Things that have not been addressed:
* Inability to add/remove members which have existed before migration 
from s3 to s4 - I'm hoping the new error handling will provide more 
information to why it is failing.

* listgroups/memberof (feature request) has not been implemented yet

Regards

L

(Continue reading)

headers

Sergey Urushkin | 3 Jul 2012 11:47

Re: [PATCHES] Make add_remove_group_members a private helper function and partial fixes for Bug #8891

Hi.
I've Just tried your patches, see my comment in the bugzilla.
Thanks.

25.06.2012 21:55, Lukasz Zalewski пишет:
> Hi Jelmer, list
>
> First patch makes the add_remove_group_members a private helper
> function and adds separate calls to add and remove members.
>
> Second and third patch provide a partial fix for Bug #8891.
> The reason why i said partial, is that the bug contains a mix of
> problems and feature requests, and only the following have been
> addressed:
>
> * addmembers/removemembers will throw an exception for any of the
> users for which a DN cannot be found.
>
> * adding a group member that already exists or removing member that
> does not exist will not be silently ignored - instead a ldb exception
> Attribute member already exists for target GUID ... (when adding), or
> Attribute member already deleted for target GUID ... (when removing)
> will be produced
>
> * trying to list members of nonexistent group will produce an exception
>
> Things that have not been addressed:
> * Inability to add/remove members which have existed before migration
> from s3 to s4 - I'm hoping the new error handling will provide more
> information to why it is failing.

(Continue reading)