headers
libssh2 Trac | 13 Jun 2012 16:14
Picon
Favicon

#242: Feature request: libssh2_channel_set_timeout()

#242: Feature request: libssh2_channel_set_timeout()
-------------------------+--------------------
 Reporter:  langemeijer  |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  1.4.0
Component:  API          |     Version:  1.4.1
 Keywords:               |  Blocked By:
   Blocks:               |
-------------------------+--------------------
 I would like the function libssh2_channel_set_timeout(), the same way
 libssh2_channel_set_blocking() works, as a simple wrapper on
 libssh2_session_set_timeout().

 I created a patch for it. Complete with documentation and everything.

--

-- 
Ticket URL: <http://trac.libssh2.org/ticket/242>
libssh2 <http://trac.libssh2.org/>
C library for writing portable SSH2 clients

_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Permalink | Reply |
headers
libssh2 Trac | 14 Jun 2012 15:29
Picon
Favicon

Re: #242: Feature request: libssh2_channel_set_timeout()

#242: Feature request: libssh2_channel_set_timeout()
--------------------------+-------------------
  Reporter:  langemeijer  |      Owner:
      Type:  enhancement  |     Status:  new
  Priority:  normal       |  Milestone:  1.4.0
 Component:  API          |    Version:  1.4.1
Resolution:               |   Keywords:
Blocked By:               |     Blocks:
--------------------------+-------------------

Comment (by bagder):

 Sorry but I don't see the point with this. The
 libssh2_channel_set_timeout() is an old legacy and has always been meant
 to set the specific channel to blocking or not.

--

-- 
Ticket URL: <http://trac.libssh2.org/ticket/242#comment:1>
libssh2 <http://trac.libssh2.org/>
C library for writing portable SSH2 clients

_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Permalink | Reply |
headers
libssh2 Trac | 18 Jun 2012 23:44
Picon
Favicon

Re: #242: Feature request: libssh2_channel_set_timeout()

#242: Feature request: libssh2_channel_set_timeout()
--------------------------+-------------------
  Reporter:  langemeijer  |      Owner:
      Type:  enhancement  |     Status:  new
  Priority:  normal       |  Milestone:  1.4.0
 Component:  API          |    Version:  1.4.1
Resolution:               |   Keywords:
Blocked By:               |     Blocks:
--------------------------+-------------------

Comment (by langemeijer):

 What do you mean with "libssh2_channel_set_timeout() is an old legacy"?
 There currently is no libssh2_channel_set_timeout(). I'm assuming you
 meant libssh2_channel_set_blocking() and saying it is legacy code and
 should be removed, but it's API.

 I can work around it. I should be able to get the session from a channel
 on my side. I thought that if the libssh2 api already had
 channel_set_blocking(), channel_set_timeout() would be a logical function
 to have too.

--

-- 
Ticket URL: <http://trac.libssh2.org/ticket/242#comment:2>
libssh2 <http://trac.libssh2.org/>
C library for writing portable SSH2 clients

_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
(Continue reading)

Permalink | Reply |
headers
libssh2 Trac | 18 Jun 2012 23:52
Picon
Favicon

Re: #242: Feature request: libssh2_channel_set_timeout()

#242: Feature request: libssh2_channel_set_timeout()
--------------------------+----------------------
  Reporter:  langemeijer  |      Owner:  bagder
      Type:  enhancement  |     Status:  assigned
  Priority:  normal       |  Milestone:  1.4.0
 Component:  API          |    Version:  1.4.1
Resolution:               |   Keywords:
Blocked By:               |     Blocks:
--------------------------+----------------------
Changes (by bagder):

 * owner:   => bagder
 * status:  new => assigned

Comment:

 Sorry, yes I meant libssh2_channel_set_blocking()

 And I disagree with you. First, what is API is of course there and we
 don't remove it since we make a promise to support the existing API - but
 it doesn't mean we think all the functions were a good idea so that we
 would add more functions in the similar spirit.

 If we had channel-based timeouts I would say that
 libssh2_channel_set_timeout() would be valuable, but I don't think it is a
 good idea to add it just as shortcut to the session-based timeout
 function.

 If you want to discuss this further, I suggest you post to the mailing
 list and argue for it. This is the bug tracker and it really isn't made
(Continue reading)

Permalink | Reply |
headers
libssh2 Trac | 19 Jun 2012 15:08
Picon
Favicon

Re: #242: Feature request: libssh2_channel_set_timeout()

#242: Feature request: libssh2_channel_set_timeout()
--------------------------+----------------------
  Reporter:  langemeijer  |      Owner:  bagder
      Type:  enhancement  |     Status:  assigned
  Priority:  normal       |  Milestone:  1.4.0
 Component:  API          |    Version:  1.4.1
Resolution:               |   Keywords:
Blocked By:               |     Blocks:
--------------------------+----------------------

Comment (by langemeijer):

 No, I agree with you for libssh2.

--

-- 
Ticket URL: <http://trac.libssh2.org/ticket/242#comment:4>
libssh2 <http://trac.libssh2.org/>
C library for writing portable SSH2 clients

_______________________________________________
libssh2-devel http://cool.haxx.se/cgi-bin/mailman/listinfo/libssh2-devel
Permalink | Reply |

Gmane