bugzilla-daemon | 1 Jul 2012 10:07
Picon

[Bug 38099] New: in Gerrit make tab size 4 instead of 8

https://bugzilla.wikimedia.org/show_bug.cgi?id=38099

       Web browser: ---
             Bug #: 38099
           Summary: in Gerrit make tab size 4 instead of 8
           Product: Wikimedia
           Version: unspecified
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: Unprioritized
         Component: Git/Gerrit
        AssignedTo: wikibugs-l <at> lists.wikimedia.org
        ReportedBy: amir.aharoni <at> mail.huji.ac.il
                CC: innocentkiller <at> gmail.com, rlane32 <at> gmail.com
    Classification: Unclassified
   Mobile Platform: ---

I fully understand that this may be a bikeshed, but I'll try anyway.

The diff view in Gerrit shows indentation tabs of 8 spaces. When showing two
compared revisions of the file, it makes the display very wide. On small
screens this very often requires horizontal scrolling.

I am not making any assumptions about the most common tab size among Wikimedia
developers. I'm just thinking of being practical and helping people with
smaller screen to do code review more efficiently.

If it's possible, it would be helpful to define the Gerrit tab size for 4
(Continue reading)

bugzilla-daemon | 1 Jul 2012 10:11
Picon

[Bug 38099] in Gerrit make tab size 4 instead of 8

https://bugzilla.wikimedia.org/show_bug.cgi?id=38099

Niklas Laxström <niklas.laxstrom <at> gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |niklas.laxstrom <at> gmail.com

--- Comment #1 from Niklas Laxström <niklas.laxstrom <at> gmail.com> 2012-07-01 08:11:11 UTC ---
+1 for this request. I even use only size of 2 myself.

--

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l <at> lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
bugzilla-daemon | 1 Jul 2012 14:04
Picon

[Bug 38099] in Gerrit make tab size 4 instead of 8

https://bugzilla.wikimedia.org/show_bug.cgi?id=38099

--- Comment #2 from Chad H. <innocentkiller <at> gmail.com> 2012-07-01 12:04:22 UTC ---
There's no way to configure this currently, please report upstream.

--

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
bugzilla-daemon | 1 Jul 2012 14:09
Picon

[Bug 38099] in Gerrit make tab size 4 instead of 8

https://bugzilla.wikimedia.org/show_bug.cgi?id=38099

Amir E. Aharoni <amir.aharoni <at> mail.huji.ac.il> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |INVALID

--- Comment #3 from Amir E. Aharoni <amir.aharoni <at> mail.huji.ac.il> 2012-07-01 12:09:33 UTC ---
I should have looked for it better: it can be changed in the diff preferences
and it sticks.

--

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
bugzilla-daemon | 1 Jul 2012 19:18
Picon

[Bug 38099] in Gerrit make tab size 4 instead of 8

https://bugzilla.wikimedia.org/show_bug.cgi?id=38099

Chad H. <innocentkiller <at> gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|INVALID                     |WORKSFORME

--

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

Gmane