headers
bugzilla-daemon | 1 Jul 2012 22:44
Picon

[Bug 38103] New: Broken link when the link contains a hash

https://bugzilla.wikimedia.org/show_bug.cgi?id=38103

       Web browser: ---
             Bug #: 38103
           Summary: Broken link when the link contains a hash
           Product: Wikimedia
           Version: unspecified
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: Unprioritized
         Component: Git/Gerrit
        AssignedTo: wikibugs-l <at> lists.wikimedia.org
        ReportedBy: liangent <at> gmail.com
                CC: innocentkiller <at> gmail.com, rlane32 <at> gmail.com
    Classification: Unclassified
   Mobile Platform: ---

See gerrit 13558.

In the mail I received it says:

Krinkle has posted comments on this change.

Change subject: Link to CREDITS file on message 'version-poweredby-others'
......................................................................

Patch Set 1:
(Continue reading)

Permalink | Reply |
headers
bugzilla-daemon | 1 Jul 2012 22:45
Picon

[Bug 38103] Broken link when the link contains a hash

https://bugzilla.wikimedia.org/show_bug.cgi?id=38103

Krinkle <krinklemail <at> gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |krinklemail <at> gmail.com
         Resolution|                            |DUPLICATE

--- Comment #1 from Krinkle <krinklemail <at> gmail.com> 2012-07-01 20:45:28 UTC ---

*** This bug has been marked as a duplicate of bug 33437 ***

--

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
Permalink | Reply |
headers
bugzilla-daemon | 1 Jul 2012 22:48
Picon

[Bug 38103] Broken link when the link contains a hash

https://bugzilla.wikimedia.org/show_bug.cgi?id=38103

--- Comment #2 from Krinkle <krinklemail <at> gmail.com> 2012-07-01 20:48:57 UTC ---

*** This bug has been marked as a duplicate of bug 17006 ***

--

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
Permalink | Reply |
headers
bugzilla-daemon | 1 Jul 2012 22:50
Picon

[Bug 38103] Broken link when the link contains a hash

https://bugzilla.wikimedia.org/show_bug.cgi?id=38103

Krinkle <krinklemail <at> gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|DUPLICATE                   |

--- Comment #3 from Krinkle <krinklemail <at> gmail.com> 2012-07-01 20:50:47 UTC ---
Un-duping. Title seems confusing, what is the bug here?

--

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
Permalink | Reply |
headers
bugzilla-daemon | 1 Jul 2012 22:54
Picon

[Bug 38103] Link broken in comment when link contains git hash

https://bugzilla.wikimedia.org/show_bug.cgi?id=38103

Krinkle <krinklemail <at> gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |DUPLICATE
            Summary|Broken link when the link   |Link broken in comment when
                   |contains a hash             |link contains git hash

--- Comment #4 from Krinkle <krinklemail <at> gmail.com> 2012-07-01 20:54:33 UTC ---
We introduced this ourselves with bug 36774, but due to a bug in gerrit it also
runs on hyperlinks. The other comment-link parsers don't interfere with each
other, but their linkifier is independent from this.

(Quote bug 36774 comment #5)
> [this] breaks links like
> 
> https://github.com/pediapress/mwlib/commit/4406d53b4c7dcd6cba8b7e5cf7076d08bf754f5c#docs/collection.rst
> 
> Filed http://code.google.com/p/gerrit/issues/detail?id=1451 upstream but in
> fact we should tweak the regular expression a bit. Maybe replace \\b with \\s+
> ?

*** This bug has been marked as a duplicate of bug 36774 ***

--

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
(Continue reading)

Permalink | Reply |
headers
bugzilla-daemon | 24 Apr 2013 19:52
Picon

[Bug 38103] Gerrit: Link broken in comment when link contains git hash

https://bugzilla.wikimedia.org/show_bug.cgi?id=38103

Krinkle <krinklemail <at> gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|DUPLICATE                   |---
            Summary|Link broken in comment when |Gerrit: Link broken in
                   |link contains git hash      |comment when link contains
                   |                            |git hash

--- Comment #5 from Krinkle <krinklemail <at> gmail.com> ---
Re-opening, this is broken again.

See https://gerrit.wikimedia.org/r/#/c/60681/:
> d1b4dcd6ac" target="_blank">https://github.com/joyent/node/commit/d1b4dcd6ac

Original text:
> https://github.com/joyent/node/commit/d1b4dcd6ac

--

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l <at> lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
(Continue reading)

Permalink | Reply |
headers
bugzilla-daemon | 24 Apr 2013 19:53
Picon

[Bug 38103] Gerrit: Links containing git hash are broken

https://bugzilla.wikimedia.org/show_bug.cgi?id=38103

Krinkle <krinklemail <at> gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Gerrit: Link broken in      |Gerrit: Links containing
                   |comment when link contains  |git hash are broken
                   |git hash                    |

--

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l <at> lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
Permalink | Reply |
headers
bugzilla-daemon | 26 Apr 2013 01:05
Picon

[Bug 38103] Gerrit: Links containing git hash are broken

https://bugzilla.wikimedia.org/show_bug.cgi?id=38103

--- Comment #6 from Krinkle <krinklemail <at> gmail.com> ---
Not just in commit message, in inline comments as well.

See
https://gerrit.wikimedia.org/r/#/c/58281/16/resources/jquery.chosen/chosen-sprite%25402x.png

> aa365247(v=vs.85).aspx" target="_blank">http://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).aspx

Original text:
> http://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).aspx

--

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l <at> lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
Permalink | Reply |

Gmane