Trevor Parscal (Code Review | 20 Aug 2012 19:01
Picon

[MediaWiki-commits] [Gerrit] Fix JS error about out-of-bounds selection setting - change (mediawiki...VisualEditor[master])

Trevor Parscal has submitted this change and it was merged.

Change subject: Fix JS error about out-of-bounds selection setting
......................................................................

Fix JS error about out-of-bounds selection setting

Don't try to restore the selection after the removal part of
onContentChange, because the removal may have caused that selection to
now be out of bounds. We also don't need to set the selection there at
all, because the insertion does it anyway (where it is safe).

Change-Id: I7b340b18dd8efc77d1df78007161720c29866cb6
---
M modules/ve/ce/ve.ce.Surface.js
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Trevor Parscal: Verified; Looks good to me, approved

--
To view, visit https://gerrit.wikimedia.org/r/20507
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7b340b18dd8efc77d1df78007161720c29866cb6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <roan.kattouw <at> gmail.com>
(Continue reading)


Gmane