headers
Daniel Barrett | 13 May 22:41
Favicon

Linebreaks in the edit toolbar?

In our wiki, we have many toolbar buttons on the edit page, so we want to split them into multiple lines at
designated spots. My hacked solution is below -- is there a better way?

To implement this, I hacked function mwInsertEditButton in skins/common/wikibits.js, so an imageFile
value of "<br>" causes a real <br> to be inserted into the toolbar.  I added this code as the first lines of
mwInsertEditButton :

        if (item.imageFile == '<br>') {
                parent.appendChild(document.createElement("br"));
                return true;
        }

Is there a better way to accomplish this task without modifying core code?

Thanks,
DanB
Permalink | Reply |
headers
Darren VanBuren | 14 May 17:50
Picon
Gravatar

Re: Linebreaks in the edit toolbar?

That looks like it's an okay mod. How much have you tested it? You  
could check this into Subversion, so future versions would have it.
I will create a patch for you incase you don't have the subversion  
trunk version of MediaWiki.

On May 13, 2008, at 1:43 PM, Daniel Barrett wrote:

> In our wiki, we have many toolbar buttons on the edit page, so we  
> want to split them into multiple lines at designated spots. My  
> hacked solution is below -- is there a better way?
>
> To implement this, I hacked function mwInsertEditButton in skins/ 
> common/wikibits.js, so an imageFile value of "<br>" causes a real  
> <br> to be inserted into the toolbar.  I added this code as the  
> first lines of mwInsertEditButton :
>
>        if (item.imageFile == '<br>') {
>                parent.appendChild(document.createElement("br"));
>                return true;
>        }
>
> Is there a better way to accomplish this task without modifying core  
> code?
>
> Thanks,
> DanB
>
>
> _______________________________________________
> MediaWiki-l mailing list
(Continue reading)

Permalink | Reply |

Gmane