a list for submitting patches to the Cygwin DLL and the other components of the "winsup" directory

Thomas Wolff | 22 Apr 2012 21:07

[PATCH] Extended mouse coordinates

This patch replaces my previous proposal 
(http://cygwin.com/ml/cygwin-patches/2012-q2/msg00005.html) with two 
modifications:

  * Fixed a bug that suppressed mouse reporting at large coordinates (in
    all modes actually:-\ )
  * Added mouse mode 1005 (total of 3 three new modes, so all reporting
    modes run by current terminal emulators would be implemented)

I would appreciate the patch to be applied this time, planned to be my 
last mouse patch :)

Kind regards,
Thomas

2012-04-03  Thomas Wolff  <towo <at> towo.net>

	* fhandler.h (class dev_console): Two flags for extended mouse modes.
	* fhandler_console.cc (fhandler_console::read): Implemented 
	extended mouse modes 1015 (urxvt, mintty, xterm) and 1006 (xterm).
	Not implemented extended mouse mode 1005 (xterm, mintty).
	Supporting mouse coordinates greater than 222 (each axis).
	Also: two { wrap formatting consistency fixes.
	(fhandler_console::char_command) Initialization of enhanced 
	mouse reporting modes.

diff -rup sav/fhandler.h ./fhandler.h

(Continue reading)

Corinna Vinschen | 24 Apr 2012 16:44

Re: [PATCH] Extended mouse coordinates

On Apr 22 21:07, Thomas Wolff wrote:
> This patch replaces my previous proposal
> (http://cygwin.com/ml/cygwin-patches/2012-q2/msg00005.html) with two
> modifications:
> 
>  * Fixed a bug that suppressed mouse reporting at large coordinates (in
>    all modes actually:-\ )
>  * Added mouse mode 1005 (total of 3 three new modes, so all reporting
>    modes run by current terminal emulators would be implemented)
> 
> I would appreciate the patch to be applied this time, planned to be
> my last mouse patch :)
> 
> Kind regards,
> Thomas

> 2012-04-03  Thomas Wolff  <towo <at> towo.net>
> 
> 	* fhandler.h (class dev_console): Two flags for extended mouse modes.
> 	* fhandler_console.cc (fhandler_console::read): Implemented 
> 	extended mouse modes 1015 (urxvt, mintty, xterm) and 1006 (xterm).
> 	Not implemented extended mouse mode 1005 (xterm, mintty).
> 	Supporting mouse coordinates greater than 222 (each axis).
> 	Also: two { wrap formatting consistency fixes.
> 	(fhandler_console::char_command) Initialization of enhanced 
> 	mouse reporting modes.
> 

Patch applied with changes.  Please use __small_sprintf rather than
sprintf.  I also changed the CHangeLog entry slightly.  Keep it short

(Continue reading)

Thomas Wolff | 24 Apr 2012 21:35

Re: [PATCH] Extended mouse coordinates

Am 24.04.2012 16:44, schrieb Corinna Vinschen:
> On Apr 22 21:07, Thomas Wolff wrote:
>> This patch replaces my previous proposal
>> (http://cygwin.com/ml/cygwin-patches/2012-q2/msg00005.html) with two
>> modifications:
>>
>>   * Fixed a bug that suppressed mouse reporting at large coordinates (in
>>     all modes actually:-\ )
>>   * Added mouse mode 1005 (total of 3 three new modes, so all reporting
>>     modes run by current terminal emulators would be implemented)
>>
>> I would appreciate the patch to be applied this time, planned to be
>> my last mouse patch :)
>>
>> Kind regards,
>> Thomas
>> 2012-04-03  Thomas Wolff<towo <at> towo.net>
>>
>> 	* fhandler.h (class dev_console): Two flags for extended mouse modes.
>> 	* fhandler_console.cc (fhandler_console::read): Implemented
>> 	extended mouse modes 1015 (urxvt, mintty, xterm) and 1006 (xterm).
>> 	Not implemented extended mouse mode 1005 (xterm, mintty).
>> 	Supporting mouse coordinates greater than 222 (each axis).
>> 	Also: two { wrap formatting consistency fixes.
>> 	(fhandler_console::char_command) Initialization of enhanced
>> 	mouse reporting modes.
>>
> Patch applied with changes.  Please use __small_sprintf rather than
> sprintf.  I also changed the CHangeLog entry slightly.  Keep it short
> and in present tense.

(Continue reading)

Corinna Vinschen | 24 Apr 2012 21:45

Re: [PATCH] Extended mouse coordinates

On Apr 24 21:35, Thomas Wolff wrote:
> Am 24.04.2012 16:44, schrieb Corinna Vinschen:
> >On Apr 22 21:07, Thomas Wolff wrote:
> >>This patch replaces my previous proposal
> >>(http://cygwin.com/ml/cygwin-patches/2012-q2/msg00005.html) with two
> >>modifications:
> >>
> >>  * Fixed a bug that suppressed mouse reporting at large coordinates (in
> >>    all modes actually:-\ )
> >>  * Added mouse mode 1005 (total of 3 three new modes, so all reporting
> >>    modes run by current terminal emulators would be implemented)
> >>
> >>I would appreciate the patch to be applied this time, planned to be
> >>my last mouse patch :)
> >>
> >>Kind regards,
> >>Thomas
> >>2012-04-03  Thomas Wolff<towo <at> towo.net>
> >>
> >>	* fhandler.h (class dev_console): Two flags for extended mouse modes.
> >>	* fhandler_console.cc (fhandler_console::read): Implemented
> >>	extended mouse modes 1015 (urxvt, mintty, xterm) and 1006 (xterm).
> >>	Not implemented extended mouse mode 1005 (xterm, mintty).
> >>	Supporting mouse coordinates greater than 222 (each axis).
> >>	Also: two { wrap formatting consistency fixes.
> >>	(fhandler_console::char_command) Initialization of enhanced
> >>	mouse reporting modes.
> >>
> >Patch applied with changes.  Please use __small_sprintf rather than
> >sprintf.  I also changed the CHangeLog entry slightly.  Keep it short

(Continue reading)

Corinna Vinschen | 24 Apr 2012 21:47

Re: [PATCH] Extended mouse coordinates

On Apr 24 21:45, Corinna Vinschen wrote:
> On Apr 24 21:35, Thomas Wolff wrote:
> > Am 24.04.2012 16:44, schrieb Corinna Vinschen:
> > >On Apr 22 21:07, Thomas Wolff wrote:
> > >>This patch replaces my previous proposal
> > >>(http://cygwin.com/ml/cygwin-patches/2012-q2/msg00005.html) with two
> > >>modifications:
> > >>
> > >>  * Fixed a bug that suppressed mouse reporting at large coordinates (in
> > >>    all modes actually:-\ )
> > >>  * Added mouse mode 1005 (total of 3 three new modes, so all reporting
> > >>    modes run by current terminal emulators would be implemented)
> > >>
> > >>I would appreciate the patch to be applied this time, planned to be
> > >>my last mouse patch :)
> > >>
> > >>Kind regards,
> > >>Thomas
> > >>2012-04-03  Thomas Wolff<towo <at> towo.net>
> > >>
> > >>	* fhandler.h (class dev_console): Two flags for extended mouse modes.
> > >>	* fhandler_console.cc (fhandler_console::read): Implemented
> > >>	extended mouse modes 1015 (urxvt, mintty, xterm) and 1006 (xterm).
> > >>	Not implemented extended mouse mode 1005 (xterm, mintty).
> > >>	Supporting mouse coordinates greater than 222 (each axis).
> > >>	Also: two { wrap formatting consistency fixes.
> > >>	(fhandler_console::char_command) Initialization of enhanced
> > >>	mouse reporting modes.
> > >>
> > >Patch applied with changes.  Please use __small_sprintf rather than

(Continue reading)

Thomas Wolff | 24 Apr 2012 22:00

Re: [PATCH] Extended mouse coordinates

Am 24.04.2012 21:47, schrieb Corinna Vinschen:
> On Apr 24 21:45, Corinna Vinschen wrote:
>> On Apr 24 21:35, Thomas Wolff wrote:
>>> Am 24.04.2012 16:44, schrieb Corinna Vinschen:
>>>> On Apr 22 21:07, Thomas Wolff wrote:
>>>>> This patch replaces my previous proposal
>>>>> (http://cygwin.com/ml/cygwin-patches/2012-q2/msg00005.html) with two
>>>>> modifications:
>>>>>
>>>>>   * Fixed a bug that suppressed mouse reporting at large coordinates (in
>>>>>     all modes actually:-\ )
>>>>>   * Added mouse mode 1005 (total of 3 three new modes, so all reporting
>>>>>     modes run by current terminal emulators would be implemented)
>>>>>
>>>>> I would appreciate the patch to be applied this time, planned to be
>>>>> my last mouse patch :)
>>>>>
>>>>> Kind regards,
>>>>> Thomas
>>>>> 2012-04-03  Thomas Wolff<towo <at> towo.net>
>>>>>
>>>>> 	* fhandler.h (class dev_console): Two flags for extended mouse modes.
>>>>> 	* fhandler_console.cc (fhandler_console::read): Implemented
>>>>> 	extended mouse modes 1015 (urxvt, mintty, xterm) and 1006 (xterm).
>>>>> 	Not implemented extended mouse mode 1005 (xterm, mintty).
>>>>> 	Supporting mouse coordinates greater than 222 (each axis).
>>>>> 	Also: two { wrap formatting consistency fixes.
>>>>> 	(fhandler_console::char_command) Initialization of enhanced
>>>>> 	mouse reporting modes.
>>>>>

(Continue reading)

Corinna Vinschen | 24 Apr 2012 22:22

Re: [PATCH] Extended mouse coordinates

On Apr 24 22:00, Thomas Wolff wrote:
> Am 24.04.2012 21:47, schrieb Corinna Vinschen:
> >On Apr 24 21:45, Corinna Vinschen wrote:
> >>That was exactly the patch I applied.  I only chnaged the formatting
> >>and changed sprintf to  __small_sprintf.
> >...and as far as quoting goes, the above is the ChangeLog you provided
> >with your updated patch.
> Sh.. I see. My deep apologies, I must have been confused. Here is
> the actual updated patch which should be used instead.
> Sorry for the trouble.
> Thomas

> 2012-04-20  Thomas Wolff  <towo <at> towo.net>
> 
> 	* fhandler.h (class dev_console): Flags for extended mouse modes.
> 	* fhandler_console.cc: Supporting mouse coordinates greater than 222.
> 	(fhandler_console::read) Implemented extended mouse modes 
> 	1015 (urxvt, mintty, xterm), 1006 (xterm), and 1005 (xterm, mintty).
> 	Also: two { wrap formatting consistency fixes.
> 	(fhandler_console::mouse_aware) Removed limitation of not sending 
> 	anything at exceeded coordinates; sending 0 byte instead (xterm).
> 	(fhandler_console::char_command) Initialization of enhanced 
> 	mouse reporting modes.
> 

Please recreate the patch against current CVS.  And please use
__small_sprintf instead of sprintf.

Corinna

(Continue reading)

Thomas Wolff | 24 Apr 2012 23:58

Re: [PATCH] Extended mouse coordinates

Am 24.04.2012 22:22, schrieb Corinna Vinschen:
> On Apr 24 22:00, Thomas Wolff wrote:
>> Am 24.04.2012 21:47, schrieb Corinna Vinschen:
>>> On Apr 24 21:45, Corinna Vinschen wrote:
>>>> That was exactly the patch I applied.  I only chnaged the formatting
>>>> and changed sprintf to  __small_sprintf.
>>> ...and as far as quoting goes, the above is the ChangeLog you provided
>>> with your updated patch.
>> Sh.. I see. My deep apologies, I must have been confused. Here is
>> the actual updated patch which should be used instead.
>> Sorry for the trouble.
>> Thomas
>> 2012-04-20  Thomas Wolff<towo <at> towo.net>
>>
>> 	* fhandler.h (class dev_console): Flags for extended mouse modes.
>> 	* fhandler_console.cc: Supporting mouse coordinates greater than 222.
>> 	(fhandler_console::read) Implemented extended mouse modes
>> 	1015 (urxvt, mintty, xterm), 1006 (xterm), and 1005 (xterm, mintty).
>> 	Also: two { wrap formatting consistency fixes.
>> 	(fhandler_console::mouse_aware) Removed limitation of not sending
>> 	anything at exceeded coordinates; sending 0 byte instead (xterm).
>> 	(fhandler_console::char_command) Initialization of enhanced
>> 	mouse reporting modes.
>>
> Please recreate the patch against current CVS.  And please use
> __small_sprintf instead of sprintf.
>
Here's the missing patch and changelog. Sorry again for previous mix-up.
Thomas

(Continue reading)

Corinna Vinschen | 25 Apr 2012 10:22

Re: [PATCH] Extended mouse coordinates

On Apr 24 23:58, Thomas Wolff wrote:
> Am 24.04.2012 22:22, schrieb Corinna Vinschen:
> >On Apr 24 22:00, Thomas Wolff wrote:
> >>Am 24.04.2012 21:47, schrieb Corinna Vinschen:
> >>>On Apr 24 21:45, Corinna Vinschen wrote:
> >>>>That was exactly the patch I applied.  I only chnaged the formatting
> >>>>and changed sprintf to  __small_sprintf.
> >>>...and as far as quoting goes, the above is the ChangeLog you provided
> >>>with your updated patch.
> >>Sh.. I see. My deep apologies, I must have been confused. Here is
> >>the actual updated patch which should be used instead.
> >>Sorry for the trouble.
> >>Thomas
> >>2012-04-20  Thomas Wolff<towo <at> towo.net>
> >>
> >>	* fhandler.h (class dev_console): Flags for extended mouse modes.
> >>	* fhandler_console.cc: Supporting mouse coordinates greater than 222.
> >>	(fhandler_console::read) Implemented extended mouse modes
> >>	1015 (urxvt, mintty, xterm), 1006 (xterm), and 1005 (xterm, mintty).
> >>	Also: two { wrap formatting consistency fixes.
> >>	(fhandler_console::mouse_aware) Removed limitation of not sending
> >>	anything at exceeded coordinates; sending 0 byte instead (xterm).
> >>	(fhandler_console::char_command) Initialization of enhanced
> >>	mouse reporting modes.
> >>
> >Please recreate the patch against current CVS.  And please use
> >__small_sprintf instead of sprintf.
> >
> Here's the missing patch and changelog. Sorry again for previous mix-up.
> Thomas

(Continue reading)

Return

Return to gmane.os.cygwin.patches.

Project Web Page

a list for submitting patches to the Cygwin DLL and the other components of the "winsup" directory

Search Archive

Language

Change language

Options

Current view: Threads only / Showing only 20 lines / Not hiding cited text.
Change to All messages, whole messages, or hide cited text.

Post a message
NNTP Newsgroup
Classic Gmane web interface
XML

XML

RSS Feed
List Information

About Gmane