Li-Wen Hsu | 7 Sep 2011 08:02
Picon
Favicon

Re: Update of devel/py-twisted to 11.0.0

Hello Sofian,

Thanks for working on this, python <at>  definitely need more power!

Please see the reply inline.

On Wed, Sep 7, 2011 at 04:57, Sofian Brabez <sbz <at> freebsd.org> wrote:
> Hi python <at> ,
>
> This afternoon, I've merged my initial update to the twisted related ports with
> the patch of lwhsu <at>  [1]. My patch is there [2].
>
> My patch make happy portlint, add LICENSE in each twisted ports and add new
> OPTIONS for twistedPair port.

And please also add pair_DEPENDS in bsd.python.mk, that is around line 641.

> Please lwhsu <at>  notice than all twisted ports are sharing the
> ${PYTHON_SITELIBDIR}/twisted/plugins folder that's why I've replaced the  <at> dirrm
> by a  <at> dirrmtry in pkg-plist.

Thanks for reminding me this, I think we have

     <at> dirrm %%PYTHON_SITELIBDIR%%/twisted/plugins in

in devel/py-twistedCore/pkg-plist, and all other twisted ports depends
on twistedCore, so we probably don't need to have  <at> dirrm nor  <at> dirrmtry
in other ports.
They sneaked in my patch because I forget this, so just removing them
is fine. (I was planning getting maintainer's approval on general idea
(Continue reading)

Sofian Brabez | 7 Sep 2011 13:02
Picon
Favicon

Re: Update of devel/py-twisted to 11.0.0

Hi python <at> ,

On Wed, Sep 07, 2011 at 02:02:43PM +0800, Li-Wen Hsu wrote:
> Hello Sofian,
> 
> Thanks for working on this, python <at>  definitely need more power!
> 
> Please see the reply inline.
> 
> On Wed, Sep 7, 2011 at 04:57, Sofian Brabez <sbz <at> freebsd.org> wrote:
> > Hi python <at> ,
> >
> > This afternoon, I've merged my initial update to the twisted related ports with
> > the patch of lwhsu <at>  [1]. My patch is there [2].
> >
> > My patch make happy portlint, add LICENSE in each twisted ports and add new
> > OPTIONS for twistedPair port.
> 
> And please also add pair_DEPENDS in bsd.python.mk, that is around line 641.

Done
> 
> > Please lwhsu <at>  notice than all twisted ports are sharing the
> > ${PYTHON_SITELIBDIR}/twisted/plugins folder that's why I've replaced the  <at> dirrm
> > by a  <at> dirrmtry in pkg-plist.
> 
> Thanks for reminding me this, I think we have
> 
>      <at> dirrm %%PYTHON_SITELIBDIR%%/twisted/plugins in
> 
(Continue reading)

Li-Wen Hsu | 7 Sep 2011 11:10
Picon
Favicon

Re: Update of devel/py-twisted to 11.0.0

Looks good, please go ahead commit and close the related PRs.

Thanks for your help!

On Wed, Sep 7, 2011 at 19:02, Sofian Brabez <sbz <at> freebsd.org> wrote:
> Hi python <at> ,
>
> On Wed, Sep 07, 2011 at 02:02:43PM +0800, Li-Wen Hsu wrote:
>> Hello Sofian,
>>
>> Thanks for working on this, python <at>  definitely need more power!
>>
>> Please see the reply inline.
>>
>> On Wed, Sep 7, 2011 at 04:57, Sofian Brabez <sbz <at> freebsd.org> wrote:
>> > Hi python <at> ,
>> >
>> > This afternoon, I've merged my initial update to the twisted related ports with
>> > the patch of lwhsu <at>  [1]. My patch is there [2].
>> >
>> > My patch make happy portlint, add LICENSE in each twisted ports and add new
>> > OPTIONS for twistedPair port.
>>
>> And please also add pair_DEPENDS in bsd.python.mk, that is around line 641.
>
> Done
>>
>> > Please lwhsu <at>  notice than all twisted ports are sharing the
>> > ${PYTHON_SITELIBDIR}/twisted/plugins folder that's why I've replaced the  <at> dirrm
>> > by a  <at> dirrmtry in pkg-plist.
(Continue reading)


Gmane