Stephen Borrill | 3 Aug 2012 19:03
Picon
Favicon

mfi(4) Thunderbolt support?

Anyone working on Thunderbolt support for mfi(4)?

This is required for (shamelessly nicked from FreeBSD):
Dell PERC H810 Adapter
Dell PERC H710 Embedded
Dell PERC H710P Adapter
Dell PERC H710P Mini (blades)
Dell PERC H710P Mini (monolithics)
Dell PERC H710 Adapter
Dell PERC H710 Mini (blades)
Dell PERC H710 Mini (monolithics)
Intel (R) RAID Controller RS25DB080
Intel (R) RAID Controller RS25NB008

I can add IBM ServeRAID M5110 to that list too

--

-- 
Stephen

Manuel Bouyer | 4 Aug 2012 21:40

Re: mfi(4) Thunderbolt support?

On Fri, Aug 03, 2012 at 06:03:33PM +0100, Stephen Borrill wrote:
> Anyone working on Thunderbolt support for mfi(4)?
> 
> This is required for (shamelessly nicked from FreeBSD):
> Dell PERC H810 Adapter
> Dell PERC H710 Embedded
> Dell PERC H710P Adapter
> Dell PERC H710P Mini (blades)
> Dell PERC H710P Mini (monolithics)
> Dell PERC H710 Adapter
> Dell PERC H710 Mini (blades)
> Dell PERC H710 Mini (monolithics)
> Intel (R) RAID Controller RS25DB080
> Intel (R) RAID Controller RS25NB008
> 
> I can add IBM ServeRAID M5110 to that list too

Hello,
did you start looking at this ? I have a LSI MEGARAID 926x which is the same
controller as the above list.
It seems this use a new command format, so adding support is not so
straitforward ...

--

-- 
Manuel Bouyer <bouyer <at> antioche.eu.org>
     NetBSD: 26 ans d'experience feront toujours la difference
--

Stephen Borrill | 6 Aug 2012 09:50
Picon
Favicon

Re: mfi(4) Thunderbolt support?

On Sat, 4 Aug 2012, Manuel Bouyer wrote:
> On Fri, Aug 03, 2012 at 06:03:33PM +0100, Stephen Borrill wrote:
>> Anyone working on Thunderbolt support for mfi(4)?
>>
>> This is required for (shamelessly nicked from FreeBSD):
>> Dell PERC H810 Adapter
>> Dell PERC H710 Embedded
>> Dell PERC H710P Adapter
>> Dell PERC H710P Mini (blades)
>> Dell PERC H710P Mini (monolithics)
>> Dell PERC H710 Adapter
>> Dell PERC H710 Mini (blades)
>> Dell PERC H710 Mini (monolithics)
>> Intel (R) RAID Controller RS25DB080
>> Intel (R) RAID Controller RS25NB008
>>
>> I can add IBM ServeRAID M5110 to that list too
>
> Hello,
> did you start looking at this ? I have a LSI MEGARAID 926x which is the same
> controller as the above list.
> It seems this use a new command format, so adding support is not so
> straitforward ...

Well, I looked as far as:
http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/dev/mfi/mfi_tbolt.c?only_with_tag=MAIN

So not completely straightforward, but not too tough. I'll take a look 
this week if no-one gets to it first.

(Continue reading)

Manuel Bouyer | 6 Aug 2012 10:01

Re: mfi(4) Thunderbolt support?

On Mon, Aug 06, 2012 at 08:50:57AM +0100, Stephen Borrill wrote:
> On Sat, 4 Aug 2012, Manuel Bouyer wrote:
> >On Fri, Aug 03, 2012 at 06:03:33PM +0100, Stephen Borrill wrote:
> >>Anyone working on Thunderbolt support for mfi(4)?
> >>
> >>This is required for (shamelessly nicked from FreeBSD):
> >>Dell PERC H810 Adapter
> >>Dell PERC H710 Embedded
> >>Dell PERC H710P Adapter
> >>Dell PERC H710P Mini (blades)
> >>Dell PERC H710P Mini (monolithics)
> >>Dell PERC H710 Adapter
> >>Dell PERC H710 Mini (blades)
> >>Dell PERC H710 Mini (monolithics)
> >>Intel (R) RAID Controller RS25DB080
> >>Intel (R) RAID Controller RS25NB008
> >>
> >>I can add IBM ServeRAID M5110 to that list too
> >
> >Hello,
> >did you start looking at this ? I have a LSI MEGARAID 926x which is the same
> >controller as the above list.
> >It seems this use a new command format, so adding support is not so
> >straitforward ...
> 
> Well, I looked as far as:
> http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/dev/mfi/mfi_tbolt.c?only_with_tag=MAIN
> 
> So not completely straightforward, but not too tough. I'll take a
> look this week if no-one gets to it first.
(Continue reading)

Manuel Bouyer | 23 Aug 2012 12:02

Re: mfi(4) Thunderbolt support?

On Mon, Aug 06, 2012 at 10:01:17AM +0200, Manuel Bouyer wrote:
> I started working on it. Hopefully I'll have something working in
> the next few days.

Hello,
I commited support for newer controllers based on the LSI SAS2208
to HEAD.

--

-- 
Manuel Bouyer <bouyer <at> antioche.eu.org>
     NetBSD: 26 ans d'experience feront toujours la difference
--

Stephen Borrill | 23 Aug 2012 13:08
Picon
Favicon

Re: mfi(4) Thunderbolt support?

On Thu, 23 Aug 2012, Manuel Bouyer wrote:
> On Mon, Aug 06, 2012 at 10:01:17AM +0200, Manuel Bouyer wrote:
>> I started working on it. Hopefully I'll have something working in
>> the next few days.
>
> Hello,
> I commited support for newer controllers based on the LSI SAS2208
> to HEAD.

Any chance of a patch to netbsd-6 (to go in after the 6.0 release).

--

-- 
Stephen

Manuel Bouyer | 23 Aug 2012 13:12

Re: mfi(4) Thunderbolt support?

On Thu, Aug 23, 2012 at 12:08:14PM +0100, Stephen Borrill wrote:
> On Thu, 23 Aug 2012, Manuel Bouyer wrote:
> >On Mon, Aug 06, 2012 at 10:01:17AM +0200, Manuel Bouyer wrote:
> >>I started working on it. Hopefully I'll have something working in
> >>the next few days.
> >
> >Hello,
> >I commited support for newer controllers based on the LSI SAS2208
> >to HEAD.
> 
> Any chance of a patch to netbsd-6 (to go in after the 6.0 release).

Sure. just copy sys/dev/*/mfi* to a netbsd-6 tree, it works
(this is how I tested on the perc5).

--

-- 
Manuel Bouyer <bouyer <at> antioche.eu.org>
     NetBSD: 26 ans d'experience feront toujours la difference
--

Havard Eidnes | 23 Aug 2012 14:01
Picon

Re: mfi(4) Thunderbolt support?

>> Any chance of a patch to netbsd-6 (to go in after the 6.0 release).
>
> Sure. just copy sys/dev/*/mfi* to a netbsd-6 tree, it works
> (this is how I tested on the perc5).

Not quite, you also need updated pci/pcidevs* files.

And then I still get build errors:

cc1: warnings being treated as errors
/usr/src/sys/dev/ic/mfi.c: In function 'mfi_tbolt_init_desc_pool':
/usr/src/sys/dev/ic/mfi.c:2715:15: error: unused variable 'tbolt_contg_length'

The definition maybe needs wrapping with #ifdef DIAGNOSTIC, since
the only use is in a KASSERT?

And with that, it built ... and worked, at least with my SAS
9260-8i (using SATA disks).

Regards,

- HÃ¥vard

Manuel Bouyer | 23 Aug 2012 14:25

Re: mfi(4) Thunderbolt support?

On Thu, Aug 23, 2012 at 02:01:31PM +0200, Havard Eidnes wrote:
> >> Any chance of a patch to netbsd-6 (to go in after the 6.0 release).
> >
> > Sure. just copy sys/dev/*/mfi* to a netbsd-6 tree, it works
> > (this is how I tested on the perc5).
> 
> Not quite, you also need updated pci/pcidevs* files.

Right, you need the MEGARAID_2208 entry. I forgot I had a local patch for
this.

> 
> And then I still get build errors:
> 
> cc1: warnings being treated as errors
> /usr/src/sys/dev/ic/mfi.c: In function 'mfi_tbolt_init_desc_pool':
> /usr/src/sys/dev/ic/mfi.c:2715:15: error: unused variable 'tbolt_contg_length'
> 
> The definition maybe needs wrapping with #ifdef DIAGNOSTIC, since
> the only use is in a KASSERT?

I fixed this, thanks (it's easier to just remove the variable :)

--

-- 
Manuel Bouyer <bouyer <at> antioche.eu.org>
     NetBSD: 26 ans d'experience feront toujours la difference
--

Mark Davies | 18 Oct 2012 01:08
Picon
Picon

Re: mfi(4) Thunderbolt support?

On Fri, 24 Aug 2012, Manuel Bouyer wrote:
> On Thu, Aug 23, 2012 at 02:01:31PM +0200, Havard Eidnes wrote:
> > >> Any chance of a patch to netbsd-6 (to go in after the 6.0
> > >> release).
> > > 
> > > Sure. just copy sys/dev/*/mfi* to a netbsd-6 tree, it works
> > > (this is how I tested on the perc5).
> > 
> > Not quite, you also need updated pci/pcidevs* files.
> 
> Right, you need the MEGARAID_2208 entry. I forgot I had a local
> patch for this.
> 
> > And then I still get build errors:
> > 
> > cc1: warnings being treated as errors
> > /usr/src/sys/dev/ic/mfi.c: In function
> > 'mfi_tbolt_init_desc_pool': /usr/src/sys/dev/ic/mfi.c:2715:15:
> > error: unused variable 'tbolt_contg_length'
> > 
> > The definition maybe needs wrapping with #ifdef DIAGNOSTIC, since
> > the only use is in a KASSERT?
> 
> I fixed this, thanks (it's easier to just remove the variable :)

Now that 6.0_STABLE is getting pullups applied will anyone submit a 
pullup for this?

cheers
mark
(Continue reading)

Manuel Bouyer | 18 Oct 2012 10:29

Re: mfi(4) Thunderbolt support?

On Thu, Oct 18, 2012 at 12:08:35PM +1300, Mark Davies wrote:
> Now that 6.0_STABLE is getting pullups applied will anyone submit a 
> pullup for this?

It's on my todo list. I already have it running in 6.0_RC2 on a
server, so I have a patch that is tested :)
i just need to collect the commit messages and check that they
apply cleanly.

--

-- 
Manuel Bouyer <bouyer <at> antioche.eu.org>
     NetBSD: 26 ans d'experience feront toujours la difference
--

Stephen Borrill | 23 Aug 2012 13:15
Picon
Favicon

Re: mfi(4) Thunderbolt support?

On Thu, 23 Aug 2012, Manuel Bouyer wrote:
> On Thu, Aug 23, 2012 at 12:08:14PM +0100, Stephen Borrill wrote:
>> On Thu, 23 Aug 2012, Manuel Bouyer wrote:
>>> On Mon, Aug 06, 2012 at 10:01:17AM +0200, Manuel Bouyer wrote:
>>>> I started working on it. Hopefully I'll have something working in
>>>> the next few days.
>>>
>>> Hello,
>>> I commited support for newer controllers based on the LSI SAS2208
>>> to HEAD.
>>
>> Any chance of a patch to netbsd-6 (to go in after the 6.0 release).
>
> Sure. just copy sys/dev/*/mfi* to a netbsd-6 tree, it works
> (this is how I tested on the perc5).

Don't need the clamping on maximum concurrent commands stuff 
(netbsd-6 ticket #523)?

--

-- 
Stephen

Manuel Bouyer | 23 Aug 2012 13:45

Re: mfi(4) Thunderbolt support?

On Thu, Aug 23, 2012 at 12:15:56PM +0100, Stephen Borrill wrote:
> On Thu, 23 Aug 2012, Manuel Bouyer wrote:
> >On Thu, Aug 23, 2012 at 12:08:14PM +0100, Stephen Borrill wrote:
> >>On Thu, 23 Aug 2012, Manuel Bouyer wrote:
> >>>On Mon, Aug 06, 2012 at 10:01:17AM +0200, Manuel Bouyer wrote:
> >>>>I started working on it. Hopefully I'll have something working in
> >>>>the next few days.
> >>>
> >>>Hello,
> >>>I commited support for newer controllers based on the LSI SAS2208
> >>>to HEAD.
> >>
> >>Any chance of a patch to netbsd-6 (to go in after the 6.0 release).
> >
> >Sure. just copy sys/dev/*/mfi* to a netbsd-6 tree, it works
> >(this is how I tested on the perc5).
> 
> Don't need the clamping on maximum concurrent commands stuff
> (netbsd-6 ticket #523)?

yes, this is needed. 

--

-- 
Manuel Bouyer <bouyer <at> antioche.eu.org>
     NetBSD: 26 ans d'experience feront toujours la difference
--


Gmane