Discussion of general kernel technical issues

KIYOHARA Takashi | 1 Aug 2012 14:43

malo <at> pci vs malo <at> pcmcia

Hi! all,

I have a 'I-O DATA WN-G54/CF'.  And some on-board 88W8686 has on
pcmcia-bus of Gumstix.
I think, malo <at> pcmcia and malo <at> pci is all different.  These drivers
can't merge maybe.

http://www.openbsd.org/cgi-bin/man.cgi?query=malo&apropos=0&sektion=0&manpath=OpenBSD+Current&arch=i386&format=html

Shall I commit to tree the source for malo <at> pcmcia?
If 'yes' then I will try to verify next week end.  

Thanks,
--
kiyohara

--- if_malo_pcmcia.c.orig	1970-01-01 09:00:00.000000000 +0900
+++ if_malo_pcmcia.c	2012-08-01 13:03:31.000000000 +0900
 <at>  <at>  -0,0 +1,2154  <at>  <at> 
+/*	$NetBSD$	*/
+/*      $OpenBSD: if_malo.c,v 1.65 2009/03/29 21:53:53 sthen Exp $ */
+
+/*
+ * Copyright (c) 2007 Marcus Glocker <mglocker <at> openbsd.org>
+ *
+ * Permission to use, copy, modify, and distribute this software for any
+ * purpose with or without fee is hereby granted, provided that the above
+ * copyright notice and this permission notice appear in all copies.
+ *

(Continue reading)

headers

Arnaud Degroote | 3 Aug 2012 10:49

Re: malo <at> pci vs malo <at> pcmcia

On 01/Aug - 21:43, KIYOHARA Takashi wrote:
> Hi! all,
> 
> 
> I have a 'I-O DATA WN-G54/CF'.  And some on-board 88W8686 has on
> pcmcia-bus of Gumstix.
> I think, malo <at> pcmcia and malo <at> pci is all different.  These drivers
> can't merge maybe.

From a quick review, the driver seems quite different, and it is
probably why they are not merged in OpenBSD.
> 
> http://www.openbsd.org/cgi-bin/man.cgi?query=malo&apropos=0&sektion=0&manpath=OpenBSD+Current&arch=i386&format=html
> 
> 
> Shall I commit to tree the source for malo <at> pcmcia?
> If 'yes' then I will try to verify next week end.  :-)

I think it would be nice to have the support for malo <at> pcmcia too in
NetBSD. 

> 
> Thanks,
> --
> kiyohara

> --- if_malo_pcmcia.c.orig	1970-01-01 09:00:00.000000000 +0900
> +++ if_malo_pcmcia.c	2012-08-01 13:03:31.000000000 +0900
>  <at>  <at>  -0,0 +1,2154  <at>  <at> 
> +/*	$NetBSD$	*/

(Continue reading)

headers

Christos Zoulas | 3 Aug 2012 13:02

Re: malo <at> pci vs malo <at> pcmcia

In article <20120803084934.GA3362 <at> bugfree>,
Arnaud Degroote  <arnaud.degroote <at> laas.fr> wrote:
>-=-=-=-=-=-
>
>On 01/Aug - 21:43, KIYOHARA Takashi wrote:
>> Hi! all,
>> 
>> 
>> I have a 'I-O DATA WN-G54/CF'.  And some on-board 88W8686 has on
>> pcmcia-bus of Gumstix.
>> I think, malo <at> pcmcia and malo <at> pci is all different.  These drivers
>> can't merge maybe.
>
>From a quick review, the driver seems quite different, and it is
>probably why they are not merged in OpenBSD.
>> 
>>
>http://www.openbsd.org/cgi-bin/man.cgi?query=malo&apropos=0&sektion=0&manpath=OpenBSD+Current&arch=i386&format=html
>> 
>> 
>> Shall I commit to tree the source for malo <at> pcmcia?
>> If 'yes' then I will try to verify next week end.  
>
>I think it would be nice to have the support for malo <at> pcmcia too in
>NetBSD. 
>

There is not much pcmcia left around, but I guess it would be nice to have
the driver for those who have the card. I would commit it.

(Continue reading)

headers

FUKAUMI Naoki | 3 Aug 2012 15:06

Re: malo <at> pci vs malo <at> pcmcia

On 08/01/2012 09:43 PM, KIYOHARA Takashi wrote:
> I have a 'I-O DATA WN-G54/CF'.  And some on-board 88W8686 has on
> pcmcia-bus of Gumstix.
> I think, malo <at> pcmcia and malo <at> pci is all different.  These drivers
> can't merge maybe.
>
> http://www.openbsd.org/cgi-bin/man.cgi?query=malo&apropos=0&sektion=0&manpath=OpenBSD+Current&arch=i386&format=html
>
>
> Shall I commit to tree the source for malo <at> pcmcia?
> If 'yes' then I will try to verify next week end.  

+static int
+malo_pcmcia_match(device_t parent, cfdata_t match, void *aux)
+{
+	struct pcmcia_attach_args *pa = aux;
+
+/* XXX */
+#undef PCMCIA_VENDOR_AMBICOM
+#define PCMCIA_VENDOR_AMBICOM	0x02df
+#define PCMCIA_PRODUCT_AMBICOM_WL54CF	0x8103
+/* I-O DATA WN-G54/CF has same vendor/product id as AmbiCom WL54-CF */
+
+	if (pa->manufacturer == PCMCIA_VENDOR_AMBICOM &&
+	    pa->product == PCMCIA_PRODUCT_AMBICOM_WL54CF)
+		return 1;
+
+	return 0;
+}

(Continue reading)