headers
Alexandr Shadchin | 10 Jul 2012 20:53
Picon

fix for ClickPad

Now in clickpad mode the pointer moves to [1,1] (upper left corner)
even on a single tap. These patches fixes it.

On issue pointed gilles <at>  and matthieu <at> 

* cd /sys
* patch < 01_kernel.diff
* build and install new kernel
* cd /usr/src
* (if need - make obj)
* make includes
* cd /usr/xenocara/driver/xf86-input-synaptics
* patch < 02_xenocara.diff
* make -f Makefile.bsd-wrapper obj build
* reboot and test

Also need check on other touchpad.

Comments ? OK ?

--

-- 
Alexandr Shadchin
Index: dev/pckbc/pms.c
===================================================================
RCS file: /cvs/src/sys/dev/pckbc/pms.c,v
retrieving revision 1.30
diff -u -p -r1.30 pms.c
--- dev/pckbc/pms.c	1 Jul 2012 12:59:34 -0000	1.30
+++ dev/pckbc/pms.c	10 Jul 2012 18:17:14 -0000
 <at>  <at>  -782,6 +782,9  <at>  <at>  int
(Continue reading)

Permalink | Reply |
headers
Gilles Chehade | 10 Jul 2012 22:21
Gravatar

Re: fix for ClickPad

For what it's worth, this fixes the issue on my laptop.
I still can't highlight a portion of a line, but at least I can copy / paste a word now \o/

Thanks a *LOT* as it was plenty annoying

Gilles

On Wed, Jul 11, 2012 at 12:53:00AM +0600, Alexandr Shadchin wrote:
> Now in clickpad mode the pointer moves to [1,1] (upper left corner)
> even on a single tap. These patches fixes it.
> 
> On issue pointed gilles <at>  and matthieu <at> 
> 
> * cd /sys
> * patch < 01_kernel.diff
> * build and install new kernel
> * cd /usr/src
> * (if need - make obj)
> * make includes
> * cd /usr/xenocara/driver/xf86-input-synaptics
> * patch < 02_xenocara.diff
> * make -f Makefile.bsd-wrapper obj build
> * reboot and test
> 
> Also need check on other touchpad.
> 
> Comments ? OK ?
> 
> -- 
> Alexandr Shadchin
(Continue reading)

Permalink | Reply |
headers
Matthieu Herrb | 11 Jul 2012 17:51
Picon
Picon
Favicon

Re: fix for ClickPad

On Wed, Jul 11, 2012 at 12:53:00AM +0600, Alexandr Shadchin wrote:
> Now in clickpad mode the pointer moves to [1,1] (upper left corner)
> even on a single tap. These patches fixes it.
> 
> On issue pointed gilles <at>  and matthieu <at> 
> 
> * cd /sys
> * patch < 01_kernel.diff
> * build and install new kernel
> * cd /usr/src
> * (if need - make obj)
> * make includes
> * cd /usr/xenocara/driver/xf86-input-synaptics
> * patch < 02_xenocara.diff
> * make -f Makefile.bsd-wrapper obj build
> * reboot and test
> 
> Also need check on other touchpad.
> 
> Comments ? OK ?
> 

Fixes the issue here too (Thinkpad X200). Not yet tested on other
touchpads I have. 
ok for the X part A few comments inline on the kernel part. 

(and of course you need to commit the kernel part first).

> -- 
> Alexandr Shadchin
(Continue reading)

Permalink | Reply |
headers
Alexandr Shadchin | 11 Jul 2012 18:15
Picon

Re: fix for ClickPad

On Wed, Jul 11, 2012 at 05:51:53PM +0200, Matthieu Herrb wrote:
> On Wed, Jul 11, 2012 at 12:53:00AM +0600, Alexandr Shadchin wrote:
> > Now in clickpad mode the pointer moves to [1,1] (upper left corner)
> > even on a single tap. These patches fixes it.
> > 
> > On issue pointed gilles <at>  and matthieu <at> 
> > 
> > * cd /sys
> > * patch < 01_kernel.diff
> > * build and install new kernel
> > * cd /usr/src
> > * (if need - make obj)
> > * make includes
> > * cd /usr/xenocara/driver/xf86-input-synaptics
> > * patch < 02_xenocara.diff
> > * make -f Makefile.bsd-wrapper obj build
> > * reboot and test
> > 
> > Also need check on other touchpad.
> > 
> > Comments ? OK ?
> > 
> 
> Fixes the issue here too (Thinkpad X200). Not yet tested on other
> touchpads I have. 
> ok for the X part A few comments inline on the kernel part. 
> 
> (and of course you need to commit the kernel part first).
> 
> > --
(Continue reading)

Permalink | Reply |
headers
Theo de Raadt | 22 Jul 2012 18:38
Picon
Favicon

Re: fix for ClickPad

You want this in now... and it has been tested on how many machines
to see if any new regressions show up?

Come on guys.  Don't have me OK this.  Instead, have me OK it based on
saying something like "This must go in".  You take the risk.  I don't
want to.
Permalink | Reply |
headers
Matthieu Herrb | 22 Jul 2012 19:52
Picon
Picon
Favicon

Re: fix for ClickPad

On Sun, Jul 22, 2012 at 10:38:50AM -0600, Theo de Raadt wrote:
> You want this in now... and it has been tested on how many machines
> to see if any new regressions show up?
> 
> Come on guys.  Don't have me OK this.  Instead, have me OK it based on
> saying something like "This must go in".  You take the risk.  I don't
> want to.

looking closer at my mail history, the patch is not as important as I
believed it was. (I thought it was part of the fix for all ALPS
touchpads that was discussend and committed while I was busy with work
and not looking too closely at patches, but this part has been
committed separatly).

Anyways, It fixes issues seen on synaptics clickpads (as found on the
X220 for example) for at least gilles <at>  and me. Other people with
clickpads have often de-activated them in the BIOS because of these
issues. Having that working in 5.2 would have been nice.

I've tested that patch on all my machines with pms (X40, X220,
toshiba, msi, samsung laptops, plus one desktop with a regular ps/2
mouse), but I it doesn't count. So it can wait after release, since
your comments seem to indicate that is this your preference.

Alexandr, just don't forget about it... 

--

-- 
Matthieu Herrb
(Continue reading)

Permalink | Reply |

Gmane